Skip to content

Integ sp8 2x1p support 13042026#258

Open
akky16 wants to merge 10 commits intointeg_sp8from
integ_sp8_2x1p_support_13042026
Open

Integ sp8 2x1p support 13042026#258
akky16 wants to merge 10 commits intointeg_sp8from
integ_sp8_2x1p_support_13042026

Conversation

@akky16
Copy link
Copy Markdown
Collaborator

@akky16 akky16 commented Apr 13, 2026

Add support for the APML devices device IDs in linux-aspeed for Venice A0/AB/B0 and SP8.

Testing is completed on AB platform and A0 platform.
Testing report and patch is shared in ticket: https://amd.atlassian.net/browse/DCSM-993

Major Changes:

  1. Add device IDs for A0/AB_B0/SP8
  2. Modify APML drivers to take dynamic address instead of static address.
  3. Remove IOD1 entries
  4. Remove hardcoding

Copy link
Copy Markdown
Collaborator

@modolaty modolaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add SP8 ID 11A to Hornbill, Eagle, Seagull, and Falcon

assigned-address = <0x3c>;
};

sbtsi_p0_sp8: sbtsi@0,2240000011A {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Morocco does not support SP8 IDs
Should be added to Hornbill and Seagull

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will revert back the commit, add to the SP8 dts files

};

sbrmi_p0_sp8: sbrmi@0,2240000111A {
reg = <0x0 0x224 0x0000111A>;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Morocco does not support SP8 IDs

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will revert back the commit, add to the SP8 dts files

reg = <0x0 0x224 0x00001119>;
assigned-address = <0x38>;
};

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Morocco does not support Sp8 IDs

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will revert back the commit, add to the SP8 dts files

reg = <0x0 0x224 0x00001119>;
assigned-address = <0x3c>;
};

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congo does not Support SP8

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean Kenya

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will revert back the commit, add to the SP8 dts files

reg = <0x0 0x224 0x00001119>;
assigned-address = <0x3c>;
};

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congo does not support SP8 IDs

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will revert back the commit, add to the SP8 dts files

reg = <0x0 0x224 0x00001119>;
assigned-address = <0x3c>;
};

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nigeria does not support SP8 IDs

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will revert back the commit, add to the SP8 dts files

reg = <0x0 0x224 0x00001119>;
assigned-address = <0x38>;
};

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nigeria does not Support SP8

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will revert back the commit

Comment thread arch/arm64/boot/dts/aspeed/aspeed-bmc-amd-congo.dts
Comment thread arch/arm64/boot/dts/aspeed/aspeed-bmc-amd-congo.dts
@akky16
Copy link
Copy Markdown
Collaborator Author

akky16 commented May 5, 2026

For this PR, will revert the SP8 changes, will create new PR for SP8 dts changes to Eagle/Falcon/Seagull/Hornbill

@akky16 akky16 force-pushed the integ_sp8_2x1p_support_13042026 branch from d91bd9f to 1802497 Compare May 5, 2026 06:59
@akky16
Copy link
Copy Markdown
Collaborator Author

akky16 commented May 5, 2026

@srgovard , @modolaty

I have updated the commit for SP8 dts files.
As of now I have update the below files:
eagle, falcon, hornbill and seagull.

I see few other files, such as

  1. ghana,
  2. nigerias3,
  3. Marley?,
    do these need to be updated?

@akky16
Copy link
Copy Markdown
Collaborator Author

akky16 commented May 5, 2026

For this PR, will revert the SP8 changes, will create new PR for SP8 dts changes to Eagle/Falcon/Seagull/Hornbill

Added changes as part of this PR

akky16 added 10 commits May 5, 2026 07:25
This reverts commit f5e5fbc.

Signed-off-by: Akshay Gupta <akshay.gupta@amd.com>
This reverts commit 868c5c8.

Signed-off-by: Akshay Gupta <akshay.gupta@amd.com>
This reverts commit 2914126.

Signed-off-by: Akshay Gupta <akshay.gupta@amd.com>
This reverts commit 287ff5e.

Signed-off-by: Akshay Gupta <akshay.gupta@amd.com>
Since the static address may be zero, update the device
address based on the dynamic address.

Signed-off-by: Akshay Gupta <akshay.gupta@amd.com>
Since the static address may be zero, update the device
address based on the dynamic address.

Signed-off-by: Akshay Gupta <akshay.gupta@amd.com>
- Add device tree entries for Venice A0 to support 2P and 2X1P
  for RMI and TSI devices
- This will provide the dynamic address to be used by user space
  applicaitons

Signed-off-by: Akshay Gupta <akshay.gupta@amd.com>
- Add device tree entries for APML devices (RMI/TSI) for Venice
  AB/B0 platforms.

Signed-off-by: Akshay Gupta <akshay.gupta@amd.com>
- Add device tree entries for APML devices (RMI/TSI) for SP8
  platforms.

Signed-off-by: Akshay Gupta <akshay.gupta@amd.com>
- Add I3C device IDs for the Venice AB/B0 and SP8 platforms,
  for RMI and TSI APML devices.

Signed-off-by: Akshay Gupta <akshay.gupta@amd.com>
@akky16 akky16 force-pushed the integ_sp8_2x1p_support_13042026 branch from 1802497 to ca9cd49 Compare May 5, 2026 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants