ci: added git-cliff changelog automation#49
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 115 115
=========================================
Hits 115 115 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hello @rpreen, could you have a look at this and let me know what you think? |
b903593 to
7e29096
Compare
14bb6c5 to
f0de8ea
Compare
|
I just took a quick look at this and I think the config needs tweaking - if you look at the toml in the Python ACRO repo I made some changes before it was merged - in particular there needs to be a default fall through with category 'other' to handle the cases where someone has merged/committed to the main branch without using conventional commits. |
Apply Richard's review on PR #49. cliff.toml: - Set filter_unconventional to false and add a final ".*" parser that groups leftover commits under "Other". - Rename group labels to readable names (Features, Bug Fixes, etc.). - Add preprocessors that strip Signed-off-by trailers and multi-line commit bodies, so each entry is one tidy subject line. - Set trim to false so a blank line separates each release. CONTRIBUTING.md: - Update the cliff.toml summary to describe the new "Other" behavior. Repo-specific bits kept: uppercase V tag pattern, ACRO-R PR URL.
|
Hi @rpreen, could you please have a look at my changes? I can't seem to pass the macOS CI check either.. |
|
@shamykyzer Can you look through our stand-up notes and see if any of the suggestions would help. |
|
Again, sorry @JessUWE for not checking the stand-up notes, this should be good to merge now. I switched to reticulate's own Python resolver instead of blindly picking the first Before: python <- get_python()After: python <- reticulate::virtualenv_starter()
if (is.null(python)) python <- get_python() |
@shamykyzer need to check this logic (using reticulate's resolver), because 'it's hard to install the R version" is a really common complaint from TREs. We need to make sure that we pick up the version of python that has acro installed - this will/should be in a virtual environment of its own, and that env should be pushed to the front of PATH - but all the relevant info should be in the installation / help guides |
● Closes #41.
Adds
git-cliffchangelog automation.NEWS.mdentries are generated fromConventional-Commits PR titles, run locally by the release manager before tagging.
cliff.toml: git-cliff config (groups by type, filters toV*tags, links(#NNN)to PRs, skips noise).CONTRIBUTING.md: documents the PR-title convention and release command..Rbuildignore: excludescliff.tomlfrom the package tarball.