Skip to content

fix: wire click handler for note_link fields in Fields tab#169

Closed
careck wants to merge 1 commit intomasterfrom
fix/field-display-note-link-click
Closed

fix: wire click handler for note_link fields in Fields tab#169
careck wants to merge 1 commit intomasterfrom
fix/field-display-note-link-click

Conversation

@careck
Copy link
Copy Markdown
Member

@careck careck commented Apr 28, 2026

Summary

  • Clicking a note_link in the default Fields tab did nothing — the <a class="kn-view-link"> had no click handler
  • The delegated click handler only existed on the custom view HTML div, not the React-rendered Fields section
  • Wraps the Fields tab content in a div with the same .kn-view-link delegation pattern

Test plan

  • Select a note with a note_link field (e.g. Activity linking to a Location)
  • Switch to the Fields tab
  • Click the linked note name — should navigate to that note

NoteLinkDisplay renders <a class="kn-view-link"> elements but the
delegated click handler only existed on the custom view HTML div.
The Fields tab had no handler, so clicking note links did nothing.

Wrap the Fields tab content in a div with the same delegation pattern.
careck added a commit that referenced this pull request Apr 28, 2026
Duplicate of fix/field-display-note-link-click (PR #169) applied
to master so the travel-planner example works end-to-end.
@careck careck closed this Apr 29, 2026
@careck careck deleted the fix/field-display-note-link-click branch April 29, 2026 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant