fix: resolve cargo fmt and clippy errors breaking CI#165
Merged
Conversation
All CI runs were failing at `cargo fmt --check` (3 formatting diffs), with 35 additional clippy warnings-as-errors hidden behind the gate.
CI runs Rust 1.95 stable which has stricter lints than local 1.93.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo fmt --checkstep — 3 formatting diffs inexport_tests.rsandnotes.rs(commands)cargo clippy -- -D warningshad 35 errors across all 3 workspace crates (krillnotes-core,krillnotes-rbac,krillnotes-desktop), accumulated as newer Rust stable versions added lints#[allow(...)]for architectural choices (type_complexity, too_many_arguments)Test plan
cargo fmt --checkpassescargo clippy --workspace -- -D warningspasses (0 errors)cargo test -p krillnotes-core— all tests pass