Skip to content

fix: resolve cargo fmt and clippy errors breaking CI#165

Merged
careck merged 4 commits intomasterfrom
fix/clippy-ci
Apr 28, 2026
Merged

fix: resolve cargo fmt and clippy errors breaking CI#165
careck merged 4 commits intomasterfrom
fix/clippy-ci

Conversation

@careck
Copy link
Copy Markdown
Member

@careck careck commented Apr 28, 2026

Summary

  • All CI runs were failing at the cargo fmt --check step — 3 formatting diffs in export_tests.rs and notes.rs (commands)
  • Behind that gate, cargo clippy -- -D warnings had 35 errors across all 3 workspace crates (krillnotes-core, krillnotes-rbac, krillnotes-desktop), accumulated as newer Rust stable versions added lints
  • Fixed all issues: mechanical cleanups (unnecessary casts, redundant closures, needless borrows, extend→append, format args, map_or→is_none_or, manual clamp, derivable impl, const thread_local, match→if let), doc formatting, and #[allow(...)] for architectural choices (type_complexity, too_many_arguments)

Test plan

  • cargo fmt --check passes
  • cargo clippy --workspace -- -D warnings passes (0 errors)
  • cargo test -p krillnotes-core — all tests pass

careck added 4 commits April 28, 2026 16:30
All CI runs were failing at `cargo fmt --check` (3 formatting diffs),
with 35 additional clippy warnings-as-errors hidden behind the gate.
CI runs Rust 1.95 stable which has stricter lints than local 1.93.
@careck careck merged commit cb1e1fa into master Apr 28, 2026
2 checks passed
@careck careck deleted the fix/clippy-ci branch April 28, 2026 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant