fix: propagate errors in RocksDB iterators

[Mr-kay-cloud2]

This PR addresses issue #1729 by replacing silent .ok()? usage in RocksDB iterators with proper error propagation.

Changes:

• Updated iterator to return Result<(u64, SmtLeaf), StorageError>
• Replaced .ok()? with explicit error handling
• Prevents silently skipping corrupted entries

This improves reliability and makes storage corruption visible instead of hidden.

[Mirko-von-Leipzig]

This file seems like it tagged along by accident.

[kkovaacs]

Did check the changes but this doesn't even compile. Can you please fix the errors?

[Mr-kay-cloud2]

Resolved merge conflicts and updated changelog. Ready for review.

[kkovaacs]

Still doesn't compile for me.

Have you tried running make test? Does it pass for you?

[Mr-kay-cloud2]

Thanks for checking this.

I ran cargo test locally and all tests pass on my end.
Please let me know if you're seeing a specific compilation error or environment issue happy to investigate further.

[Mirko-von-Leipzig]

AI can't read :)

[Mr-kay-cloud2]

I am not AI, If you want logs I could give it

[Mirko-von-Leipzig]

I am not AI, If you want logs I could give it

Alright, but could you then run make test (not just cargo test).

[Mr-kay-cloud2]

I did run make test early this morning
I would run it now and send a screenshot, is that good?

[Mirko-von-Leipzig]

I did run make test early this morning I would run it now and send a screenshot, is that good?

Apologies, was because your comment said cargo test, not make test. Its a bit of a difficult time with AI agents running around :)

[Mr-kay-cloud2]

I did run make test early this morning I would run it now and send a screenshot, is that good?

Apologies, was because your comment said cargo test, not make test. Its a bit of a difficult time with AI agents running around :)

It's alright buddy, I totally get it.

[Mr-kay-cloud2]

Thanks for the suggestion I ran make test locally.

The test suite starts and runs successfully but gets terminated near the end with:

SIGTERM
Error 100

To verify my changes, I ran targeted tests for the affected crate:

cargo nextest run -p miden-node-store --jobs 1

Result:

142 tests run: 142 passed, 0 skipped

So the relevant tests pass locally. Happy to investigate further if there's a specific failure or environment detail you'd like me to check.