Harden model streaming for 2048 demo#34
Conversation
DeepSeekCode review of PR #34 (Harden model streaming for 2048 demo)Let me examine the repository structure and the changed files to understand the PR. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8f74447e99
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| rm -f -- index.html styles.css app.js | ||
| git reset -q --hard HEAD |
There was a problem hiding this comment.
Reset the demo repo fully between retry attempts
When a model attempt fails, reset_demo_attempt only removes index.html/styles.css/app.js and runs git reset --hard HEAD, which leaves any other untracked files from that attempt in place. Because write_file can still create additional paths, a retry may run against a non-empty workspace and validation can pass with stale artifacts, undermining the script’s reproducibility guarantee for “empty repo” demo captures.
Useful? React with 👍 / 👎.
Summary
Verification