Skip to content

Harden model streaming for 2048 demo#34

Merged
willamhou merged 1 commit into
mainfrom
model-stream-timeout-demo-retry
May 24, 2026
Merged

Harden model streaming for 2048 demo#34
willamhou merged 1 commit into
mainfrom
model-stream-timeout-demo-retry

Conversation

@willamhou
Copy link
Copy Markdown
Owner

Summary

  • raise streamed tool-call max tokens to 4096 with bounded env override
  • raise streaming timeout defaults and expose demo-specific overrides
  • make the 2048 recorder reproducible with an isolated HOME, temporary demo skill, retry cleanup, and stronger post-run validation

Verification

  • cargo fmt --check
  • git diff --check
  • node scripts/check-secrets.js
  • bash -n docs/demo/record-2048-demo.sh
  • docs/demo/record-2048-demo.sh --dry-run
  • docs/demo/record-2048-demo.sh --redaction-self-test
  • cargo test --lib
  • cargo build --bin deepseek
  • live: docs/demo/record-2048-demo.sh

@github-actions
Copy link
Copy Markdown

DeepSeekCode review of PR #34 (Harden model streaming for 2048 demo)

Let me examine the repository structure and the changed files to understand the PR.

@willamhou willamhou merged commit 5f98863 into main May 24, 2026
5 checks passed
@willamhou willamhou deleted the model-stream-timeout-demo-retry branch May 24, 2026 08:06
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8f74447e99

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +266 to +267
rm -f -- index.html styles.css app.js
git reset -q --hard HEAD
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reset the demo repo fully between retry attempts

When a model attempt fails, reset_demo_attempt only removes index.html/styles.css/app.js and runs git reset --hard HEAD, which leaves any other untracked files from that attempt in place. Because write_file can still create additional paths, a retry may run against a non-empty workspace and validation can pass with stale artifacts, undermining the script’s reproducibility guarantee for “empty repo” demo captures.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant