Skip to content

Improve first-run config and add 2048 demo recorder#30

Merged
willamhou merged 1 commit into
mainfrom
first-run-and-2048-demo
May 24, 2026
Merged

Improve first-run config and add 2048 demo recorder#30
willamhou merged 1 commit into
mainfrom
first-run-and-2048-demo

Conversation

@willamhou
Copy link
Copy Markdown
Owner

Summary

  • add CLI config provider/model show/list/set commands and surface model/base URL in quickstart
  • add a model-backed 2048 demo recorder with transcript, validation, optional preview server, and redaction checks
  • document the 2048 launch asset path and update current status/install docs

Verification

  • cargo fmt --check
  • cargo test --lib -- --test-threads=1
  • bash -n docs/demo/record-2048-demo.sh
  • docs/demo/record-2048-demo.sh --dry-run
  • docs/demo/record-2048-demo.sh --redaction-self-test
  • node scripts/check-secrets.js
  • git diff --check
  • cargo run --quiet -- config provider list
  • cargo run --quiet -- config model list
  • cargo run --quiet -- config provider show
  • cargo run --quiet -- quickstart --json

@github-actions
Copy link
Copy Markdown

DeepSeekCode review of PR #30 (Improve first-run config and add 2048 demo recorder)

Let me fetch the PR diff from the remote branch.

@willamhou willamhou merged commit 29345b3 into main May 24, 2026
5 checks passed
@willamhou willamhou deleted the first-run-and-2048-demo branch May 24, 2026 06:44
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d1a99597f4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +70 to +71
ConfigModelAction::Show => {
let summary = model_config_summary_at(&cwd)?;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep config show/list commands read-only

This new config model/provider path calls model_config_summary_at/provider_config_summary_at, which in turn call init_config_at when .dscode/config.toml is missing, so a read-only command like deepseek config provider show can create config/hook files in a clean repo. That side effect will unexpectedly dirty worktrees (including the quickstart-recommended flow) and violates the expected semantics of show/list introspection commands.

Useful? React with 👍 / 👎.

Comment on lines +256 to +257
run_session 2>&1 | redact_demo_stream | tee "$demo_out"
session_status=${PIPESTATUS[0]}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Propagate transcript pipeline failures

The script stores only PIPESTATUS[0] after run_session | redact_demo_stream | tee "$demo_out", so it reports success whenever run_session succeeds even if redaction or tee fails (for example, output path not writable or disk full). In those cases the command can exit 0 with a missing/partial transcript, which breaks launch-evidence automation and hides capture failures.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant