Prepare v0.1.3 linux arm64 release#26
Conversation
DeepSeekCode review of PR #26 (Prepare v0.1.3 linux arm64 release)Let me examine the PR diff and key files to understand the changes. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7e0cdb7812
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if Hardware::CPU.intel? | ||
| url "https://github.com/{repo}/releases/download/{tag}/deepseek-linux-x64.tar.gz" | ||
| sha256 "{linux_x64}" | ||
| elsif Hardware::CPU.arm? |
There was a problem hiding this comment.
Restrict Linux ARM formula branch to 64-bit only
The Homebrew formula template uses Hardware::CPU.arm? for the Linux ARM branch, but that predicate matches any ARM CPU, including 32-bit ARM. This means a 32-bit ARM Linux host will be routed to the deepseek-linux-arm64.tar.gz artifact and then fail at runtime with an incompatible binary (Exec format error), even though the message says only x64/arm64 are published. The condition should be narrowed to arm64 (for example Hardware::CPU.arm64? or Hardware::CPU.arm? && Hardware::CPU.is_64_bit?).
Useful? React with 👍 / 👎.
Summary
Local Verification