Add Linux/macOS CLI readiness gates#14
Conversation
DeepSeekCode review of PR #14 (Add Linux/macOS CLI readiness gates)Let me examine the PR diff and repository structure to understand the changes. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 71d7c0ab1a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| exit 1 | ||
| fi | ||
|
|
||
| task='replace `return amount - discount` with `return max(amount - discount, 0.0)` in src/invoice_math/pricing.py and replace `Invoice total` with `Final total` in src/invoice_math/summary.py, validate with python -m unittest discover -s tests' |
There was a problem hiding this comment.
The script detects python3/python into python_bin, but the generated task string still hard-codes validate with python -m unittest discover -s tests. On environments that have python3 but no python (a common macOS/Linux setup), the scaffold itself succeeds and reports ready, but the emitted dry-run/evidence commands will fail at validation with python: command not found, breaking the primary workflow this script is meant to gate.
Useful? React with 👍 / 👎.
willamhou
force-pushed
the
linux-macos-cli-readiness-20260523
branch
from
71d7c0a to
d8fdc8b
Compare
DeepSeekCode review of PR #14 (Add Linux/macOS CLI readiness gates)Let me examine the PR diff and repository structure to understand the changes. |
willamhou
force-pushed
the
linux-macos-cli-readiness-20260523
branch
from
d8fdc8b to
36aa928
Compare
DeepSeekCode review of PR #14 (Add Linux/macOS CLI readiness gates)Let me examine the PR diff and repository structure more thoroughly. |
1 participant
Summary
scripts/create-multifile-external-fixture.shfor a disposable Python invoice multi-file dogfood repo and document the dry-run/evidence flow.Validation
scripts/create-multifile-external-fixture.sh /tmp/deepseek-external-fixture-smoke-20260523-btarget/debug/deepseek dogfood external-fixture --workdir /tmp/deepseek-external-fixture-smoke-20260523-b --dry-run 'replace \return amount - discount` with `return max(amount - discount, 0.0)` in src/invoice_math/pricing.py and replace `Invoice total` with `Final total` in src/invoice_math/summary.py, validate with python -m unittest discover -s tests'`timeout 10s target/debug/deepseek agents shell-fixture-smoke --jsontimeout 15s target/debug/deepseek agents service-smoke --workdir /tmp/dsc-smk --bin target/debug/deepseek --jsontarget/debug/deepseek tui --entrypoint-smoke --smoke-bin target/debug/deepseektarget/debug/deepseek task fixture-smoke --jsontarget/debug/deepseek github fixture-smoke --jsongit diff --checkcargo fmt --checknode scripts/check-secrets.jspython3 -c "import yaml; yaml.safe_load(open('.github/workflows/ci.yml')); yaml.safe_load(open('.github/workflows/release.yml'))"cargo test --lib -- --test-threads=1(1632 passed)