Skip to content

web-push-php API signature change #345

@sadektouati

Description

@sadektouati

I lost countless hours trying to make it send the payload.
I used this code Subscription::create([ 'endpoint' => $endpoint, $p256dh, $keys_auth, 'contentEncoding' => 'aesgcm', ]),
Notice I used position parameters and it gives no error (except in the case of "endpoint").

Instead, it should be like this:
Subscription::create([ 'endpoint' => $endpoint, 'publicKey' => $p256dh, 'authToken' => $keys_auth, 'contentEncoding' => 'aesgcm', ]),

I think it should raise an error if any of the parameters is provided without a name.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions