stdarch-gen-hexagon-scalar: Do not emit inline(always) if target_feature is used#2133
Conversation
|
r? @adamgemmell rustbot has assigned @adamgemmell. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
CI failure seems to be unrelated https://github.com/rust-lang/stdarch/actions/runs/26325152273/job/77501386688?pr=2133 I don't know anything about the current status of const impl, but the code in rust-lang/rust is the same, and it seems that both
|
Added |
stdarch-gen-hexagon-scalar, which added in #2072, always emits
#[inline(always)], but it cause compile errors on functions that have#[target_feature].hexagon-unknown-linux-musl build is broken due to this issue since nightly-2026-05-22: https://github.com/taiki-e/atomic-maybe-uninit/actions/runs/26266025199/job/77310173101#step:4:929
This PR fixes it by emitting
#[inline]instead of#[inline(always)]if#[target_feature]is used.(Confirmed with
cargo +nightly-2026-05-21 build -Z build-std=core -p core_arch --target hexagon-unknown-linux-musl)This also add missing stdarch-gen output check for stdarch-gen-hexagon-scalar.
cc @androm3da
cc rust-lang/rust#151523
Fixes #2134