Tag nightly versions with date#274
Open
Muscraft wants to merge 6 commits into
Open
Conversation
Kobzol
approved these changes
May 23, 2026
Member
Kobzol
left a comment
Kobzol
left a comment
There was a problem hiding this comment.
Can't say I can read the whole bash logic 😆 But the logic makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tagging the nightly images with the date has been requested in the past (rust-lang/docker-rust-nightly#3, #177, #general > docker nightly pinned), and after looking at it again, I think it would make sense to support it. The biggest concern is the large number of additional tags this would add (~4000), but it does not appear to be an issue for GHCR or Docker Hub. I looked into the limits for both services, and neither mentioned an upper limit on tags. On Docker Hub,
instrumentisto/rustused to tag Rust's nightly images for some time before it was recently archived.@sfackler
@Kobzol