From f6f6300eef9d5523e355d91732ef03c493464e70 Mon Sep 17 00:00:00 2001 From: NickSxti Date: Thu, 30 Apr 2026 14:44:22 +0400 Subject: [PATCH 1/3] Fix Kotlin compiler warnings (#439) Co-Authored-By: Claude Opus 4.7 (1M context) --- .../com/qonversion/reactnativesdk/QonversionModule.kt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/android/src/main/java/com/qonversion/reactnativesdk/QonversionModule.kt b/android/src/main/java/com/qonversion/reactnativesdk/QonversionModule.kt index 2713ba3e..5b8660db 100644 --- a/android/src/main/java/com/qonversion/reactnativesdk/QonversionModule.kt +++ b/android/src/main/java/com/qonversion/reactnativesdk/QonversionModule.kt @@ -23,7 +23,7 @@ class QonversionModule(reactContext: ReactApplicationContext) : NativeQonversion (reactContext.applicationContext as Application), object : ActivityProvider { override val currentActivity: Activity? - get() = this@QonversionModule.currentActivity + get() = reactApplicationContext.currentActivity }, this ) @@ -299,9 +299,9 @@ class QonversionModule(reactContext: ReactApplicationContext) : NativeQonversion emitOnEntitlementsUpdated(mappedEntitlements) } - override fun onDeferredPurchaseCompleted(purchaseResult: BridgeData) { - val mappedPurchaseResult = EntitiesConverter.convertMapToWritableMap(purchaseResult) - emitOnDeferredPurchaseCompleted(mappedPurchaseResult) + override fun onDeferredPurchaseCompleted(transaction: BridgeData) { + val mappedTransaction = EntitiesConverter.convertMapToWritableMap(transaction) + emitOnDeferredPurchaseCompleted(mappedTransaction) } companion object { From 18f7e4f9a055f9ff279aa3e48a9256f33d1f7cf3 Mon Sep 17 00:00:00 2001 From: NickSxti Date: Thu, 30 Apr 2026 19:44:35 +0400 Subject: [PATCH 2/3] Restore purchaseResult param name; suppress supertype-mismatch warning The previous commit renamed the onDeferredPurchaseCompleted override parameter to match the supertype's transaction name, but that reverted a deliberate review-driven rename (commit 801d40d) that aligned Android with iOS (RNQonversion.mm uses purchaseResult). Restore purchaseResult and silence the Kotlin override-mismatch warning with @Suppress instead of renaming. Co-Authored-By: Claude Opus 4.7 (1M context) --- .../java/com/qonversion/reactnativesdk/QonversionModule.kt | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/android/src/main/java/com/qonversion/reactnativesdk/QonversionModule.kt b/android/src/main/java/com/qonversion/reactnativesdk/QonversionModule.kt index 5b8660db..81957400 100644 --- a/android/src/main/java/com/qonversion/reactnativesdk/QonversionModule.kt +++ b/android/src/main/java/com/qonversion/reactnativesdk/QonversionModule.kt @@ -299,9 +299,10 @@ class QonversionModule(reactContext: ReactApplicationContext) : NativeQonversion emitOnEntitlementsUpdated(mappedEntitlements) } - override fun onDeferredPurchaseCompleted(transaction: BridgeData) { - val mappedTransaction = EntitiesConverter.convertMapToWritableMap(transaction) - emitOnDeferredPurchaseCompleted(mappedTransaction) + @Suppress("PARAMETER_NAME_CHANGED_ON_OVERRIDE") + override fun onDeferredPurchaseCompleted(purchaseResult: BridgeData) { + val mappedPurchaseResult = EntitiesConverter.convertMapToWritableMap(purchaseResult) + emitOnDeferredPurchaseCompleted(mappedPurchaseResult) } companion object { From 233d1534ccc2797e93ad604df76aefc97142025f Mon Sep 17 00:00:00 2001 From: NickSxti Date: Thu, 30 Apr 2026 20:41:50 +0400 Subject: [PATCH 3/3] Drop @Suppress; supertype mismatch will be fixed in sandwich-sdk Removing the @Suppress annotation. The override-vs-supertype param-name warning is the root-cause symptom of sandwich-sdk's QonversionEventsListener declaring 'transaction' while iOS and the rest of the RN bridge use 'purchaseResult'. That will be fixed at the source via a sandwich-sdk PR to rename the supertype param. After that lands and we bump io.qonversion:sandwich, this override will silently match. Until then, the warning is acceptable. Co-Authored-By: Claude Opus 4.7 (1M context) --- .../main/java/com/qonversion/reactnativesdk/QonversionModule.kt | 1 - 1 file changed, 1 deletion(-) diff --git a/android/src/main/java/com/qonversion/reactnativesdk/QonversionModule.kt b/android/src/main/java/com/qonversion/reactnativesdk/QonversionModule.kt index 81957400..7ac70da4 100644 --- a/android/src/main/java/com/qonversion/reactnativesdk/QonversionModule.kt +++ b/android/src/main/java/com/qonversion/reactnativesdk/QonversionModule.kt @@ -299,7 +299,6 @@ class QonversionModule(reactContext: ReactApplicationContext) : NativeQonversion emitOnEntitlementsUpdated(mappedEntitlements) } - @Suppress("PARAMETER_NAME_CHANGED_ON_OVERRIDE") override fun onDeferredPurchaseCompleted(purchaseResult: BridgeData) { val mappedPurchaseResult = EntitiesConverter.convertMapToWritableMap(purchaseResult) emitOnDeferredPurchaseCompleted(mappedPurchaseResult)