Add SAPI module folder to DLL search path

[hoangngx]

Description

I added "extension=amqp" in php.ini file, as well as the php_amqp.dll file in "C:\xampp\php\ext", and 2 additional files
rabbitmq.4.dll and rabbitmq.4.pdb in "C:\xampp\php", but the following error appears:

PHP Warning: PHP Startup: Unable to load dynamic library 'amqp' (tried: C:\xampp\php\ext\amqp (The specified module could not be found), C:\xampp\php\ext\php_amqp.dll (The specified module could not be found)) in Unknown on line 0

PHP Version

PHP 8.2.12

Operating System

Windows 10

[cmb69]

PHP extension DLLs (php_amqp.dll) are looked up in the extension_dir; their dependencies (rabbitmq.4.dll) are looked up in the PATH. Use phpinfo() to find out which folders are in the PATH and put rabbitmq.4.dll in one of these folders (C:\xampp\bin might be a good option).

[salem-zitoun]

J'ai le meme problème

[cmb69]

Well, that is a pretty common problem. For many SAPIs (CLI, CGI), it works fine if you put dependencies of extensions in the folder where php.exe/php-cgi.exe resides. That does usually not work when PHP is run as Webserver module. That might also be relevant for PIE (cc @asgrim).

We could tell the system to also look in the folder where the Webserver module resides.

quick and dirty patch for apache2handler

 sapi/apache2handler/sapi_apache2.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/sapi/apache2handler/sapi_apache2.c b/sapi/apache2handler/sapi_apache2.c
index 1d85a92ebf..25f94a64c2 100644
--- a/sapi/apache2handler/sapi_apache2.c
+++ b/sapi/apache2handler/sapi_apache2.c
@@ -383,6 +383,13 @@ extern zend_module_entry php_apache_module;
 
 static int php_apache2_startup(sapi_module_struct *sapi_module)
 {
+	HMODULE mod;
+	wchar_t filename[1024];
+	GetModuleHandleEx(GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS, (LPCTSTR)php_apache2_startup, &mod);
+	GetModuleFileNameW(mod, filename, 1024);
+	wchar_t *slash = wcsrchr(filename, L'\\');
+	slash[0] = L'\0';
+	SetDllDirectoryW(filename);
 	return php_module_startup(sapi_module, &php_apache_module);
 }

We need to thoroughly consider BC and security implications, though.

PS: should also pass GET_MODULE_HANDLE_EX_FLAG_UNCHANGED_REFCOUNT to GetModuleHandleEx(). And for reference: https://learn.microsoft.com/en-us/windows/win32/api/Winbase/nf-winbase-setdlldirectorya

[asgrim]

Well, that is a pretty common problem. For many SAPIs (CLI, CGI), it works fine if you put dependencies of extensions in the folder where php.exe/php-cgi.exe resides. That does usually not work when PHP is run as Webserver module. That might also be relevant for PIE (cc @asgrim).

thanks for the ping, I believe PIE does this correctly already:

The pre-built ZIP should contain at minimum a DLL named in the same way as the ZIP itself, for example php_{extension-name}-{tag}-{php-maj/min}-{ts|nts}-{compiler}-{arch}.dll. The .dll will be moved into the PHP extensions path, and renamed, e.g. to C:\path\to\php\ext\php_{extension-name}.dll. The ZIP file may include additional resources, such as:

• php_{extension-name}.pdb - this will be moved alongside the C:\path\to\php\ext\php_{extension-name}.dll
• *.dll - any other .dll would be moved alongside C:\path\to\php\php.exe
• Any other file, which would be moved into C:\path\to\php\extras\{extension-name}\.

[cmb69]

Thanks @asgrim; the relevant item:

*.dll - any other .dll would be moved alongside C:\path\to\php\php.exe

This is exactly how it should be done (as good as it gets), but that will (usually) not work with Webserver modules (like apache2handler). Amongst other locations, Windows searches for DLLs where the .exe which needs them is placed. So to make that work for Apache, you either put httpd.exe and php.exe in the same folder (total mess), or you put the folder of php.exe in the PATH (only necessary if you plan to call php.exe via exec() and friends). The third option is to put these DLLs somewhere in the PATH; many just put stuff into C:\Windows\System32, but I consider that bad practice.

Anyhow, I'll submit a PR for this issue soon, and shall also actually try out PIE. :)