Create typescript type definitions#2
Open
natekfl wants to merge 2 commits into
Open
Conversation
jue89
reviewed
Oct 20, 2020
Owner
jue89
left a comment
jue89
left a comment
There was a problem hiding this comment.
Thanks for your PR!
I'll have a deeper look soon. But I already found something to comment on ;)
| mode: "netascii" | "octet" | "mail" | ||
| } | ||
| export type Response = (buf: Buffer) => void | ||
| export type Handler = (req: Request, res: Response, next: () => void) => void |
Owner
There was a problem hiding this comment.
The next callback has an optional parameter that takes an instance of Error to abort the handle lookup.
Add err to next(), and change default parameter in createServer to optional as d.ts files don't support default parameters without implementations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.