From 3d360006fe672326a5c8edca99c552d26b13cbfc Mon Sep 17 00:00:00 2001 From: Tony Mountifield Date: Thu, 30 Apr 2026 17:20:27 +0100 Subject: [PATCH] Add missing override specifiers Satisfies compiler warnings on macOS --- src/clientsettingsdlg.h | 2 +- src/sound/coreaudio-mac/sound.h | 38 ++++++++++++++++----------------- 2 files changed, 20 insertions(+), 20 deletions(-) diff --git a/src/clientsettingsdlg.h b/src/clientsettingsdlg.h index 4baf50f5e5..acd584b559 100644 --- a/src/clientsettingsdlg.h +++ b/src/clientsettingsdlg.h @@ -69,7 +69,7 @@ class CClientSettingsDlg : public CBaseDlg, private Ui_CClientSettingsDlgBase void UpdateAudioFaderSlider(); QString GenSndCrdBufferDelayString ( const int iFrameSize, const QString strAddText = "" ); - virtual void showEvent ( QShowEvent* ); + virtual void showEvent ( QShowEvent* ) override; virtual bool eventFilter ( QObject* obj, QEvent* event ) override; CClient* pClient; diff --git a/src/sound/coreaudio-mac/sound.h b/src/sound/coreaudio-mac/sound.h index 6ed3990a19..924528dd14 100644 --- a/src/sound/coreaudio-mac/sound.h +++ b/src/sound/coreaudio-mac/sound.h @@ -42,28 +42,28 @@ class CSound : public CSoundBase virtual ~CSound(); - virtual int Init ( const int iNewPrefMonoBufferSize ); - virtual void Start(); - virtual void Stop(); + virtual int Init ( const int iNewPrefMonoBufferSize ) override; + virtual void Start() override; + virtual void Stop() override; // channel selection - virtual int GetNumInputChannels() { return iNumInChanPlusAddChan; } - virtual QString GetInputChannelName ( const int iDiD ) { return sChannelNamesInput[iDiD]; } - virtual void SetLeftInputChannel ( const int iNewChan ); - virtual void SetRightInputChannel ( const int iNewChan ); - virtual int GetLeftInputChannel() { return iSelInputLeftChannel; } - virtual int GetRightInputChannel() { return iSelInputRightChannel; } - - virtual int GetNumOutputChannels() { return iNumOutChan; } - virtual QString GetOutputChannelName ( const int iDiD ) { return sChannelNamesOutput[iDiD]; } - virtual void SetLeftOutputChannel ( const int iNewChan ); - virtual void SetRightOutputChannel ( const int iNewChan ); - virtual int GetLeftOutputChannel() { return iSelOutputLeftChannel; } - virtual int GetRightOutputChannel() { return iSelOutputRightChannel; } + virtual int GetNumInputChannels() override { return iNumInChanPlusAddChan; } + virtual QString GetInputChannelName ( const int iDiD ) override { return sChannelNamesInput[iDiD]; } + virtual void SetLeftInputChannel ( const int iNewChan ) override; + virtual void SetRightInputChannel ( const int iNewChan ) override; + virtual int GetLeftInputChannel() override { return iSelInputLeftChannel; } + virtual int GetRightInputChannel() override { return iSelInputRightChannel; } + + virtual int GetNumOutputChannels() override { return iNumOutChan; } + virtual QString GetOutputChannelName ( const int iDiD ) override { return sChannelNamesOutput[iDiD]; } + virtual void SetLeftOutputChannel ( const int iNewChan ) override; + virtual void SetRightOutputChannel ( const int iNewChan ) override; + virtual int GetLeftOutputChannel() override { return iSelOutputLeftChannel; } + virtual int GetRightOutputChannel() override { return iSelOutputRightChannel; } // MIDI functions - virtual void EnableMIDI ( const bool bEnable ); - virtual bool IsMIDIEnabled() const; + virtual void EnableMIDI ( const bool bEnable ) override; + virtual bool IsMIDIEnabled() const override; virtual QStringList GetMIDIDevNames() override; // these variables/functions should be protected but cannot since we want @@ -97,7 +97,7 @@ class CSound : public CSoundBase CVector vecNumOutBufChan; protected: - virtual QString LoadAndInitializeDriver ( QString strDriverName, bool ); + virtual QString LoadAndInitializeDriver ( QString strDriverName, bool ) override; QString CheckDeviceCapabilities ( const int iDriverIdx ); void UpdateChSelection();