Document Final Review page should also show Action Holders

[ajeanmahoney]

When Action Holders are assigned, the final review page for the document should list them. For example, draft-ietf-scim-device-model has both AD and IANA action holders.

See https://queue.staging.rfc-editor.org/final-review/draft-ietf-scim-device-model/ vs https://www.rfc-editor.org/auth48/rfc9944

[rudimatz]

action holders are currently not provided by purple, will add them

[rudimatz]

        "actionholder_set": [
            {
                "id": 2685,
                "person": {
                    "person_id": 1,
                    "name": "(System)",
                    "email": "system@datatracker.ietf.org",
                    "picture": "",
                    "datatracker_url": "http://localhost:8000/person/system@datatracker.ietf.org"
                },
                "deadline": null,
                "since_when": "2026-04-17T21:28:50Z",
                "completed": null,
                "comment": "Original approver name: IANA (migration script)",
                "body": "iana"
            }
        ],

action holders are submitted in pubq/queue payload

[holloway]

Thanks, I've added that the precomputer but the website doesn't use it yet

[holloway]

Done

[holloway]

eg https://queue.staging.rfc-editor.org/final-review/rfc9965/

[holloway]

I'm going to close this. Please reopen if there's anything remaining to do.

[ajeanmahoney]

I see action holders for some RFCs-to-be, but not others. It seems action holders are shown only when it is IANA.

For example, https://purple.staging.rfc-editor.org/docs/draft-ietf-scitt-architecture/approvals has both IANA and an AD listed as action holders, but https://queue.staging.rfc-editor.org/final-review/rfc9943/ only shows IANA.

Another example: https://purple.staging.rfc-editor.org/docs/draft-ietf-cose-merkle-tree-proofs/approvals lists an AD as action holder, but https://queue.staging.rfc-editor.org/final-review/rfc9942/ does not.

[holloway]

@rudimatz any ideas? In https://queue.staging.rfc-editor.org/api/v1/queue/index.json

• RFC-to-be 9943 has 1 action holder not 2
• RFC-to-be 9942 has 0 action holders

That JSON comes from a call to apiPubqQueueList. Does apiPubqQueueList param pendingFinalApproval affect the amount of action holders for a given rfc-to-be?

[rudimatz]

@holloway @ajeanmahoney
The API currently only returns active ActionHolders, those that are not marked as completed.
If we wanna change it, let me know

[ajeanmahoney]

IIUC if an action holder has approved, then they no longer appear on the Final Review page? They should continue to be listed along with the date of their approval.