feat(magento-fixed-product-taxes): add new package#2628
Open
paales wants to merge 1 commit into
Open
Conversation
New `@graphcommerce/magento-fixed-product-taxes` package that renders Magento's Fixed Product Taxes (FPT / WEEE / GreenTax) on product pages and inside cart items. Driven by the store-config display setting: - `FPT_DISABLED` / `*_WITHOUT_DETAILS` — nothing extra rendered. - `INCLUDE_FPT_WITH_DETAILS` — per-tax label + amount shown next to the price. - `EXCLUDE_FPT_AND_INCLUDE_WITH_DETAILS` — also appends a "Final price" line that adds FPT to the base. Ports the unfinished package from the `feature/todo-list-paul` branch and completes the cart-item plugin (which was an empty stub on the branch). Wiring: - `hooks/useFixedProductTaxes.tsx` — reads the display setting from store config and returns the resulting render flags. - `plugins/FixedProductTaxesProductPagePrice.tsx` — wraps `ProductPagePrice` and renders the tax breakdown. - `plugins/FixedProductTaxesCartItem.tsx` — wraps `CartItemActionCard` and adds tax lines into the `details` slot. - Fragment injections add the necessary fields to `CartItem`, `ProductPrice`, and `StoreConfigFragment` without changing those packages. Activate with `PRIVATE_ADDITIONAL_DEPENDENCIES="@graphcommerce/magento-fixed-product-taxes"`.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 543f491 The changes in this PR will be included in the next version bump. This PR includes changesets to release 87 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New
@graphcommerce/magento-fixed-product-taxespackage that renders Magento's Fixed Product Taxes (FPT / WEEE / GreenTax) on product pages and inside cart items. Display is driven by Magento'sStoreConfig.product_fixed_product_tax_display_setting:FPT_DISABLEDINCLUDE_FPT_WITHOUT_DETAILSINCLUDE_FPT_WITH_DETAILSEXCLUDE_FPT_WITHOUT_DETAILSEXCLUDE_FPT_AND_INCLUDE_WITH_DETAILSPorted from the unfinished
feature/todo-list-paulbranch. The cart-item plugin was a stub on the branch (import typeonly) and has been completed in this PR, following theDownloadableCartItemActionCardpattern.Activation
PRIVATE_ADDITIONAL_DEPENDENCIES="@graphcommerce/magento-fixed-product-taxes"Wiring
hooks/useFixedProductTaxes.tsx— reads the display setting from store config and returns render flags.plugins/FixedProductTaxesProductPagePrice.tsx— wrapsProductPagePriceand renders the tax breakdown.plugins/FixedProductTaxesCartItem.tsx— wrapsCartItemActionCardand adds tax lines into thedetailsslot.fixed_product_taxestoCartItem+ProductPriceand the three*_fixed_product_tax_display_settingfields toStoreConfigFragment.Test plan
PRIVATE_ADDITIONAL_DEPENDENCIES,yarn codegenfromexamples/magento-graphcmsgenerates all 4.gql.tsfiles (one fragment + three injects).npx --package=@typescript/native-preview tsgo --noEmit -p .passes (no new errors).🤖 Generated with Claude Code