Skip to content

A few unused-but-set-variable errors in EDO #241

@strangewiz

Description

@strangewiz

diff --git a/Channel/Sources/EDOChannelUtil.m b/Channel/Sources/EDOChannelUtil.m
index 9894719..433a1c3 100644
--- a/Channel/Sources/EDOChannelUtil.m
+++ b/Channel/Sources/EDOChannelUtil.m
@@ -53,7 +53,7 @@ size_t EDOGetPayloadSizeFromFrameData(dispatch_data_t data) {

EDOSocketFrameHeader_t *frame = NULL;
dispatch_data_t contiguousData = dispatch_data_create_map(data, (const void **)&frame, NULL);

  • (void)contiguousData;
    if (!edo_isFrameHeaderValid(frame)) {
    return 0;
    }
    diff --git a/Service/Sources/EDOHostService.m b/Service/Sources/EDOHostService.m
    index 5f68abf..cc67f77 100644
    --- a/Service/Sources/EDOHostService.m
    +++ b/Service/Sources/EDOHostService.m
    @@ -336,6 +336,7 @@ static const char kEDOExecutingQueueKey = '\0';
  • (BOOL)removeObjectWithAddress:(EDOPointerType)remoteAddress {
    NSNumber *edoKey = [NSNumber numberWithLongLong:remoteAddress];
    __block NSObject *object NS_VALID_UNTIL_END_OF_SCOPE;
  • (void)object;
    dispatch_sync(_localObjectsSyncQueue, ^{
    // Transfer the ownership of local object to the outer queue, where the object should be
    // released.

To silence:
edo/Service/Sources/EDOHostService.m:338:21: error: variable 'object' set but not used [-Werror,-Wunused-but-set-variable]
__block NSObject *object NS_VALID_UNTIL_END_OF_SCOPE;
^
and

edo/Channel/Sources/EDOChannelUtil.m:55:19: error: variable 'contiguousData' set but not used [-Werror,-Wunused-but-set-variable]
dispatch_data_t contiguousData = dispatch_data_create_map(data, (const void **)&frame, NULL);
^

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions