From 858a6149c124d6e03ab86f86703138b302f3305a Mon Sep 17 00:00:00 2001
From: Henry Mercer <henrymercer@github.com>
Date: Thu, 23 Apr 2026 16:47:15 +0100
Subject: [PATCH] Simplify `writeDiffRangeDataExtensionPack` interface

---
 lib/analyze-action.js | 15 +++------------
 src/analyze.ts        | 24 ++++++------------------
 2 files changed, 9 insertions(+), 30 deletions(-)

diff --git a/lib/analyze-action.js b/lib/analyze-action.js
index 8ecb3977bf..947d1f1f2c 100644
--- a/lib/analyze-action.js
+++ b/lib/analyze-action.js
@@ -110784,15 +110784,9 @@ async function setupDiffInformedQueryRun(logger) {
         diffRanges,
         checkoutPath
       );
-      if (packDir === void 0) {
-        logger.warning(
-          "Cannot create diff range extension pack for diff-informed queries; reverting to performing full analysis."
-        );
-      } else {
-        logger.info(
-          `Successfully created diff range extension pack at ${packDir}.`
-        );
-      }
+      logger.info(
+        `Successfully created diff range extension pack at ${packDir}.`
+      );
       return packDir;
     }
   );
@@ -110817,9 +110811,6 @@ extensions:
   return header + data;
 }
 function writeDiffRangeDataExtensionPack(logger, ranges, checkoutPath) {
-  if (ranges === void 0) {
-    return void 0;
-  }
   if (ranges.length === 0) {
     ranges = [{ path: "", startLine: 0, endLine: 0 }];
   }
diff --git a/src/analyze.ts b/src/analyze.ts
index 5ae7cdc879..63830445d2 100644
--- a/src/analyze.ts
+++ b/src/analyze.ts
@@ -251,16 +251,9 @@ export async function setupDiffInformedQueryRun(
         diffRanges,
         checkoutPath,
       );
-      if (packDir === undefined) {
-        logger.warning(
-          "Cannot create diff range extension pack for diff-informed queries; " +
-            "reverting to performing full analysis.",
-        );
-      } else {
-        logger.info(
-          `Successfully created diff range extension pack at ${packDir}.`,
-        );
-      }
+      logger.info(
+        `Successfully created diff range extension pack at ${packDir}.`,
+      );
       return packDir;
     },
   );
@@ -314,18 +307,13 @@ extensions:
  * @param ranges The file line ranges, as returned by
  * `getPullRequestEditedDiffRanges`.
  * @param checkoutPath The path at which the repository was checked out.
- * @returns The absolute path of the directory containing the extension pack, or
- * `undefined` if no extension pack was created.
+ * @returns The absolute path of the directory containing the extension pack.
  */
 function writeDiffRangeDataExtensionPack(
   logger: Logger,
-  ranges: DiffThunkRange[] | undefined,
+  ranges: DiffThunkRange[],
   checkoutPath: string,
-): string | undefined {
-  if (ranges === undefined) {
-    return undefined;
-  }
-
+): string {
   if (ranges.length === 0) {
     // An empty diff range means that there are no added or modified lines in
     // the pull request. But the `restrictAlertsTo` extensible predicate