From 7f70f29d93d318726e8a8d34e36bb59c493b292d Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Sat, 25 Apr 2026 01:14:22 +0000 Subject: [PATCH 1/2] test: rename SideEffect -> SideEffects in Concat, Delay, and Item tests 50+ test files already use the plural 'SideEffects' module name. Concat.Tests.fs, Delay.Tests.fs, and Item.Tests.fs were the only outliers still using the singular form 'SideEffect'. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- release-notes.txt | 1 + src/FSharp.Control.TaskSeq.Test/TaskSeq.Concat.Tests.fs | 2 +- src/FSharp.Control.TaskSeq.Test/TaskSeq.Delay.Tests.fs | 2 +- src/FSharp.Control.TaskSeq.Test/TaskSeq.Item.Tests.fs | 2 +- 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/release-notes.txt b/release-notes.txt index 72c765f9..e87f48b5 100644 --- a/release-notes.txt +++ b/release-notes.txt @@ -2,6 +2,7 @@ Release notes: Unreleased + - test: rename `SideEffect` module to `SideEffects` in TaskSeq.Concat.Tests.fs, TaskSeq.Delay.Tests.fs, and TaskSeq.Item.Tests.fs for consistency with the rest of the test suite (50+ files already use the plural form) - test: add SideEffects module and ImmTaskSeq variant tests to TaskSeq.ChunkBy.Tests.fs, improving coverage for chunkBy and chunkByAsync - fixes: `Async.bind` signature corrected from `(Async<'T> -> Async<'U>)` to `('T -> Async<'U>)` to match standard monadic bind semantics (same as `Task.bind`); the previous signature made the function effectively equivalent to direct application - refactor: simplify splitAt 'rest' taskSeq to use while!, removing redundant go2 mutable and manual MoveNextAsync pre-advance diff --git a/src/FSharp.Control.TaskSeq.Test/TaskSeq.Concat.Tests.fs b/src/FSharp.Control.TaskSeq.Test/TaskSeq.Concat.Tests.fs index 5dd8e34b..5ae04b99 100644 --- a/src/FSharp.Control.TaskSeq.Test/TaskSeq.Concat.Tests.fs +++ b/src/FSharp.Control.TaskSeq.Test/TaskSeq.Concat.Tests.fs @@ -181,7 +181,7 @@ module Immutable = |> consumeTaskSeq |> should throwAsyncExact typeof -module SideEffect = +module SideEffects = [] let ``TaskSeq-concat executes side effects of nested (taskseq)`` () = let mutable i = 0 diff --git a/src/FSharp.Control.TaskSeq.Test/TaskSeq.Delay.Tests.fs b/src/FSharp.Control.TaskSeq.Test/TaskSeq.Delay.Tests.fs index c437bebc..0f9e4587 100644 --- a/src/FSharp.Control.TaskSeq.Test/TaskSeq.Delay.Tests.fs +++ b/src/FSharp.Control.TaskSeq.Test/TaskSeq.Delay.Tests.fs @@ -30,7 +30,7 @@ module Immutable = |> TaskSeq.delay |> validateSequence -module SideEffect = +module SideEffects = [] let ``TaskSeq-delay executes side effects`` () = task { let mutable i = 0 diff --git a/src/FSharp.Control.TaskSeq.Test/TaskSeq.Item.Tests.fs b/src/FSharp.Control.TaskSeq.Test/TaskSeq.Item.Tests.fs index d2fb2708..376b7483 100644 --- a/src/FSharp.Control.TaskSeq.Test/TaskSeq.Item.Tests.fs +++ b/src/FSharp.Control.TaskSeq.Test/TaskSeq.Item.Tests.fs @@ -105,7 +105,7 @@ module Immutable = tail |> should equal (Some 10) } -module SideEffect = +module SideEffects = [)>] let ``TaskSeq-item prove it searches the whole sequence`` variant = task { let ts = Gen.getSeqWithSideEffect variant From fc99a3c5b172fea83eb54475ad24b2fe8f366bc5 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Sat, 25 Apr 2026 01:14:24 +0000 Subject: [PATCH 2/2] ci: trigger checks