From 9c78f96902f931383dda12e6f8fdeade2262a010 Mon Sep 17 00:00:00 2001
From: oidq <oidq@oidq.dev>
Date: Wed, 20 May 2026 18:42:10 +0200
Subject: [PATCH] fix: check for nil Out in Logger on Close()

* add Logger.Close(), which safely closes underlying Out
* should fix #846
---
 framework/log/log.go | 9 +++++++++
 maddy.go             | 4 ++--
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/framework/log/log.go b/framework/log/log.go
index 3ad291a6..263732a0 100644
--- a/framework/log/log.go
+++ b/framework/log/log.go
@@ -205,6 +205,15 @@ func (l *Logger) Write(s []byte) (int, error) {
 	return len(s), nil
 }
 
+// Close closes underlying output in Out.
+func (l *Logger) Close() error {
+	if l.Out == nil {
+		return nil
+	}
+
+	return l.Out.Close()
+}
+
 // DebugWriter returns a writer that will act like Logger.Write
 // but will use debug flag on messages. If Logger.Debug is false,
 // Write method of returned object will be no-op.
diff --git a/maddy.go b/maddy.go
index c3a560bc..4d7a8179 100644
--- a/maddy.go
+++ b/maddy.go
@@ -450,7 +450,7 @@ func moduleMain(configPath string) error {
 	c.DefaultLogger.Msg("server stopped")
 
 	if c.DefaultLogger.Out != nil {
-		if err := c.DefaultLogger.Out.Close(); err != nil {
+		if err := c.DefaultLogger.Close(); err != nil {
 			log.DefaultLogger.Error("failed to close output logger", err)
 		}
 	}
@@ -517,7 +517,7 @@ func moduleReload(oldContainer *container.C, configPath string, asyncStopWg *syn
 			oldContainer.DefaultLogger.Error("moduleStop failed", err)
 		}
 		oldContainer.DefaultLogger.Msg("old server stopped")
-		if err := oldContainer.DefaultLogger.Out.Close(); err != nil {
+		if err := oldContainer.DefaultLogger.Close(); err != nil {
 			newContainer.DefaultLogger.Error("failed to close old server log", err)
 		}