From bd4a20ada41e7e6c888564aeccc7efe3204a1373 Mon Sep 17 00:00:00 2001 From: AustinBenoit Date: Tue, 28 Apr 2026 11:33:21 -0400 Subject: [PATCH 1/2] Increase valid starting times for github report The github actions that run as a part of our nightly reports often start later than expected. We previously allowed for a 20 minute delay but now we can allow for a 59 minute delay. 59 minutes is the longest possible delay that should still not cause confusion when reporting the results. --- scripts/gha/report_build_status.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/gha/report_build_status.py b/scripts/gha/report_build_status.py index 3eeceeded3..3f63a59761 100644 --- a/scripts/gha/report_build_status.py +++ b/scripts/gha/report_build_status.py @@ -129,7 +129,7 @@ general_test_hour = 9 firestore_test_hour = 10 -test_time_minute_range = 20 +test_time_minute_range = 59 def rename_key(old_dict,old_name,new_name): """Rename a key in a dictionary, preserving the order.""" From a28aa3452002964f1d6243da01c7735e33629d8d Mon Sep 17 00:00:00 2001 From: AustinBenoit Date: Tue, 28 Apr 2026 12:14:49 -0400 Subject: [PATCH 2/2] Make the github action only care about the hour --- scripts/gha/report_build_status.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/scripts/gha/report_build_status.py b/scripts/gha/report_build_status.py index 3f63a59761..42586b35aa 100644 --- a/scripts/gha/report_build_status.py +++ b/scripts/gha/report_build_status.py @@ -129,7 +129,6 @@ general_test_hour = 9 firestore_test_hour = 10 -test_time_minute_range = 59 def rename_key(old_dict,old_name,new_name): """Rename a key in a dictionary, preserving the order.""" @@ -388,9 +387,9 @@ def main(argv): if run['day'] < start_date or run['day'] > end_date: continue run['duration'] = dateutil.parser.parse(run['updated_at'], ignoretz=True) - run['date'] compare_test_hour = firestore_test_hour if FLAGS.firestore else general_test_hour - # The general test should start at 9:00, and firestore at 10:00, but we give it a range - # because the tests can take a few minutes before starting. - if run['date'].hour == compare_test_hour and run['date'].minute <= test_time_minute_range: + # The scheduled time is at the top of the hour (e.g. 09:00 or 10:00). + # We allow for some delay in GitHub Actions starting the job, as long as it starts in the same hour. + if run['date'].hour == compare_test_hour: source_tests[day] = run all_days.add(day)