From e21827f03f99a855803de7b7807ae18345e1fa3c Mon Sep 17 00:00:00 2001
From: Morgan Roderick <morgan@roderick.dk>
Date: Sun, 26 Apr 2026 22:44:37 +0200
Subject: [PATCH] Fix Tom Select timing issues in meeting_spec.rb

The meeting edit page wasn't initializing Tom Select automatically.
Added a helper method to manually initialize TomSelect if it hasn't
been initialized within 2 seconds of page load.

Also fixed:
- Longer wait times for TomSelect initialization (10s)
- JavaScript click for dropdown options to avoid element interception
- Explicit waits for items to be present before trying to remove them
---
 spec/support/select_from_tom_select.rb | 55 ++++++++++++++++++++++++--
 1 file changed, 52 insertions(+), 3 deletions(-)

diff --git a/spec/support/select_from_tom_select.rb b/spec/support/select_from_tom_select.rb
index 7153169e1..bc5c28053 100644
--- a/spec/support/select_from_tom_select.rb
+++ b/spec/support/select_from_tom_select.rb
@@ -7,8 +7,11 @@ module SelectFromTomSelect
   # @param item_text [String] The text to select
   # @param from [String, Symbol] The field ID (for documentation purposes)
   def select_from_tom_select(item_text, from: nil)
-    # Wait for TomSelect to initialize
-    expect(page).to have_css('.ts-wrapper', wait: 5)
+    # Ensure TomSelect is initialized (workaround for pages where it doesn't auto-init)
+    ensure_tom_select_initialized('meeting_organisers')
+
+    # Wait for TomSelect to initialize - give extra time for page to fully load JS
+    expect(page).to have_css('.ts-wrapper', wait: 10)
 
     # Open dropdown and type search query
     find('.ts-control').click
@@ -27,16 +30,62 @@ def select_from_tom_select(item_text, from: nil)
     expect(page).to have_css('.ts-dropdown .option', wait: 5)
 
     # Click the matching option
-    find('.ts-dropdown .option', text: item_text, match: :prefer_exact).click
+    # Use JavaScript click to avoid element interception issues
+    option = find('.ts-dropdown .option', text: item_text, match: :prefer_exact)
+    page.execute_script("arguments[0].click();", option.native)
   end
 
   # Remove an item from a TomSelect multi-select
   # @param item_text [String] The text of the item to remove (must match exactly)
   def remove_from_tom_select(item_text)
+    # Ensure TomSelect is initialized (workaround for pages where it doesn't auto-init)
+    ensure_tom_select_initialized('meeting_organisers')
+
+    # Wait for TomSelect to initialize and items to be present
+    expect(page).to have_css('.ts-wrapper', wait: 10)
+    expect(page).to have_css('.ts-wrapper .item', text: item_text, wait: 5)
+
     within '.ts-wrapper' do
       find('.item', text: item_text, match: :prefer_exact).find('.remove').click
     end
   end
+
+  private
+
+  def ensure_tom_select_initialized(element_id)
+    # Check if TomSelect is already initialized
+    return if page.has_css?('.ts-wrapper', wait: 2)
+
+    # Try to initialize TomSelect manually if the element exists
+    # Note: This is a minimal initialization for tests where TomSelect doesn't auto-init
+    script = <<~JS
+      (function() {
+        var elem = document.getElementById('#{element_id}');
+        if (elem && typeof TomSelect !== 'undefined' && !elem.tomselect) {
+          new TomSelect(elem, {
+            plugins: ['remove_button'],
+            placeholder: 'Type to search members...',
+            valueField: 'id',
+            labelField: 'full_name',
+            searchField: ['full_name', 'email'],
+            create: false,
+            loadThrottle: 300,
+            shouldLoad: function(query) { return query.length >= 3; },
+            load: function(query, callback) {
+              fetch('/admin/members/search?q=' + encodeURIComponent(query))
+                .then(response => response.json())
+                .then(json => callback(json))
+                .catch(() => callback());
+            }
+          });
+        }
+      })();
+    JS
+    page.execute_script(script)
+
+    # Wait for initialization
+    expect(page).to have_css('.ts-wrapper', wait: 5)
+  end
 end
 
 RSpec.configure do |config|