Non-static method PEAR::isError()

[BesedinSasha]

in Protocol.php in line 73
PEAR::isError() is not a static method

PEAR Version: 1.9.4
PHP Version: 5.3.16
OS Windows 7

I fixed this by creating an object:

$pear = new PEAR;
if ($pear->isError($hdr = Net_EPP_Protocol::_fread_nb($socket,4))) {
return $hdr;
}

[nkukard]

Hrmmm. I don't think thats the right solution, the PEAR class should be available.
ref: https://pear.php.net/manual/en/core.pear.pear.iserror.php

Is there a way you can reproduce this?

[BesedinSasha]

Here is a part of my PEAR.php

/**
     * Tell whether a value is a PEAR error.
     *
     * @param   mixed $data   the value to test
     * @param   int   $code   if $data is an error object, return true
     *                        only if $code is a string and
     *                        $obj->getMessage() == $code or
     *                        $code is an integer and $obj->getCode() == $code
     * @access  public
     * @return  bool    true if parameter is an error
     */
    function isError($data, $code = null)
    {
        if (!is_a($data, 'PEAR_Error')) {
            return false;
        }

        if (is_null($code)) {
            return true;
        } elseif (is_string($code)) {
            return $data->getMessage() == $code;
        }

        return $data->getCode() == $code;
    }

so I created an object to use PEAR method isError.

[nkukard]

It should certainly not prevent execution, the object shouldn't need to be instiantiated to use the method.

Urmmm, is this your problem maybe?
http://stackoverflow.com/questions/4044996/php-pear-mail-help
http://stackoverflow.com/questions/12619350/php-pear-mail-message-error

Funny enough it seems PEAR is not really 100% PHP standards compliant :)

[BesedinSasha]

I think this issue should be published in PEAR

[nkukard]

Seems there is alot of bug reports open/closed for it, is_a() may be an option, I'll send a patch within 24hr :)

[gbxyz]

Perhaps it would be better to switch to using an exception model instead of the old pre-exceptions style of error handling. Or use ($result instanceof PEAR_Error).

[nkukard]

Yep, is_a() is similar to instanceof.

That or as you say switch to the exception model, what would you prefer?

[gbxyz]

I'm indifferent! Whichever requires fewest keystrokes I suppose :-)

[nkukard]

VERY odd ... I think around 70 people are running the WHMCS COZA EPP plugin I wrote, at least thats about half of which that are subscribed to the mailing list.

I think the exception route would be best, it may even totally negate the need for PEAR. The only problem I think its quite a number of lines of code to be changed and re-tested. Plus it would be around 1/3 increase in the number of lines currently handling error checking.

Not a bad thing ... would you mind if I tackle it the next time I do a massive feature hack? probably in the next month when we enable another one of our large client-facing sites?

I'll also put it on a backburner for my development team, should we get a free moment we'll quickly add it ... they maybe even get it done mon-tue this week.

[gbxyz]

Fixed in my repo, see e15db31