Fix generated reference card hydration#583
Draft
danielporterda wants to merge 1 commit into
Draft
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x2mdx-ref-card-titlemarkup.Root cause
The live crawl found
Minified React error #418on generated/reference pages. The sharedx2mdxcard macro emitted<a class="x2mdx-ref-card">around nested block content. That invalid anchor structure caused the server-rendered DOM and hydrated React tree to diverge.Validation
direnv exec /Users/danielporter/control/.worktrees/cf-docs-generated-hydration-fix python3 -m pytest tests/test_daml_json.py tests/test_openrpc.py tests/test_canton_protobuf_generator.py tests/test_asyncapi.py tests/test_json_api_openapi.py -qdirenv exec /Users/danielporter/control/.worktrees/cf-docs-generated-hydration-fix npx mintlify validatefromdocs-maingit diff --checkMinified React error #418URLs against local Mintlify previewhttp://localhost:3017:checked: 40,badCount: 0Notes
npm run generate:all-reference-docsis still blocked on currentmainby the existing docs navigation shape mismatch: the wrappers expectnavigation.dropdowns, whiledocs-main/docs.jsonnow usesnavigation.products. The checked-in generated output in this PR was kept targeted to the card markup change.