Skip to content

Fix Markdown/bulk export review follow-ups from PR #19 #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bigbruno wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Markdown/bulk export review follow-ups from PR #19 #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 36 additions & 12 deletions src/bigocrpdf/services/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ def load_settings(self) -> None:
self._load_date_settings()
self._load_text_extraction_settings()
self._load_odf_settings()
self._load_md_settings()
self._load_preprocessing_settings()
self._load_image_export_settings()
self._load_pdf_output_settings()
Expand Down Expand Up @@ -197,6 +198,10 @@ def _load_odf_settings(self) -> None:
self.odf_use_formatting = self._config.get("odf_export.use_formatting", True)
self.odf_open_after_export = self._config.get("odf_export.open_after_export", False)

def _load_md_settings(self) -> None:
self.md_include_front_matter = self._config.get("md_export.include_front_matter", False)
self.md_open_after_export = self._config.get("md_export.open_after_export", False)

def _load_preprocessing_settings(self) -> None:
self.dpi = self._config.get("rapidocr.dpi", DEFAULT_DPI)
self.enable_preprocessing = self._config.get(
Expand Down Expand Up @@ -473,6 +478,7 @@ def _save_all_settings(self) -> None:
self._save_text_extraction_settings()
self._save_editor_settings()
self._save_odf_settings()
self._save_md_settings()
self._save_preprocessing_settings()
self._save_image_export_settings()
self._save_pdf_output_settings()
Expand Down Expand Up @@ -536,6 +542,18 @@ def _save_odf_settings(self) -> None:
"odf_export.open_after_export", self.odf_open_after_export, save_immediately=False
)

def _save_md_settings(self) -> None:
self._config.set(
"md_export.include_front_matter",
getattr(self, "md_include_front_matter", False),
save_immediately=False,
)
self._config.set(
"md_export.open_after_export",
getattr(self, "md_open_after_export", False),
save_immediately=False,
)

def _save_preprocessing_settings(self) -> None:
self._config.set("rapidocr.dpi", self.dpi, save_immediately=False)
self._config.set("rapidocr.language", self.ocr_language, save_immediately=False)
Expand Down Expand Up @@ -641,20 +659,26 @@ def get_pdf_suffix(self) -> str:

# Add date elements with their preferred order
if self.include_year:
date_components.append((
self.date_format_order.get("year", 1),
f"{now.tm_year}",
))
date_components.append(
(
self.date_format_order.get("year", 1),
f"{now.tm_year}",
)
)
if self.include_month:
date_components.append((
self.date_format_order.get("month", 2),
f"{now.tm_mon:02d}",
))
date_components.append(
(
self.date_format_order.get("month", 2),
f"{now.tm_mon:02d}",
)
)
if self.include_day:
date_components.append((
self.date_format_order.get("day", 3),
f"{now.tm_mday:02d}",
))
date_components.append(
(
self.date_format_order.get("day", 3),
f"{now.tm_mday:02d}",
)
)

# Sort components by their position value
date_components.sort(key=lambda x: x[0])
Expand Down
Loading