Complete Windows multiprocess WAL port#1
Closed
awakecoding wants to merge 3 commits into
Closed
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Owner
Author
|
Closing this fork-local draft in favor of the upstream draft PR opened at tursodatabase/turso. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This completes the Windows port for the multiprocess WAL work introduced by tursodatabase#6236.
It updates the Windows IOCP backend so default database opens preserve legacy lock-on-open behavior while
.tshmcoordination files continue to honorOpenFlags::NoLock. It also fixes the multiprocess worker harness to advance pager IO correctly onStepResult::IO, enables the Windows backend in the CLI defaults, splits cross-platform regression coverage into its own target, and expands Windows CI coverage for the shared-WAL path.Motivation and context
The shared WAL implementation was functionally available on Unix but incomplete on Windows. This change closes the Windows gap without regressing the
.tshmcoordination contract or non-Windows behavior.Validation completed before opening this PR:
turso_coremultiprocess tests,turso_whopperregression_tests, CLI exact regression coverage, and multiprocess startup smoke.cargo checkcoverage forturso_core,turso_whopper, andturso_cli, plusregression_tests_cross_platformand the restart regression that reuses persisted.tshmstate.Description of AI Usage
GitHub Copilot was used to review the branch scope, implement the Windows-specific runtime and test changes, and drive validation across Windows and WSL/Linux. The resulting code paths and test results were then verified in-repo with targeted cargo test and cargo check runs before opening this draft PR.