THRIFT-6025: Harden Ruby protocol negative sizes#3522
Open
kpumuk wants to merge 1 commit into
Open
Conversation
Client: rb Co-Authored-By: OpenAI Codex (GPT-5.4) <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby was not consistently rejecting negative sizes while reading Thrift payloads.
Size values appear in binary/string fields and in map/list/set headers. Those values must be non-negative. Before this change, malformed input could declare a negative size and reach Ruby or native C code paths that assumed the size was valid.
This was a protocol hardening gap compared with other runtimes.
Solution
This change rejects negative sizes in the Ruby library read paths.
It adds validation for:
BaseProtocol#skipcontainer handlingBaseTransport#read_allMemoryBufferTransport#read_allThe native memory buffer path also gets a direct
read_allimplementation so the added guard does not force hot binary reads through the slower generic transport path.The public protocol interface stays unchanged.
Performance
Pure Ruby benchmark, helper-call baseline vs inline guard:
Native-enabled sanity run:
[skip ci]anywhere in the commit message to free up build resources.