Add Asset Manager V2 file picker asset controls with role validation - PR_26126_084-asset-manager-v2-file-picker-assets

Author: DavidQ

docs/dev/reports/PR_26126_083_asset_manager_v2_manual_validation_notes.md

@@ -0,0 +1,28 @@
+# PR_26126_083 Asset Manager V2 Manual Validation Notes
+
+Date: 2026-05-06
+
+## Validation Performed
+
+- Ran `npm run test:workspace-v2`.
+- Ran a local Playwright/Chromium computed-style comparison between `tools/templates-v2/index.html` and `tools/asset-manager-v2/index.html`.
+- Searched runtime/test/script targets for the removed `tools/schemas/tool.manifest.schema.json` dependency.
+- Checked changed files to confirm sample JSON was not modified.
+
+## Results
+
+- `npm run test:workspace-v2`: passed, 10 tests.
+- Asset Manager V2 tool mode: passed through the workspace-v2 Playwright test. It loaded the tool menu, hid workspace actions, loaded `asset-browser.schema.json`, added an approved image asset, rejected unsupported `svg` payloads, and cleared status without page errors.
+- Asset Manager V2 workspace mode: passed through the workspace-v2 Playwright test. Workspace V2 launched Asset Manager V2 with `launch=workspace`, hid tool actions, showed workspace actions, inserted an approved audio asset into `tools.asset-browser.assets`, and did not create `asset-manager-v2` or `workspace-v2` tool payloads in the workspace manifest.
+- Theme parity: passed. Asset Manager V2 body, app shell, panels, accordions, inputs, menu, status clear button, and local shell frame matched Templates V2 computed theme values.
+- Schema relocation: passed. The test-only manifest schema now lives at `tests/schemas/tool.manifest.schema.json`, and the boundary test reference points to that path.
+- Runtime schema dependency check: passed. No `tests`, `tools`, or `scripts` references to `tools/schemas/tool.manifest.schema.json` remain.
+- Asset Browser logic reuse check: passed. Asset Manager V2 continues to use the asset-browser schema/workspace payload key only; no legacy `tools/Asset Browser` implementation is imported or reused.
+- Sample JSON check: passed. No sample JSON files were modified.
+
+## Reports
+
+- `docs/dev/reports/playwright_v8_coverage_report.txt`
+- `docs/dev/reports/coverage_changed_js_guardrail.txt`
+- `docs/dev/reports/PR_26126_083_asset_manager_v2_theme_comparison_notes.md`
+- `docs/dev/reports/PR_26126_083_asset_manager_v2_manual_validation_notes.md`

docs/dev/reports/PR_26126_083_asset_manager_v2_theme_comparison_notes.md

@@ -0,0 +1,41 @@
+# PR_26126_083 Asset Manager V2 Theme Comparison Notes
+
+Date: 2026-05-06
+
+## Scope
+
+Compared `tools/asset-manager-v2/index.html` rendered styling against `tools/templates-v2/index.html` after aligning `tools/asset-manager-v2/styles/assetManager.css` with the Templates V2 theme variables and shell structure.
+
+## Method
+
+Used a local Playwright/Chromium pass against the repo test server at 1440x900. The check collected computed styles for these paired elements:
+
+- `body`
+- app shell
+- left, center, and right panels
+- first accordion panel
+- representative text input
+- status clear button
+- tool action menu
+- local shell frame
+
+Compared rendered `backgroundImage`, `backgroundColor`, `color`, `borderRadius`, `borderColor`, `boxShadow`, `padding`, `gridTemplateColumns`, `overflow`, and `display`.
+
+## Result
+
+All compared values matched between Asset Manager V2 and Templates V2 for the body and panel theme surfaces.
+
+Confirmed matching rendered values included:
+
+- Body gradient: Templates V2 purple theme gradient matched Asset Manager V2.
+- App shell: `20px` radius, matching border color, `0 20px 44px rgba(0, 0, 0, 0.26)` shadow, `340px minmax(0, 1fr) 360px` column structure.
+- Panels: matching `rgba(76, 29, 149, 0.88)` surface, `8px` radius, `14px` padding, `auto` overflow.
+- Accordions: matching `rgba(43, 16, 91, 0.9)` surface, `8px` radius, shared border color, and `0 14px 30px rgba(0, 0, 0, 0.12)` shadow.
+- Inputs: matching `10px` radius, `rgba(43, 16, 91, 0.9)` surface, and `rgb(247, 244, 255)` text.
+- Status clear button: matching `10px` radius and Templates V2 button padding.
+- Menu: matching panel surface, `8px` radius, `10px` padding, and flex layout.
+- Local shell frame: matching gradient, `18px` radius, and Templates V2 frame shadow.
+
+## Notes
+
+The Asset Manager V2 header markup already matched the Templates V2 first-class tool header structure, so the change kept the existing HTML structure and aligned the theme values through CSS.

docs/dev/reports/PR_26126_084_asset_manager_v2_manual_validation_notes.md

@@ -0,0 +1,32 @@
+# PR_26126_084 Asset Manager V2 Manual Validation Notes
+
+Date: 2026-05-06
+
+## Validation Performed
+
+- Ran `npm run test:workspace-v2`.
+- Confirmed Asset Manager V2 tool mode launch through the Playwright workspace-v2 suite.
+- Confirmed Asset Manager V2 Workspace V2 launch mode through the Playwright workspace-v2 suite.
+- Confirmed picker accept filters for image, audio, font, video, shader, data, and localization file inputs.
+- Confirmed selected-file schema validation, schema rejection, role validation, and Workspace V2 insertion through Playwright.
+- Searched Asset Manager V2 targets for legacy Asset Browser implementation reuse.
+- Checked that no sample or game JSON files were modified.
+
+## Results
+
+- `npm run test:workspace-v2`: passed, 10 tests.
+- Tool mode: passed. Asset Manager V2 shows the tool action nav, hides workspace action nav, loads `asset-browser.schema.json`, exposes all seven file picker controls, and validates selected files before Add Asset.
+- Accept filters: passed. Playwright asserted kind-specific accept filters on image, audio, font, video, shader, data, and localization picker inputs.
+- Selected file validation: passed. Image `nebula-backdrop.png` selected with the `background` role derived `image.assets.nebula-backdrop.background`, `assets/images/nebula-backdrop.png`, validated against the schema, and added successfully.
+- Picker rejection: passed. `notes.txt` selected through the image picker was rejected and Add Asset stayed disabled.
+- Role validation: passed. A JSON payload with an audio asset using the image-only `background` role was rejected.
+- Workspace mode: passed. Workspace V2 launched Asset Manager V2 with `launch=workspace`, inserted the selected audio asset into `tools.asset-browser.assets`, and did not create `asset-manager-v2` or `workspace-v2` manifest entries.
+- Asset Browser reuse check: passed. No legacy Asset Browser implementation imports or app references were added.
+- Sample JSON check: passed. No sample or game JSON files were modified.
+
+## Reports
+
+- `docs/dev/reports/playwright_v8_coverage_report.txt`
+- `docs/dev/reports/coverage_changed_js_guardrail.txt`
+- `docs/dev/reports/PR_26126_084_asset_manager_v2_schema_validation_notes.md`
+- `docs/dev/reports/PR_26126_084_asset_manager_v2_manual_validation_notes.md`

docs/dev/reports/PR_26126_084_asset_manager_v2_schema_validation_notes.md

@@ -0,0 +1,36 @@
+# PR_26126_084 Asset Manager V2 Schema Validation Notes
+
+Date: 2026-05-06
+
+## Schema Changes
+
+- Expanded `tools/schemas/tools/asset-browser.schema.json` asset id patterns and `kind` enum to include `image`, `audio`, `font`, `video`, `shader`, `data`, and `localization`.
+- Added optional `role` to asset entries.
+- Added schema-owned `assetRolesByKind` rules consumed by Asset Manager V2 validation:
+  - image: `sprite`, `background`, `bezel`, `ui`
+  - audio: `sound`, `music`
+  - font: `ui`, `display`
+  - video: `cutscene`, `loop`
+  - shader: `fragment`, `vertex`, `compute`
+  - data: `config`, `table`
+  - localization: `strings`, `dialogue`
+
+## Runtime Validation
+
+- Asset Manager V2 loads allowed kinds, roles, and role-by-kind rules from `asset-browser.schema.json`.
+- File selection derives a path and asset id, then validates the selected file entry through `AssetSchemaValidator.validateFileSelection()`.
+- The selected file entry is also validated as an `assets` payload before the Add Asset button can persist it.
+- Invalid picker selections are blocked before insertion. Example covered by Playwright: `notes.txt` selected through the image picker is rejected by accept validation.
+- Invalid role combinations are rejected by schema-backed validation. Example covered by Playwright: `role: "background"` on an audio asset is rejected.
+- Image `bezel` role requires an `image.*.bezel` asset id.
+- `stretchOverride` remains allowed only on `image.*.bezel` assets.
+
+## Workspace Location
+
+Validated assets are inserted only into the Workspace V2 asset schema location:
+
+```text
+workspaceManifest.tools["asset-browser"].assets
+```
+
+No `asset-manager-v2` or `workspace-v2` tool payload is written into the Workspace V2 manifest.

docs/dev/reports/coverage_changed_js_guardrail.txt

@@ -7,17 +7,18 @@ Source: Playwright/Chromium built-in V8 coverage from npm run test:workspace-v2.
 
 Changed runtime JS files considered:
 (50%) tools/toolRegistry.js - executed lines 448/448; executed functions 4/8
-(59%) tools/asset-manager-v2/js/AssetManagerV2App.js - executed lines 273/273; executed functions 19/32
+(62%) tools/asset-manager-v2/js/AssetManagerV2App.js - executed lines 301/301; executed functions 21/34
 (67%) tools/asset-manager-v2/js/controls/AssetManagerShellControl.js - executed lines 100/100; executed functions 8/12
 (80%) tools/asset-manager-v2/js/controls/AccordionSection.js - executed lines 27/27; executed functions 4/5
-(86%) tools/asset-manager-v2/js/controls/AssetCatalogControl.js - executed lines 50/50; executed functions 6/7
+(86%) tools/asset-manager-v2/js/controls/AssetCatalogControl.js - executed lines 51/51; executed functions 6/7
+(92%) tools/asset-manager-v2/js/assetManagerMetadata.js - executed lines 106/106; executed functions 12/13
 (93%) tools/workspace-v2/index.js - executed lines 104/104; executed functions 14/15
-(100%) tools/asset-manager-v2/js/bootstrap.js - executed lines 59/59; executed functions 4/4
+(100%) tools/asset-manager-v2/js/bootstrap.js - executed lines 62/62; executed functions 4/4
 (100%) tools/asset-manager-v2/js/controls/ActionNavControl.js - executed lines 52/52; executed functions 6/6
-(100%) tools/asset-manager-v2/js/controls/AssetFormControl.js - executed lines 60/60; executed functions 14/14
+(100%) tools/asset-manager-v2/js/controls/AssetFormControl.js - executed lines 150/150; executed functions 26/26
 (100%) tools/asset-manager-v2/js/controls/InspectorControl.js - executed lines 8/8; executed functions 3/3
 (100%) tools/asset-manager-v2/js/controls/StatusLogControl.js - executed lines 30/30; executed functions 9/9
-(100%) tools/asset-manager-v2/js/services/AssetSchemaValidator.js - executed lines 145/145; executed functions 17/17
+(100%) tools/asset-manager-v2/js/services/AssetSchemaValidator.js - executed lines 186/186; executed functions 21/21
 (100%) tools/asset-manager-v2/js/services/WorkspaceBridge.js - executed lines 85/85; executed functions 10/10
 (100%) tools/renderToolsIndex.js - executed lines 166/166; executed functions 25/25
 

docs/dev/reports/playwright_v8_coverage_report.txt

@@ -13,25 +13,26 @@ Note: coverage entries are aggregated across every page/tool where coverageRepor
 
 Exercised tool entry points detected:
 (87%) Preview Generator V2 - exercised 19 runtime JS files
-(84%) Asset Manager V2 - exercised 11 runtime JS files
+(87%) Asset Manager V2 - exercised 12 runtime JS files
 (49%) Palette Manager - exercised 12 runtime JS files
 (84%) Tool Template V2 - exercised 10 runtime JS files
 (93%) Workspace V2 - exercised 1 runtime JS files
 (0%) Workspace Manager - not exercised by this Playwright run
 
 Changed runtime JS files covered:
 (50%) tools/toolRegistry.js - executed lines 448/448; executed functions 4/8
-(59%) tools/asset-manager-v2/js/AssetManagerV2App.js - executed lines 273/273; executed functions 19/32
+(62%) tools/asset-manager-v2/js/AssetManagerV2App.js - executed lines 301/301; executed functions 21/34
 (67%) tools/asset-manager-v2/js/controls/AssetManagerShellControl.js - executed lines 100/100; executed functions 8/12
 (80%) tools/asset-manager-v2/js/controls/AccordionSection.js - executed lines 27/27; executed functions 4/5
-(86%) tools/asset-manager-v2/js/controls/AssetCatalogControl.js - executed lines 50/50; executed functions 6/7
+(86%) tools/asset-manager-v2/js/controls/AssetCatalogControl.js - executed lines 51/51; executed functions 6/7
+(92%) tools/asset-manager-v2/js/assetManagerMetadata.js - executed lines 106/106; executed functions 12/13
 (93%) tools/workspace-v2/index.js - executed lines 104/104; executed functions 14/15
-(100%) tools/asset-manager-v2/js/bootstrap.js - executed lines 59/59; executed functions 4/4
+(100%) tools/asset-manager-v2/js/bootstrap.js - executed lines 62/62; executed functions 4/4
 (100%) tools/asset-manager-v2/js/controls/ActionNavControl.js - executed lines 52/52; executed functions 6/6
-(100%) tools/asset-manager-v2/js/controls/AssetFormControl.js - executed lines 60/60; executed functions 14/14
+(100%) tools/asset-manager-v2/js/controls/AssetFormControl.js - executed lines 150/150; executed functions 26/26
 (100%) tools/asset-manager-v2/js/controls/InspectorControl.js - executed lines 8/8; executed functions 3/3
 (100%) tools/asset-manager-v2/js/controls/StatusLogControl.js - executed lines 30/30; executed functions 9/9
-(100%) tools/asset-manager-v2/js/services/AssetSchemaValidator.js - executed lines 145/145; executed functions 17/17
+(100%) tools/asset-manager-v2/js/services/AssetSchemaValidator.js - executed lines 186/186; executed functions 21/21
 (100%) tools/asset-manager-v2/js/services/WorkspaceBridge.js - executed lines 85/85; executed functions 10/10
 (100%) tools/renderToolsIndex.js - executed lines 166/166; executed functions 25/25
 
@@ -120,9 +121,9 @@ Files with executed line/function counts where available:
 (56%) tools/palette-manager-v2/modules/paletteUtils.js - executed lines 41/41; executed functions 5/9
 (57%) src/engine/input/KeyboardState.js - executed lines 34/34; executed functions 4/7
 (57%) src/engine/runtime/FullscreenService.js - executed lines 118/118; executed functions 8/14
-(59%) tools/asset-manager-v2/js/AssetManagerV2App.js - executed lines 273/273; executed functions 19/32
 (60%) src/engine/persistence/StorageService.js - executed lines 49/49; executed functions 3/5
 (61%) src/engine/runtime/gameImageConvention.js - executed lines 207/207; executed functions 11/18
+(62%) tools/asset-manager-v2/js/AssetManagerV2App.js - executed lines 301/301; executed functions 21/34
 (65%) tools/palette-manager-v2/controls/SourcePaletteBrowserControl.js - executed lines 121/121; executed functions 15/23
 (67%) src/shared/number/numberUtils.js - executed lines 14/14; executed functions 2/3
 (67%) tools/asset-manager-v2/js/controls/AssetManagerShellControl.js - executed lines 100/100; executed functions 8/12
@@ -137,11 +138,12 @@ Files with executed line/function counts where available:
 (80%) src/engine/theme/accordionV2/accordionV2.js - executed lines 26/26; executed functions 4/5
 (80%) tools/asset-manager-v2/js/controls/AccordionSection.js - executed lines 27/27; executed functions 4/5
 (82%) samples/shared/sampleDetailPageEnhancement.js - executed lines 471/471; executed functions 41/50
-(86%) tools/asset-manager-v2/js/controls/AssetCatalogControl.js - executed lines 50/50; executed functions 6/7
+(86%) tools/asset-manager-v2/js/controls/AssetCatalogControl.js - executed lines 51/51; executed functions 6/7
 (86%) tools/templates-v2/js/controls/StatusLogControl.js - executed lines 24/24; executed functions 6/7
 (87%) tools/common/PaletteSortService.js - executed lines 103/103; executed functions 13/15
 (88%) tools/templates-v2/js/controls/SourceInputControl.js - executed lines 33/33; executed functions 7/8
 (90%) tools/preview-generator-v2/PreviewGeneratorV2App.js - executed lines 539/539; executed functions 52/58
+(92%) tools/asset-manager-v2/js/assetManagerMetadata.js - executed lines 106/106; executed functions 12/13
 (92%) tools/templates-v2/js/controls/ToolStarterShellControl.js - executed lines 111/111; executed functions 11/12
 (93%) tools/workspace-v2/index.js - executed lines 104/104; executed functions 14/15
 (100%) samples/phase-01/0102/KeyboardMoveScene.js - executed lines 78/78; executed functions 6/6
@@ -171,12 +173,12 @@ Files with executed line/function counts where available:
 (100%) src/shared/string/stringUtil.js - executed lines 1/1; executed functions 1/1
 (100%) src/shared/utils/invariantUtils.js - executed lines 11/11; executed functions 2/2
 (100%) src/shared/utils/stringUtils.js - executed lines 1/1; executed functions 1/1
-(100%) tools/asset-manager-v2/js/bootstrap.js - executed lines 59/59; executed functions 4/4
+(100%) tools/asset-manager-v2/js/bootstrap.js - executed lines 62/62; executed functions 4/4
 (100%) tools/asset-manager-v2/js/controls/ActionNavControl.js - executed lines 52/52; executed functions 6/6
-(100%) tools/asset-manager-v2/js/controls/AssetFormControl.js - executed lines 60/60; executed functions 14/14
+(100%) tools/asset-manager-v2/js/controls/AssetFormControl.js - executed lines 150/150; executed functions 26/26
 (100%) tools/asset-manager-v2/js/controls/InspectorControl.js - executed lines 8/8; executed functions 3/3
 (100%) tools/asset-manager-v2/js/controls/StatusLogControl.js - executed lines 30/30; executed functions 9/9
-(100%) tools/asset-manager-v2/js/services/AssetSchemaValidator.js - executed lines 145/145; executed functions 17/17
+(100%) tools/asset-manager-v2/js/services/AssetSchemaValidator.js - executed lines 186/186; executed functions 21/21
 (100%) tools/asset-manager-v2/js/services/WorkspaceBridge.js - executed lines 85/85; executed functions 10/10
 (100%) tools/preview-generator-v2/controls/AccordionSection.js - executed lines 31/31; executed functions 5/5
 (100%) tools/preview-generator-v2/controls/AssetFolderControl.js - executed lines 17/17; executed functions 5/5
@@ -208,13 +210,16 @@ Uncovered or low-coverage changed JS files:
 
 Changed JS files considered:
 (0%) scripts/validate-json-contracts.mjs - changed JS file not collected as browser runtime coverage
+(0%) scripts/write-codex-review-artifacts.mjs - changed JS file not collected as browser runtime coverage
 (0%) tests/helpers/playwrightV8CoverageReporter.mjs - changed JS file not collected as browser runtime coverage
 (0%) tests/playwright/PreviewGeneratorV2Baseline.spec.mjs - changed JS file not collected as browser runtime coverage
+(0%) tests/tools/ToolWorkspaceSchemaManifestBoundaries.test.mjs - changed JS file not collected as browser runtime coverage
 (50%) tools/toolRegistry.js - changed JS file with browser V8 coverage
-(59%) tools/asset-manager-v2/js/AssetManagerV2App.js - changed JS file with browser V8 coverage
+(62%) tools/asset-manager-v2/js/AssetManagerV2App.js - changed JS file with browser V8 coverage
 (67%) tools/asset-manager-v2/js/controls/AssetManagerShellControl.js - changed JS file with browser V8 coverage
 (80%) tools/asset-manager-v2/js/controls/AccordionSection.js - changed JS file with browser V8 coverage
 (86%) tools/asset-manager-v2/js/controls/AssetCatalogControl.js - changed JS file with browser V8 coverage
+(92%) tools/asset-manager-v2/js/assetManagerMetadata.js - changed JS file with browser V8 coverage
 (93%) tools/workspace-v2/index.js - changed JS file with browser V8 coverage
 (100%) tools/asset-manager-v2/js/bootstrap.js - changed JS file with browser V8 coverage
 (100%) tools/asset-manager-v2/js/controls/ActionNavControl.js - changed JS file with browser V8 coverage