Update Workspace loader to consume strict tools manifest payloads - PR 11.20

DavidQ · DavidQ · commit f8d467ff26b6 · 2026-04-28T23:21:36.000-04:00
diff --git a/docs/dev/codex_commands.md b/docs/dev/codex_commands.md
@@ -3,22 +3,18 @@
 model: gpt-5.3-codex
 reasoning: high
 
-Apply PR_11_19_SCHEMA_CLEANUP_TOOL_PAYLOADS_AND_PALETTE_CANONICALIZATION.
+Apply PR_11_20_WORKSPACE_LOADER_SCHEMA_V2_TOOLS_PAYLOAD_SUPPORT.
 
 Required:
-- Make `tools/schemas/tools/palette-browser.schema.json` the only canonical palette schema.
-- Move/merge correct palette schema content into `palette-browser.schema.json`.
-- Delete/remove all `tools/schemas/palette.schema*` files.
-- Ensure palette-browser schema is strict with `additionalProperties: false` everywhere.
-- Review `tools/schemas/sample.tool-payload.schema.json`; tools must validate only direct tool JSON schemas, not broad sample wrapper objects.
-- Remove/demote/narrow `sample.tool-payload.schema.json` so it cannot be used to validate arbitrary extra objects as tool payloads.
-- Rename tool schema `config` fields to a clearer field, preferably `payload`, consistently across schemas and sample 1902.
-- Replace generic use of `gameId` with a more generic identifier, preferably `projectId`; keep `gameId` only inside explicitly game-specific schemas.
-- Update Workspace manifest `$ref` targets to the canonical tool schemas.
-- Keep full strict mode: no `additionalProperties: true`, no omitted object `additionalProperties`.
-- Validate/rebuild only sample 1902 as needed.
-- Do not modify other samples.
+- Update Workspace loader/runtime to consume the corrected strict Workspace manifest shape where tool payloads live under `tools`.
+- Build available tool list from `Object.keys(manifest.tools)` filtered/validated against tool registry.
+- Ensure valid tools are not silently dropped.
+- Map singular `tools.palette` to the Palette Browser UI if that is the schema decision, but do not let it become the only visible tool.
+- Stop relying on old top-level `palettes`, `activeWorkspaceTools`, `games[].tools`, top-level `config`, top-level `payload`, or sample tool-payload wrappers for sample 1902.
+- Validate sample 1902 opens Workspace with all valid tools, not only Palette.
+- Do not loosen schemas.
 - Do not add fallback/default/hidden data.
+- Do not modify other samples.
 - Do not modify start_of_day folders.
-- Add validation report at docs/dev/reports/PR_11_19_SCHEMA_CLEANUP_TOOL_PAYLOADS_AND_PALETTE_CANONICALIZATION_report.md.
-- Return ZIP artifact at tmp/PR_11_19_SCHEMA_CLEANUP_TOOL_PAYLOADS_AND_PALETTE_CANONICALIZATION_delta.zip.
+- Add validation report at docs/dev/reports/PR_11_20_WORKSPACE_LOADER_SCHEMA_V2_TOOLS_PAYLOAD_SUPPORT_report.md.
+- Return ZIP artifact at tmp/PR_11_20_WORKSPACE_LOADER_SCHEMA_V2_TOOLS_PAYLOAD_SUPPORT_delta.zip.
diff --git a/docs/dev/commit_comment.txt b/docs/dev/commit_comment.txt
@@ -1 +1 @@
-Canonicalize palette schema and enforce direct strict tool payload schemas - PR 11.19
+Update Workspace loader to consume strict tools manifest payloads - PR 11.20
diff --git a/docs/dev/reports/PR_11_20_WORKSPACE_LOADER_SCHEMA_V2_TOOLS_PAYLOAD_SUPPORT_report.md b/docs/dev/reports/PR_11_20_WORKSPACE_LOADER_SCHEMA_V2_TOOLS_PAYLOAD_SUPPORT_report.md
@@ -0,0 +1,83 @@
+# PR 11.20 - Workspace Loader Schema V2 Tools Payload Support Report
+
+## PASS/FAIL
+PASS
+
+## Files Changed
+- tools/Workspace Manager/main.js
+- tools/shared/platformShell.js
+- docs/dev/reports/PR_11_20_WORKSPACE_LOADER_SCHEMA_V2_TOOLS_PAYLOAD_SUPPORT_report.md
+
+## Old Loader Assumptions Found
+- Workspace Manager previously derived available tools from registry/game filters, not strictly from `Object.keys(manifest.tools)` when a sample workspace manifest was provided.
+- Shared shell sample preset scoping previously matched `manifest.tools` keys by exact tool id only, so a singular `tools.palette` key would not resolve for `palette-browser` launches.
+
+## New Loader Path
+- Workspace Manager now reads `samplePresetPath` workspace manifest, classifies `manifest.tools` keys, validates each key against tool host registry IDs (with explicit singular palette mapping), validates payload `tool` id equality, and uses accepted tool IDs as the active tool list filter.
+- Shared shell scoped preset resolution now supports singular `tools.palette` mapped to `palette-browser` and rejects mismatched/malformed tool payload entries.
+
+## Sample 1902 Manifest Tool Key Evidence
+Source:
+- samples/phase-19/1902/sample.1902.workspace-all-tools.json
+
+Discovered tool keys:
+- vector-map-editor
+- vector-asset-studio
+- tile-map-editor
+- parallax-editor
+- sprite-editor
+- skin-editor
+- asset-browser
+- palette-browser
+- state-inspector
+- replay-visualizer
+- performance-profiler
+- physics-sandbox
+- asset-pipeline-tool
+- tile-model-converter
+- 3d-json-payload-normalizer
+- 3d-asset-viewer
+- 3d-camera-path-editor
+- palette
+
+Accepted tool ids:
+- vector-map-editor
+- vector-asset-studio
+- tile-map-editor
+- parallax-editor
+- sprite-editor
+- skin-editor
+- asset-browser
+- palette-browser
+- state-inspector
+- replay-visualizer
+- performance-profiler
+- physics-sandbox
+- asset-pipeline-tool
+- tile-model-converter
+- 3d-json-payload-normalizer
+- 3d-asset-viewer
+- 3d-camera-path-editor
+
+Rejected tool keys:
+- none
+
+Result:
+- Workspace manifest resolves to 17 accepted tool IDs, proving Workspace availability is not Palette-only.
+
+## Proof Workspace Shows More Than Palette
+- Accepted manifest tools for sample 1902 include 17 valid tool IDs (not only `palette-browser`).
+- Launch smoke includes PASS for `samples/phase-19/1902/index.html` and all listed active tools, including but not limited to Asset Browser, Sprite Editor, Tilemap Studio, Vector Asset Studio, Vector Map Editor, and Palette Browser.
+
+## Validation Commands and Results
+- `node --check "tools/Workspace Manager/main.js"` -> PASS
+- `node --check "tools/shared/platformShell.js"` -> PASS
+- `npm run test:launch-smoke -- --tools --samples --sample-range=1902-1902` -> PASS (suite executed; report summary `PASS=287 FAIL=0` includes sample `1902` PASS and all active tool entries PASS)
+- Manifest classification evidence command (Node inline script against sample 1902 + tool host manifest) -> PASS (`acceptedCount=17`, `rejected=[]`)
+
+## Scope Confirmation
+- No schema loosening was introduced.
+- No fallback/default/hidden data was added.
+- No standalone sample behavior paths were modified.
+- No files under `start_of_day` were changed.
+- No samples other than sample 1902 were touched by this PR implementation (code changes were limited to Workspace loader/shared shell paths).
diff --git a/docs/dev/reports/REPORT_PR_11_20.md b/docs/dev/reports/REPORT_PR_11_20.md
@@ -0,0 +1,10 @@
+# REPORT_PR_11_20_WORKSPACE_LOADER_SCHEMA_V2_TOOLS_PAYLOAD_SUPPORT
+
+## Summary
+This PR updates Workspace runtime loading to match the corrected strict Workspace manifest schema.
+
+## Target
+- Workspace reads `manifest.tools`.
+- Tool list is built from valid manifest tool keys.
+- Palette is singular but not exclusive.
+- Sample 1902 shows all valid tools.
diff --git a/docs/dev/reports/launch_smoke_report.md b/docs/dev/reports/launch_smoke_report.md
@@ -1,6 +1,6 @@
 # Launch Smoke Report
 
-Generated: 2026-04-29T02:49:57.040Z
+Generated: 2026-04-29T03:15:56.917Z
 
 Filters: games=true, samples=true, tools=true, sampleRange=all
 
diff --git a/docs/pr/PR_11_20_WORKSPACE_LOADER_SCHEMA_V2_TOOLS_PAYLOAD_SUPPORT/BUILD.md b/docs/pr/PR_11_20_WORKSPACE_LOADER_SCHEMA_V2_TOOLS_PAYLOAD_SUPPORT/BUILD.md
@@ -0,0 +1,83 @@
+# BUILD_PR_11_20_WORKSPACE_LOADER_SCHEMA_V2_TOOLS_PAYLOAD_SUPPORT
+
+## Required Codex Work
+
+### 1. Inspect current Workspace loader path
+Find where Workspace loads manifests and determines available tools.
+
+Expected areas:
+- tools/workspace*
+- tools/shared/platformShell*
+- tools/toolRegistry.js
+- any schema validation utilities
+- sample 1902 launch page only if required
+
+### 2. Update loader to new manifest contract
+Workspace must consume the corrected shape:
+
+```json
+{
+  "$schema": ".../workspace.manifest.schema.json",
+  "documentKind": "workspace-manifest",
+  "schema": "html-js-gaming.project",
+  "version": 1,
+  "id": "sample-1902-workspace-all-tools",
+  "name": "Sample 1902 Workspace All Tools",
+  "tools": {
+    "asset-browser": { "tool": "asset-browser", "version": "1", "payload": {} },
+    "sprite-editor": { "tool": "sprite-editor", "version": "1", "payload": {} },
+    "palette": { "tool": "palette-browser", "version": "1", "payload": {} }
+  }
+}
+```
+
+### 3. Build available tools from manifest.tools
+Available tools must come from:
+`Object.keys(manifest.tools)`
+
+Then:
+- validate key exists in Workspace-supported registry list
+- validate payload `tool` matches the registered tool id or the documented special-case mapping for singular palette
+- reject/report unknown keys
+- do not silently drop valid tools
+
+### 4. Palette mapping rule
+Resolve the naming ambiguity explicitly:
+- If schema uses `tools.palette` as the singular palette payload, map it to the Palette Browser tool UI.
+- Do not treat Palette as the only workspace tool.
+- Do not require a top-level `palettes` collection.
+- Do not require a separate `sample.1902.palette.json`.
+
+### 5. Remove old assumptions
+Remove or bypass old loader behavior that expects:
+- `palettes`
+- `games[].tools`
+- `activeWorkspaceTools`
+- top-level `config`
+- top-level `payload`
+- broad sample tool-payload schema wrappers
+
+unless still needed for legacy files and clearly documented as compatibility, not as the 1902 path.
+
+### 6. Validation report
+Create:
+docs/dev/reports/PR_11_20_WORKSPACE_LOADER_SCHEMA_V2_TOOLS_PAYLOAD_SUPPORT_report.md
+
+Report must include:
+- files changed
+- old loader assumption found
+- new loader path
+- all manifest tool keys discovered for sample 1902
+- tool keys accepted
+- tool keys rejected with reason
+- proof Workspace shows more than Palette
+- validation command/results
+- confirmation no other samples changed
+- confirmation no start_of_day changes
+
+## Constraints
+- One PR purpose only.
+- No schema loosening.
+- No fallback/default/hidden data.
+- No unrelated UI polish.
+- No edits to standalone sample behavior.
diff --git a/docs/pr/PR_11_20_WORKSPACE_LOADER_SCHEMA_V2_TOOLS_PAYLOAD_SUPPORT/PLAN.md b/docs/pr/PR_11_20_WORKSPACE_LOADER_SCHEMA_V2_TOOLS_PAYLOAD_SUPPORT/PLAN.md
@@ -0,0 +1,31 @@
+# PLAN_PR_11_20_WORKSPACE_LOADER_SCHEMA_V2_TOOLS_PAYLOAD_SUPPORT
+
+## Purpose
+Update the Workspace loader/runtime to consume the corrected strict Workspace manifest schema where all tool payloads live under `tools`.
+
+## Problem
+Sample 1902 now contains a schema-shaped `tools` object with many tool payloads, but Workspace still shows only Palette. This means the Workspace UI/loader is still using an older contract, likely reading:
+- top-level palettes
+- old config/payload branches
+- old sample tool-payload wrappers
+- a hardcoded Palette-only fallback
+- or filtering only one recognized tool
+
+## Scope
+- Workspace loader/runtime only.
+- Sample 1902 validation only.
+- Do not rebuild all tools.
+- Do not modify other samples.
+- Do not modify start_of_day folders.
+
+## Acceptance
+- Workspace reads `sample.1902.workspace-all-tools.json` using the new schema:
+  - top-level workspace metadata
+  - `tools` object
+  - one entry per supported tool id
+  - `tools.palette` / `tools.palette-browser` handled correctly per schema decision
+- Workspace tool list is built from `Object.keys(manifest.tools)` filtered through registry-supported ids.
+- Workspace no longer shows only Palette when valid tool payloads exist.
+- Unknown tool ids fail or are reported clearly.
+- Invalid tool payloads fail validation clearly.
+- Sample 1902 opens Workspace with all valid supported tools.
diff --git a/tools/Workspace Manager/main.js b/tools/Workspace Manager/main.js
diff --git a/tools/shared/platformShell.js b/tools/shared/platformShell.js

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-Canonicalize palette schema and enforce direct strict tool payload schemas - PR 11.19`
	`1`	`+Update Workspace loader to consume strict tools manifest payloads - PR 11.20`