Skip to content

Commit e46744e

Browse files
author
DavidQ
committed
BUILD_PR_LEVEL_17_52: replace Tab-based debug overlay cycling in touched phase-17 samples and lock bottom-right sample-specific overlay stack maps for 1708-1713 with runtime coverage
1 parent c4b7afa commit e46744e

20 files changed

Lines changed: 531 additions & 570 deletions

‎docs/dev/CODEX_COMMANDS.md‎

Lines changed: 25 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,26 @@
1-
MODEL: GPT-5.3-codex
1+
MODEL: GPT-5.4
22
REASONING: high
3-
COMMAND: Move debug overlay panels to bottom-right corner with vertical stacking and spacing, apply across shared debug system for samples 1701+, preserve existing behavior, and package to <project folder>/tmp/BUILD_PR_LEVEL_17_51_DEBUG_OVERLAY_POSITION_BOTTOM_RIGHT.zip
3+
4+
COMMAND:
5+
Implement BUILD_PR_LEVEL_17_52_DEBUG_OVERLAY_CYCLE_KEY_AND_SAMPLE_STACK_MAP as a small, testable PR.
6+
7+
Requirements:
8+
- Remove Tab as the overlay-cycle key in the touched phase-17 samples.
9+
- Introduce one consistent non-browser-reserved replacement key across the touched samples.
10+
- Keep all touched debug panels bottom-right anchored.
11+
- Enforce the exact sample-specific cycle maps:
12+
- 1708, 1710: UI Layer -> Mission Feed -> existing title ending in ADY -> Mini-Game Runtime
13+
- 1709, 1711: Movement Runtime -> Movement Lab HUD
14+
- 1712: UI Layer -> Mission Feed -> existing title ending in ADY -> Telemetry Overlay
15+
- 1713: UI Layer -> Mission Feed -> existing title ending in ADY -> Final Reference Runtime
16+
- Keep the ADY-ending title as-is unless already incorrect for another reason.
17+
- Update/add runtime tests so they verify the replacement key, reject Tab behavior, verify panel presence/order, and confirm bottom-right placement.
18+
19+
Constraints:
20+
- Smallest scoped valid change only.
21+
- Do not modify start_of_day folders.
22+
- Do not do repo-wide scanning.
23+
- Keep implementation one-pass executable.
24+
25+
Package the resulting repo-structured ZIP to:
26+
<project folder>/tmp/BUILD_PR_LEVEL_17_52_DEBUG_OVERLAY_CYCLE_KEY_AND_SAMPLE_STACK_MAP.zip

‎docs/dev/COMMIT_COMMENT.txt‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1 @@
1-
Reposition debug overlay panels to the bottom-right corner with vertical stacking to prevent interference with gameplay and HUD text.
2-
3-
PR: BUILD_PR_LEVEL_17_51_DEBUG_OVERLAY_POSITION_BOTTOM_RIGHT
1+
BUILD_PR_LEVEL_17_52: replace Tab-based debug overlay cycling in touched phase-17 samples and lock bottom-right sample-specific overlay stack maps for 1708-1713 with runtime coverage

‎docs/dev/PROJECT_INSTRUCTIONS.md‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,9 @@ ZIP STANDARD (ENFORCED)
8888
- Internal structure MUST be repo-relative only
8989
- No extra files outside defined structure
9090

91-
91+
Commit Comment:
92+
<change details>
93+
<PR Details>
9294
## 🔒 EXECUTION DEFAULTS (MANDATORY)
9395

9496
### ALWAYS CONTINUE

‎docs/dev/reports/change_summary.txt‎

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,13 @@
1-
Summary
2-
- converts the rendering-and-animation expansion into a compact four-sample demonstrator bundle
3-
- uses a couple of filled samples and a couple of image-skinned samples to make the documented concepts visible
4-
- reduces churn by avoiding a large diffuse sample explosion while still proving the capability set
1+
Change target:
2+
- Follow-up to the prior bottom-right overlay work.
3+
4+
Why this PR exists:
5+
- The current touched runtime still uses Tab in the overlay-cycle path.
6+
- Browser Tab behavior conflicts with deterministic in-sample cycling.
7+
- The user supplied exact sample-specific panel sets for 1708-1713.
8+
9+
What Codex should deliver:
10+
- One replacement overlay-cycle key across the touched samples.
11+
- Bottom-right stack retention.
12+
- Exact cycle maps per sample.
13+
- Runtime tests that prove both key behavior and panel order/placement.

‎docs/dev/reports/file_tree.txt‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
docs/
2+
pr/
3+
BUILD_PR_LEVEL_17_52_DEBUG_OVERLAY_CYCLE_KEY_AND_SAMPLE_STACK_MAP.md
24
dev/
35
codex_commands.md
46
commit_comment.txt
57
reports/
68
change_summary.txt
79
file_tree.txt
810
validation_checklist.txt
9-
pr/
10-
BUILD_PR_LEVEL_09_04_ASSET_STRUCTURE_SIMPLIFICATION.md

‎docs/dev/reports/validation_checklist.txt‎

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
1-
- [ ] Sample 1713 exists and launches from samples/index.html
2-
- [ ] player movement works
3-
- [ ] camera follow works
4-
- [ ] hazard/enemy/obstacle interaction works
5-
- [ ] score or objective loop works
6-
- [ ] restart/reset path works
7-
- [ ] no console errors
8-
- [ ] samples 1707-1712 remain intact
1+
[ ] Runtime tests pass.
2+
[ ] Tab no longer advances overlay cycling in touched phase-17 samples.
3+
[ ] Replacement key advances overlay cycling in touched phase-17 samples.
4+
[ ] Sample 1708 panel cycle set matches: UI Layer, Mission Feed, *ADY, Mini-Game Runtime.
5+
[ ] Sample 1710 panel cycle set matches: UI Layer, Mission Feed, *ADY, Mini-Game Runtime.
6+
[ ] Sample 1709 panel cycle set matches: Movement Runtime, Movement Lab HUD.
7+
[ ] Sample 1711 panel cycle set matches: Movement Runtime, Movement Lab HUD.
8+
[ ] Sample 1712 panel cycle set matches: UI Layer, Mission Feed, *ADY, Telemetry Overlay.
9+
[ ] Sample 1713 panel cycle set matches: UI Layer, Mission Feed, *ADY, Final Reference Runtime.
10+
[ ] Touched overlay titles render in the bottom-right stack region.

‎docs/pr/BUILD_PR_LEVEL_17_52_DEBUG_OVERLAY_CYCLE_KEY_AND_SAMPLE_STACK_MAP.md‎

Lines changed: 79 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
1+
# BUILD_PR_LEVEL_17_52_DEBUG_OVERLAY_CYCLE_KEY_AND_SAMPLE_STACK_MAP
2+
3+
## Purpose
4+
Replace the browser-conflicting debug overlay cycle key used in the phase-17 samples and lock the bottom-right overlay stack order to the exact sample-specific panel sets requested by the user.
5+
6+
## Scope
7+
Small, surgical runtime/input/debug-overlay update only.
8+
9+
In scope:
10+
- Remove `Tab` as the overlay cycle key anywhere this PR touches phase-17 debug overlay cycling.
11+
- Introduce one non-browser-reserved replacement key for the affected phase-17 samples and keep it consistent across the touched samples.
12+
- Keep debug panels anchored in the bottom-right corner.
13+
- Enforce the sample-specific bottom-right panel cycle/order listed below.
14+
- Update/add runtime tests to verify the new key path and the sample-specific bottom-right stack mapping.
15+
16+
Out of scope:
17+
- Any unrelated HUD redesign.
18+
- Any repo-wide input remap outside the touched samples.
19+
- Any changes to start_of_day folders.
20+
21+
## Required input change
22+
`Tab` must no longer be used for the overlay-cycle action in the affected phase-17 samples because the browser keeps consuming it.
23+
24+
Implement a single replacement key for this PR. Use a key that is not browser-reserved and is practical during gameplay/debugging. Keep the same replacement key across all touched samples and tests.
25+
26+
## Required layout rule
27+
All touched debug panels must remain anchored to the bottom-right corner and stack upward from there.
28+
29+
## Required sample map
30+
Apply the following bottom-right cycle map exactly.
31+
32+
### Samples 1708 and 1710
33+
Cycle through these panels in this set:
34+
1. `UI Layer`
35+
2. `Mission Feed`
36+
3. the existing panel whose title ends in `ADY`
37+
4. `Mini-Game Runtime`
38+
39+
### Samples 1709 and 1711
40+
Cycle through these panels in this set:
41+
1. `Movement Runtime`
42+
2. `Movement Lab HUD`
43+
44+
### Sample 1712
45+
Cycle through these panels in this set:
46+
1. `UI Layer`
47+
2. `Mission Feed`
48+
3. the existing panel whose title ends in `ADY`
49+
4. `Telemetry Overlay`
50+
51+
### Sample 1713
52+
Cycle through these panels in this set:
53+
1. `UI Layer`
54+
2. `Mission Feed`
55+
3. the existing panel whose title ends in `ADY`
56+
4. `Final Reference Runtime`
57+
58+
## Implementation notes for Codex
59+
- Reuse existing debug overlay composition where possible.
60+
- Do not rename the existing `...ADY` panel unless the current title is already wrong for another reason. The user only requires that the cycle include the current panel whose title ends in `ADY`.
61+
- Preserve bottom-right anchoring utilities if they already exist; extend them only as needed for deterministic stacking/order.
62+
- Keep the touched change set as small as possible.
63+
64+
## Files expected to change
65+
- `samples/phase-17/1708/RealGameplayMiniGameScene.js`
66+
- `samples/phase-17/1709/MovementModelsLabScene.js`
67+
- `samples/phase-17/1710/RealGameplayMiniGameScene.js`
68+
- `samples/phase-17/1711/MovementModelsLabScene.js`
69+
- `samples/phase-17/1712/GameplayMetricsTelemetryScene.js`
70+
- `samples/phase-17/1713/FinalReferenceGameScene.js`
71+
- `src/engine/debug/*` only if needed for shared bottom-right stack/cycle support
72+
- `tests/runtime/*` for deterministic key/cycle/layout coverage
73+
74+
## Required validation
75+
Codex must leave a runnable test that proves:
76+
- `Tab` is no longer the active cycle key in the touched samples.
77+
- The replacement key advances the overlay cycle.
78+
- Each sample exposes exactly the required panel set above.
79+
- The rendered panel titles still land in the bottom-right stack region.

0 commit comments

Comments
 (0)