Skip to content

Commit e39e49d

Browse files
author
DavidQ
committed
Make Text to Speech V2 status log fill its accordion content - PR_26130_032-text-to-speech-v2-status-log-fill
1 parent 8aa7588 commit e39e49d

1 file changed

Lines changed: 50 additions & 0 deletions

File tree

Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
1+
# PR_26130_032-text-to-speech-v2-status-log-fill
2+
3+
## Summary
4+
- Updated Text to Speech V2 CSS so `#text2speech-V2StatusLog` fills the available height of `#text2speech-V2StatusLogContent`.
5+
- Kept status log overflow internal to the textarea and prevented the status content container from leaving unused vertical space.
6+
- Preserved existing Status accordion controls and did not change schema, payload, or Workspace Manager contracts.
7+
- Added Playwright coverage for status log fill height, internal scrolling under many entries, and no page-level overflow regression.
8+
9+
## Scope Notes
10+
- Text to Speech V2 runtime change is CSS-only.
11+
- No JavaScript runtime files changed.
12+
- No schemas, payload defaults, samples, or workspace contracts changed.
13+
- No `start_of_day` files changed.
14+
15+
## Playwright Impacted
16+
Yes.
17+
18+
Validated behavior:
19+
- `#text2speech-V2StatusLog` fills `#text2speech-V2StatusLogContent`.
20+
- Many status entries scroll inside the status log textarea.
21+
- Adding many status entries does not create page-level overflow when the page otherwise fits.
22+
23+
Expected pass behavior:
24+
- Text to Speech V2 keeps the Status accordion controls working.
25+
- The status log uses the available panel height and scrolls internally.
26+
- `npm run test:workspace-v2` passes.
27+
28+
Expected fail behavior:
29+
- Leaving unused vertical space below the status log fails layout assertions.
30+
- Regressing internal status log scrolling fails the scroll assertions.
31+
- Letting status log content grow the page fails the page overflow assertion.
32+
33+
## Validation
34+
- PASS: `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list -g "shows safe empty Text to Speech V2 state"` -> 1 passed.
35+
- PASS: `npm run test:workspace-v2` -> 37 passed.
36+
- PASS: `git diff --check` -> no whitespace errors; CRLF conversion warnings only.
37+
38+
## Full Samples Smoke Test
39+
Skipped. This PR is limited to Text to Speech V2 status log CSS/layout and targeted Workspace V2 Playwright coverage is the required validation gate.
40+
41+
## Manual Validation
42+
1. Open Text to Speech V2.
43+
2. Confirm the Status log fills its accordion content area.
44+
3. Trigger enough status messages to exceed the visible log area and confirm only the log scrolls internally.
45+
4. Confirm the page itself does not gain a scrollbar solely because the Status log has many entries.
46+
47+
## Review Artifacts
48+
- `docs/dev/reports/codex_review.diff`
49+
- `docs/dev/reports/codex_changed_files.txt`
50+
- `tmp/PR_26130_032-text-to-speech-v2-status-log-fill_delta.zip`

0 commit comments

Comments
 (0)