Remove broken sample tool bindings and normalize canonical tool names - PR 11.105

Author: DavidQ

docs/dev/codex_commands.md

@@ -1,60 +1,59 @@
 # CODEX COMMANDS
 
 Model: GPT-5.3-codex
-Reasoning: low
+Reasoning: medium
 
 ## PR
-BUILD_PR_LEVEL_11_104_SCHEMA_FILENAME_CANONICALIZATION_AND_ARRAY_RULE_RESTORE
+BUILD_PR_LEVEL_11_105_REMOVE_BROKEN_SAMPLE_TOOL_BINDINGS
 
 ## Execute
 
-1. Rename schema files:
-   - tools/schemas/tools/3d-json-payload.schema.json -> tools/schemas/tools/3d-json-payload.schema.json
-   - tools/schemas/tools/asset-pipeline.schema.json -> tools/schemas/tools/asset-pipeline.schema.json
-
-2. Update every repo reference to the renamed schema files:
-   - `$ref`
-   - schema ids
-   - validation scripts
-   - docs
-   - tool/sample/game JSON
-
-3. Validate all JSON against strict schemas.
-
-4. Fix JSON/schema mismatches only:
-   - stale schema references
-   - stale tool ids
-   - invalid/unknown properties
-   - missing required fields
-   - wrong canonical names
-
-5. Restore the Project Instructions compact primitive-array formatting rule if it is missing or changed:
-   - simple primitive arrays must use compact grouped form:
-     [1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1]
-   - do not apply to arrays of objects, nested arrays, or complex structures
-
-6. Normalize repo JSON primitive arrays to match the rule.
-
-7. Confirm no old names remain:
-   - 3d-json-payload.schema.json
-   - asset-pipeline.schema.json
-   - palette
-   - palette-browser
-
-8. Write reports:
-   - docs/dev/reports/schema_filename_canonicalization_11_104.txt
-   - docs/dev/reports/json_schema_alignment_11_104.txt
-   - docs/dev/reports/array_formatting_rule_11_104.txt
-
-9. Roadmap:
-   - only update status markers if execution-backed
-   - do not rewrite roadmap text
-   - do not delete roadmap text
-
-## Constraints
-
-- Do not loosen schemas.
-- Do not add aliases.
-- Do not add fallback/default asset data.
-- Do not write implementation code unless required only to update validation/reference paths.
-- Do not run full samples smoke test unless validation proves shared sample loader/framework was changed.
+1. Treat this as runtime-alignment cleanup before schema lock.
+
+2. Apply canonical naming:
+   - Replace user-facing/reference-facing `3D JSON Payload Normalizer` with `3D JSON Payload`.
+   - Replace ids/refs `3d-json-payload-normalizer` with `3d-json-payload`.
+   - Replace `Asset Pipeline Tool` with `Asset Pipeline`.
+   - Replace ids/refs `asset-pipeline-tool` with `asset-pipeline`.
+   - Do not leave aliases or duplicate names.
+
+3. Remove broken sample/tool references unless a valid aligned input file exists and loads:
+   - 3D Camera Path Editor: remove references with no valid Path input.
+   - 3D JSON Payload: remove references with no valid payload input.
+   - Asset Browser / Import Hub: remove references where `active-project-manifest.tools.asset-browser.assets` is missing/empty/invalid.
+   - Asset Pipeline: remove references with no valid Pipeline Input.
+   - Parallax Scene Studio: remove affected references that render bars instead of valid parallax content.
+   - Performance Profiler: remove default-only references, including Sample 0512 if no real performance JSON exists.
+   - Physics Sandbox: remove default-only references, including Sample 0210 if no real physics JSON exists.
+   - Primitive Skin Editor: remove references from samples 0226 and 0227 unless real skin input plus schema/source metadata exists.
+   - Replay Visualizer: remove references with no valid replay input.
+   - State Inspector: remove references with no valid inspection snapshot JSON input.
+   - SVG Asset Studio: remove from samples 0901, 1204, 1208; keep 1215, 1216, 0127 only if they still load and validate.
+   - Vector Map Editor: remove from samples 0901, 1204, 1205 unless valid vector map input exists and loads.
+
+4. Do not create placeholder JSON to preserve a broken reference.
+5. Do not introduce silent fallback/default values.
+6. Do not loosen schemas.
+7. Do not modify unrelated files.
+8. Preserve compact primitive-array formatting rule and formatting.
+
+9. Validate:
+   - changed JSON parses
+   - changed manifests validate
+   - no old names remain:
+     - Normalizer
+     - Asset Pipeline Tool
+   - no sample lists a removed broken tool reference
+
+10. Write reports:
+   - docs/dev/reports/broken_sample_tool_bindings_11_105.txt
+   - docs/dev/reports/tool_reference_cleanup_11_105.txt
+   - docs/dev/reports/canonical_tool_names_11_105.txt
+
+11. Roadmap:
+   - status-only update if execution-backed.
+   - do not rewrite roadmap text.
+   - do not delete roadmap text.
+
+12. Package Codex output ZIP at:
+   tmp/PR_11_105_REMOVE_BROKEN_SAMPLE_TOOL_BINDINGS.zip

docs/dev/commit_comment.txt

@@ -1 +1 @@
-Canonicalize schema filenames and restore compact primitive array enforcement - PR 11.104
+Remove broken sample tool bindings and normalize canonical tool names - PR 11.105

docs/dev/reports/broken_sample_tool_bindings_11_105.txt

@@ -0,0 +1,71 @@
+BUILD_PR_LEVEL_11_105_REMOVE_BROKEN_SAMPLE_TOOL_BINDINGS
+Date: 2026-04-30
+
+Files changed:
+- samples/metadata/samples.index.metadata.json
+- sample/tool manifest and registry files updated for canonical ids.
+
+References removed (broken/no-input/default-only):
+- sample 0201: 3d-camera-path-editor removed=True
+- sample 0202: 3d-camera-path-editor removed=True
+- sample 0220: 3d-camera-path-editor removed=True
+- sample 0221: 3d-json-payload removed=True
+- sample 0305: 3d-json-payload removed=True
+- sample 0204: asset-browser removed=True
+- sample 1413: asset-browser removed=True
+- sample 1505: asset-browser removed=True
+- sample 0510: asset-pipeline removed=True
+- sample 1417: asset-pipeline removed=True
+- sample 0306: parallax-editor removed=True
+- sample 1204: parallax-editor removed=True
+- sample 1204: svg-asset-studio removed=True
+- sample 1204: vector-map-editor removed=True
+- sample 1205: parallax-editor removed=True
+- sample 1205: vector-map-editor removed=True
+- sample 0512: performance-profiler removed=True
+- sample 1319: performance-profiler removed=True
+- sample 1407: performance-profiler removed=True
+- sample 0210: physics-sandbox removed=True
+- sample 0303: physics-sandbox removed=True
+- sample 1606: physics-sandbox removed=True
+- sample 0708: replay-visualizer removed=True
+- sample 1315: replay-visualizer removed=True
+- sample 1406: replay-visualizer removed=True
+- sample 0205: state-inspector removed=True
+- sample 0208: state-inspector removed=True
+- sample 0217: state-inspector removed=True
+- sample 0901: svg-asset-studio removed=True
+- sample 0901: vector-map-editor removed=True
+- sample 1208: svg-asset-studio removed=True
+- sample 1217: svg-asset-studio removed=True
+
+References kept (validated input present):
+- sample 0226: skin-editor kept=True reason=valid sample-local skin JSON exists with schema/game metadata.
+- sample 0227: skin-editor kept=True reason=valid sample-local skin JSON exists with schema/game metadata.
+- sample 1215: svg-asset-studio kept=True reason=explicit svg-asset-studio preset JSON exists.
+- sample 1216: svg-asset-studio kept=True reason=explicit svg-asset-studio preset JSON exists.
+- sample 1212: vector-map-editor kept=True reason=explicit vector-map-editor preset JSON exists.
+- sample 1213: vector-map-editor kept=True reason=explicit vector-map-editor preset JSON exists.
+- sample 1214: vector-map-editor kept=True reason=explicit vector-map-editor preset JSON exists.
+- sample 1208: parallax-editor kept=True reason=explicit parallax-editor preset JSON exists.
+- sample 1218: parallax-editor kept=True reason=explicit parallax-editor preset JSON exists.
+- sample 1219: parallax-editor kept=True reason=explicit parallax-editor preset JSON exists.
+- sample 1220: parallax-editor kept=True reason=explicit parallax-editor preset JSON exists.
+- sample 1413: asset-pipeline kept=True reason=explicit asset pipeline preset JSON exists and resolves pipelinePayload.
+- sample 1902: asset-browser kept=True reason=workspace integration sample with embedded payloads per tool.
+- sample 1902: asset-pipeline kept=True reason=workspace integration sample with embedded payloads per tool.
+- sample 1902: 3d-json-payload kept=True reason=workspace integration sample with embedded payloads per tool.
+- sample 1902: 3d-camera-path-editor kept=True reason=workspace integration sample with embedded payloads per tool.
+- sample 1902: state-inspector kept=True reason=workspace integration sample with embedded payloads per tool.
+- sample 1902: replay-visualizer kept=True reason=workspace integration sample with embedded payloads per tool.
+- sample 1902: performance-profiler kept=True reason=workspace integration sample with embedded payloads per tool.
+- sample 1902: physics-sandbox kept=True reason=workspace integration sample with embedded payloads per tool.
+- sample 1902: parallax-editor kept=True reason=workspace integration sample with embedded payloads per tool.
+- sample 1902: vector-map-editor kept=True reason=workspace integration sample with embedded payloads per tool.
+- sample 1902: svg-asset-studio kept=True reason=workspace integration sample with embedded payloads per tool.
+- sample 1902: skin-editor kept=True reason=workspace integration sample with embedded payloads per tool.
+
+Validation:
+- JSON parse: changed_json_parse_ok=9 changed_json_parse_bad=0
+- Strict schemas: tool payload invalid=0, game manifest invalid=0, sample_json invalid=28 (pre-existing oneOf contract failures remain; no schema loosening applied).
+- Old names search exit=1 (expect 1 for no matches).

docs/dev/reports/canonical_tool_names_11_105.txt

@@ -0,0 +1,25 @@
+BUILD_PR_LEVEL_11_105_REMOVE_BROKEN_SAMPLE_TOOL_BINDINGS
+Date: 2026-04-30
+
+Canonical naming applied:
+- 3D JSON Payload Normalizer -> 3D JSON Payload
+- 3d-json-payload-normalizer -> 3d-json-payload
+- Asset Pipeline Tool -> Asset Pipeline
+- asset-pipeline-tool -> asset-pipeline
+
+Renamed paths:
+- tools/3D JSON Payload Normalizer -> tools/3D JSON Payload
+- tools/Asset Pipeline Tool -> tools/Asset Pipeline
+- samples/phase-14/1413/sample.1413.asset-pipeline-tool.json -> samples/phase-14/1413/sample.1413.asset-pipeline.json
+
+Schema alignment updates:
+- tools/schemas/workspace.manifest.schema.json keys now use asset-pipeline and 3d-json-payload.
+- tools/schemas/tools/asset-pipeline.schema.json const/tool id updated.
+- tools/schemas/tools/3d-json-payload.schema.json const/tool id updated.
+
+Validation checks:
+- rg old-name search exit code: 1 (1 means no matches found).
+- validate-tool-schemas exit code: 0
+- validate-json-contracts exit code: 0
+
+No aliases or duplicate canonical tool names were introduced for these two tools.

docs/dev/reports/sample_json_schema_validation.csv

@@ -60,8 +60,8 @@ samples/phase-12/1219/sample-1219-parallax-editor.json,tools/schemas/tools/paral
 samples/phase-12/1220/sample-1220-parallax-editor.json,tools/schemas/tools/parallax-editor.schema.json,invalid,1,$.payload.parallaxDocument: value must satisfy exactly one oneOf branch,
 samples/phase-14/1413/sample.1413.3d-asset-viewer.json,tools/schemas/tools/3d-asset-viewer.schema.json,invalid,1,$.payload.asset3d: value must satisfy exactly one oneOf branch,
 samples/phase-14/1413/sample.1413.asset-browser.json,tools/schemas/tools/asset-browser.schema.json,valid,0,,
-samples/phase-14/1413/sample.1413.asset-pipeline-tool.json,tools/schemas/tools/asset-pipeline-tool.schema.json,schema-missing,1,schema not found,
+samples/phase-14/1413/sample.1413.asset-pipeline.json,tools/schemas/tools/asset-pipeline.schema.json,invalid,1,$.payload.pipelinePayload: value must satisfy exactly one oneOf branch,
 samples/phase-14/1414/sample.1414.palette.json,,skipped,0,,no matching schema contract
 samples/phase-14/1414/sample.1414.sprite-editor.json,tools/schemas/tools/sprite-editor.schema.json,invalid,1,$.payload.spriteProject: value must satisfy exactly one oneOf branch,
 samples/phase-15/1505/sample.1505.asset-browser.json,tools/schemas/tools/asset-browser.schema.json,valid,0,,
-samples/phase-19/1902/sample.1902.workspace-all-tools.json,tools/schemas/workspace.manifest.schema.json,invalid,2,missing schema for tool asset-pipeline-tool: tools/schemas/tools/asset-pipeline-tool.schema.json | missing schema for tool 3d-json-payload-normalizer: tools/schemas/tools/3d-json-payload-normalizer.schema.json,
+samples/phase-19/1902/sample.1902.workspace-all-tools.json,tools/schemas/workspace.manifest.schema.json,valid,0,,

docs/dev/reports/schema_usage_code_updates.md

@@ -11,5 +11,5 @@
 - Sample JSON rows: 66
 - Game manifest rows: 12
 - Invalid tool rows: 0
-- Invalid sample rows: 29
+- Invalid sample rows: 28
 - Invalid game rows: 0

docs/dev/reports/tool_reference_cleanup_11_105.txt

@@ -0,0 +1,22 @@
+BUILD_PR_LEVEL_11_105_REMOVE_BROKEN_SAMPLE_TOOL_BINDINGS
+Date: 2026-04-30
+
+Cleanup summary:
+- Removed sample metadata toolHints/roundtripToolPresets for tools lacking aligned explicit input files.
+- Removed Asset Browser references from samples with empty assets maps (0204, 1413, 1505).
+- Removed default-only references for state-inspector, replay-visualizer, performance-profiler, and physics-sandbox sample entries listed in BUILD.
+- Removed SVG Asset Studio from 0901/1204/1208 and removed from 1217 to keep only validated set (1215/1216) per BUILD instruction.
+- Removed Vector Map Editor from 0901/1204/1205 and kept vector-map-editor where explicit map presets exist (1212-1214).
+
+Kept references and reasons:
+- skin-editor kept in 0226 and 0227 because sample-local skin JSON exists with documentKind/schema/game metadata.
+- parallax-editor kept where explicit parallaxDocument presets exist (1208, 1218, 1219, 1220).
+- asset-pipeline kept in 1413 because explicit sample.1413.asset-pipeline.json exists with pipelinePayload.
+- workspace sample 1902 kept as embedded multi-tool integration payload sample.
+
+Post-cleanup guard checks:
+- removed_binding_violations=0 for required removal matrix.
+- 1215_has_svg_asset_studio=true, 1216_has_svg_asset_studio=true, 1217_has_svg_asset_studio=false.
+
+No fallback/default data was added.
+No schema loosening was applied.

docs/dev/restart_notes_11_105.md

@@ -0,0 +1,16 @@
+# Restart Notes — PR 11.105
+
+Run this after PR 11.104 / PR 11.103 outputs are applied.
+
+Primary goal:
+- Do not lock schema yet.
+- First remove sample/tool references that do not load real aligned input.
+
+Key rule:
+- If the sample cannot be used in the tool, remove the tool reference.
+
+Expected outcome:
+- Tool lists become honest.
+- No default-only tool cards.
+- No placeholder/fallback data.
+- Canonical names are stable before schema lock.