Skip to content

Commit d78589f

Browse files
author
DavidQ
committed
BUILD PR: remove unused helper imports after shared extraction (advanced modules only).
1 parent 35891d7 commit d78589f

9 files changed

Lines changed: 60 additions & 30 deletions

docs/dev/CODEX_COMMANDS.md

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
MODEL: GPT-5.3-codex
22
REASONING: high
33
COMMAND:
4-
Execute docs/pr/BUILD_PR_SHARED_EXTRACTION_08_IS_PLAIN_OBJECT_ADVANCED_ONLY.md exactly.
5-
Edit only these files:
4+
Execute docs/pr/BUILD_PR_SHARED_EXTRACTION_09_CLEAN_UNUSED_HELPER_IMPORTS_ADVANCED_ONLY.md exactly.
5+
6+
Edit ONLY:
67
- src/advanced/promotion/createPromotionGate.js
78
- src/advanced/state/createWorldGameStateSystem.js
8-
- src/shared/utils/objectUtils.js (only if minimum export change is needed)
9-
Fail fast if src/shared/utils/objectUtils.js does not already exist and export or contain isPlainObject.
9+
1010
Do not expand scope.
11-
Package the delta output to <project folder>/tmp/BUILD_PR_SHARED_EXTRACTION_08_IS_PLAIN_OBJECT_ADVANCED_ONLY_delta.zip
11+
12+
Package to:
13+
<project folder>/tmp/BUILD_PR_SHARED_EXTRACTION_09_CLEAN_UNUSED_HELPER_IMPORTS_ADVANCED_ONLY_delta.zip

docs/dev/COMMIT_COMMENT.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
BUILD PR: remove remaining advanced-local isPlainObject duplicates and use shared object utils.
1+
BUILD PR: remove unused helper imports after shared extraction (advanced modules only).

docs/dev/NEXT_COMMAND.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Next: if clean, continue with the next executable BUILD. If blocked, capture the exact blocker and narrow further without changing PR purpose.
1+
Next: continue executable BUILD chain
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Built the next executable shared-extraction step for isPlainObject, constrained to the two advanced modules only and guarded by a fail-fast check on the existing shared object helper.
1+
Cleanup pass for unused imports after extraction steps.

docs/dev/reports/file_tree.txt

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1 @@
1-
docs/
2-
pr/
3-
BUILD_PR_SHARED_EXTRACTION_08_IS_PLAIN_OBJECT_ADVANCED_ONLY.md
4-
dev/
5-
codex_commands.md
6-
commit_comment.txt
7-
next_command.txt
8-
reports/
9-
change_summary.txt
10-
validation_checklist.txt
11-
file_tree.txt
1+
docs only
Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1 @@
1-
SESSION VALIDATION GATE
2-
- Bundle type: BUILD
3-
- One PR purpose only: yes
4-
- Exact target files listed: yes
5-
- Fail-fast dependency gate explicit: yes
6-
- No guessing/new helper creation: yes
7-
- Repo-wide scan/refactor language avoided: yes
8-
- Scope minimized: yes
9-
- ZIP repo-structured and execution-ready: yes
1+
Unused imports removed only.
Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
# BUILD_PR_SHARED_EXTRACTION_09_CLEAN_UNUSED_HELPER_IMPORTS_ADVANCED_ONLY
2+
3+
## Purpose
4+
Remove any UNUSED helper imports introduced during prior extraction steps.
5+
6+
## Single PR Purpose
7+
Cleanup ONLY unused imports in:
8+
9+
- src/advanced/promotion/createPromotionGate.js
10+
- src/advanced/state/createWorldGameStateSystem.js
11+
12+
## Exact Files Allowed
13+
Edit ONLY:
14+
1. src/advanced/promotion/createPromotionGate.js
15+
2. src/advanced/state/createWorldGameStateSystem.js
16+
17+
## Exact Rules
18+
- Identify imports for:
19+
- asFiniteNumber
20+
- asPositiveInteger
21+
- isPlainObject
22+
- createPromotionStateSnapshot
23+
24+
- If ANY of the above are imported but NOT used in the file:
25+
- remove that import
26+
27+
- If used:
28+
- keep import unchanged
29+
30+
## Hard Constraints
31+
- DO NOT modify logic
32+
- DO NOT reorder imports
33+
- DO NOT touch other imports
34+
- DO NOT scan repo
35+
- DO NOT modify shared files
36+
37+
## Validation Checklist
38+
1. Only 2 files changed
39+
2. No unused imports remain for the listed helpers
40+
3. No used imports were removed
41+
4. No logic changed
42+
43+
## Non-Goals
44+
- no formatting cleanup
45+
- no linting changes
46+
- no refactor

src/advanced/promotion/createPromotionGate.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ David Quesenberry
55
createPromotionGate.js
66
*/
77

8-
import { asFiniteNumber, asPositiveInteger } from '../../shared/utils/numberUtils.js';
8+
import { asPositiveInteger } from '../../shared/utils/numberUtils.js';
99
import { isPlainObject } from '../../shared/utils/objectUtils.js';
1010
import { createPromotionStateSnapshot } from '../shared/state/createPromotionStateSnapshot.js';
1111

src/advanced/state/createWorldGameStateSystem.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import {
1919
createTransitionRejectedEvent
2020
} from './events.js';
2121
import { createPromotionStateSnapshot } from '../../shared/state/createPromotionStateSnapshot.js';
22-
import { asFiniteNumber, asPositiveInteger } from '../../shared/utils/numberUtils.js';
22+
import { asPositiveInteger } from '../../shared/utils/numberUtils.js';
2323
import { isPlainObject } from '../../shared/utils/objectUtils.js';
2424
import {
2525
cloneDeep,

0 commit comments

Comments
 (0)