Skip to content

Commit c5dfafc

Browse files
author
DavidQ
committed
Clean up targeted non-palette sample JSON ownership batch - PR 11.46
1 parent 029998c commit c5dfafc

9 files changed

Lines changed: 334 additions & 36 deletions

‎docs/dev/codex_commands.md‎

Lines changed: 56 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1,46 +1,70 @@
11
MODEL: GPT-5.3-codex
2-
REASONING: medium
2+
REASONING: high
33

44
TASK:
5-
Apply PR 11.45.
5+
Apply PR 11.46.
66

7-
Add the PowerShell script:
8-
scripts/audit-sample-json-js-references.ps1
7+
Continue targeted sample JSON cleanup from PR 11.41, PR 11.43, and PR 11.44.
98

10-
Purpose:
11-
Recursively walk the samples directory looking for JSON files, then validate each JSON file is referenced by JS files in the same owning sample subtree.
9+
Use the current audit output from:
10+
docs/dev/reports/sample_json_js_reference_audit.csv
11+
and/or the console output from scripts/PS/audit-sample-json-js-references.ps1.
1212

13-
Owning sample root:
14-
samples/<group>/<sample>/
13+
Focus ONLY on a small high-confidence batch of non-palette, non-tile-map JSON payloads.
1514

16-
For each:
17-
samples/<group>/<sample>/**/*.json
15+
Preferred candidates:
16+
1. samples/phase-02/0221/sample.0221.3d-json-payload-normalizer.json
17+
2. samples/phase-05/0510/sample.0510.asset-pipeline-tool.json
18+
3. samples/phase-05/0512/sample.0512.performance-profiler.json
19+
4. samples/phase-07/0708/sample.0708.replay-visualizer.json
1820

19-
Scan:
20-
samples/<group>/<sample>/**/*.js
21-
samples/<group>/<sample>/**/*.mjs
22-
samples/<group>/<sample>/**/*.cjs
21+
For each selected JSON:
22+
- inspect the sample executable JS under the same sample subtree
23+
- inspect the related tool behavior if needed
24+
- decide:
25+
KEEP + WIRE
26+
MOVE / REHOME
27+
DELETE
28+
CREATE / UPDATE CORRECT SAMPLE
29+
DEFER
30+
- apply only safe, obvious changes
2331

24-
Check references by:
25-
- JSON filename
26-
- JSON basename
27-
- JSON path relative to sample root with slash styles
32+
Do NOT:
33+
- touch palette JSON files
34+
- touch tile-map-editor-document JSON files
35+
- touch sample 1902
36+
- force JSON into a mismatched sample
37+
- add hidden/default fallback data
38+
- run full samples smoke by default
39+
- undo SVG Asset Studio rename
40+
- rename tools
41+
- change unrelated logic
42+
- touch start_of_day folders
2843

29-
Output:
30-
docs/dev/reports/sample_json_js_reference_audit.csv
44+
Testing policy:
45+
Full samples smoke takes about 20 minutes.
46+
Skip it unless this PR changes shared sample launch infrastructure.
3147

32-
Do NOT:
33-
- run full sample smoke
34-
- modify samples
35-
- delete JSON
36-
- change runtime code
48+
Run targeted validation only:
49+
- syntax checks for changed JS files
50+
- the PowerShell audit script
51+
- targeted sample/tool tests for changed samples only, if available
3752

38-
Validation:
39-
Run:
40-
powershell -ExecutionPolicy Bypass -File scripts/audit-sample-json-js-references.ps1
53+
Reports:
54+
Write:
55+
docs/dev/reports/PR_11_46_cleanup_batch_3.md
56+
docs/dev/reports/PR_11_46_validation.txt
4157

42-
Document:
43-
docs/dev/reports/PR_11_45_validation.txt
58+
Cleanup report must include:
59+
- selected JSON files
60+
- classification/action for each
61+
- files changed
62+
- coverage preserved statement
63+
- deferred items and reasons
64+
- note that palette/tile-map/1902 were intentionally excluded
4465

45-
Full samples smoke:
46-
Skip. This is a utility script only.
66+
Validation report must include:
67+
- targeted tests run
68+
- full samples smoke skipped/run
69+
- reason for skip/run
70+
- result

‎docs/dev/commit_comment.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Add PowerShell audit for sample JSON references in sample JS - PR 11.45
1+
Resolve targeted non-palette sample JSON ownership cleanup batch - PR 11.46

‎docs/dev/reports/PR_11_46_cleanup_batch_3.md‎

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
# PR 11.46 Cleanup Batch 3
2+
3+
## Scope Source
4+
- `docs/dev/reports/sample_json_js_reference_audit.csv`
5+
- `scripts/PS/audit-sample-json-js-references.ps1`
6+
- Prior context: `docs/dev/reports/PR_11_41_sample_json_ownership_audit.md`, `docs/dev/reports/PR_11_43_cleanup_batch_1.md`, `docs/dev/reports/PR_11_43_validation.txt`, `docs/dev/reports/PR_11_44_cleanup_batch_2.md`
7+
8+
## Intentional Exclusions
9+
- Palette JSON: excluded by PR scope.
10+
- Tile-map-editor-document JSON: excluded by PR scope.
11+
- Sample 1902: excluded (workspace exemption).
12+
13+
## Selected JSON Files (High-Confidence Non-Palette / Non-Tile-Document Batch)
14+
1. `samples/phase-02/0221/sample.0221.3d-json-payload-normalizer.json`
15+
2. `samples/phase-05/0510/sample.0510.asset-pipeline-tool.json`
16+
3. `samples/phase-05/0512/sample.0512.performance-profiler.json`
17+
4. `samples/phase-07/0708/sample.0708.replay-visualizer.json`
18+
19+
## Classification / Action
20+
| JSON file | Classification | Action taken | Rationale |
21+
|---|---|---|---|
22+
| `samples/phase-02/0221/sample.0221.3d-json-payload-normalizer.json` | KEEP + WIRE | No code/data move. Verified explicit sample metadata wiring remains valid. | Sample metadata already includes `toolHints: 3d-json-payload-normalizer` and roundtrip preset path to this JSON; ownership is sample-local and tool-aligned. |
23+
| `samples/phase-05/0510/sample.0510.asset-pipeline-tool.json` | KEEP + WIRE | No code/data move. Verified explicit sample metadata wiring remains valid. | Sample metadata already maps `asset-pipeline-tool` to this JSON preset; payload shape matches tool schema intent. |
24+
| `samples/phase-05/0512/sample.0512.performance-profiler.json` | KEEP + WIRE | No code/data move. Verified explicit sample metadata wiring remains valid. | Sample metadata already maps `performance-profiler` to this JSON preset; sample-local ownership is clear. |
25+
| `samples/phase-07/0708/sample.0708.replay-visualizer.json` | KEEP + WIRE | No code/data move. Verified explicit sample metadata wiring remains valid. | Sample metadata already maps `replay-visualizer` to this JSON preset; sample-local ownership is clear. |
26+
27+
## Files Changed
28+
- `docs/dev/reports/PR_11_46_cleanup_batch_3.md`
29+
- `docs/dev/reports/PR_11_46_validation.txt`
30+
- `docs/dev/reports/sample_json_js_reference_audit.pr11_46.csv`
31+
32+
## Coverage Preserved Statement
33+
- Coverage preserved.
34+
- No selected JSON file was moved or deleted.
35+
- No sample-to-tool/use-case path was removed.
36+
- This batch confirms that selected non-palette, non-tile-document payloads are already correctly owned and wired in sample metadata-driven launch contracts.
37+
38+
## Deferred Items And Reasons
39+
- `samples/phase-02/0221/sample.0221.tile-model-converter.json` (not in this PR scope batch; batch intentionally kept to preferred non-palette/non-tile-document set).
40+
- Any palette JSON deferred items (explicitly excluded by this PR scope).
41+
- Any tile-map-editor-document deferred items (explicitly excluded by this PR scope).
42+
- Sample 1902 workspace JSON (explicitly exempt as workspace aggregation sample).

‎docs/dev/reports/PR_11_46_cleanup_batch_3_template.md‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
# PR 11.46 Cleanup Batch 3
2+
3+
## Batch Scope
4+
Non-palette, non-tile-map, non-1902 JSON payloads only.
5+
6+
## Selected Items
7+
8+
| JSON Path | Classification | Action Taken | Files Changed | Coverage Preserved? | Notes |
9+
|---|---|---|---|---|---|
10+
11+
## Exclusions
12+
- Palette JSON files intentionally excluded.
13+
- Tile-map document JSON files intentionally excluded.
14+
- Sample 1902 intentionally excluded.
15+
16+
## Deferred Items
17+
-
18+
19+
## Coverage Preserved Statement
20+
-

‎docs/dev/reports/PR_11_46_validation.txt‎

Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
PR 11.46 Validation
2+
3+
PASS/FAIL: PASS
4+
5+
Targeted validation run
6+
1) PowerShell audit script
7+
Command:
8+
- powershell -ExecutionPolicy Bypass -File scripts/PS/audit-sample-json-js-references.ps1
9+
Result:
10+
- FAIL due to write lock/permission denied on default output path:
11+
docs/dev/reports/sample_json_js_reference_audit.csv
12+
13+
2) PowerShell audit script (explicit output path override)
14+
Command:
15+
- powershell -ExecutionPolicy Bypass -File scripts/PS/audit-sample-json-js-references.ps1 -OutputPath docs/dev/reports/sample_json_js_reference_audit.pr11_46.csv
16+
Result:
17+
- PASS
18+
- JSON files scanned: 98
19+
- Referenced: 39
20+
- Missing reference: 59
21+
- Output written: docs/dev/reports/sample_json_js_reference_audit.pr11_46.csv
22+
23+
3) Targeted sample smoke checks (selected sample set only)
24+
Command:
25+
- node ./tests/runtime/LaunchSmokeAllEntries.test.mjs --samples --sample-range=0221-0221
26+
Result: PASS (PASS=1 FAIL=0 TOTAL=1)
27+
28+
Command:
29+
- node ./tests/runtime/LaunchSmokeAllEntries.test.mjs --samples --sample-range=0510-0510
30+
Result: PASS (PASS=1 FAIL=0 TOTAL=1)
31+
32+
Command:
33+
- node ./tests/runtime/LaunchSmokeAllEntries.test.mjs --samples --sample-range=0512-0512
34+
Result: PASS (PASS=1 FAIL=0 TOTAL=1)
35+
36+
Command:
37+
- node ./tests/runtime/LaunchSmokeAllEntries.test.mjs --samples --sample-range=0708-0708
38+
Result: PASS (PASS=1 FAIL=0 TOTAL=1)
39+
40+
Syntax checks
41+
- Changed JavaScript files: none
42+
- node --check on changed JS files: N/A
43+
44+
Full samples smoke
45+
- Skipped
46+
- Reason: PR 11.46 did not change shared sample launch infrastructure/framework; this batch is targeted classification/verification and reporting for selected sample-local JSON ownership.
47+
48+
Result
49+
- PASS. Selected batch completed with targeted validation and no broad-impact runtime changes.

‎docs/dev/reports/PR_11_46_validation_template.txt‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
# PR 11.46 Validation
2+
3+
## Changed Files
4+
-
5+
6+
## Targeted Tests Run
7+
-
8+
9+
## Full Samples Smoke
10+
Skipped / Run:
11+
12+
Reason:
13+
14+
## Audit Script Result
15+
-
16+
17+
## Result
18+
-

‎docs/dev/reports/launch_smoke_report.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
# Launch Smoke Report
22

3-
Generated: 2026-04-29T19:27:23.330Z
3+
Generated: 2026-04-29T19:43:36.074Z
44

5-
Filters: games=false, samples=true, tools=false, sampleRange=1208-1208
5+
Filters: games=false, samples=true, tools=false, sampleRange=0708-0708
66

77
| Status | Type | Label | Path | Notes | Steps |
88
| --- | --- | --- | --- | --- | --- |
9-
| PASS | sample | 1208 | samples\phase-12\1208\index.html | | npm install --prefix ./tmp ws → npm run test:launch-smoke |
9+
| PASS | sample | 0708 | samples\phase-07\0708\index.html | | npm install --prefix ./tmp ws → npm run test:launch-smoke |

0 commit comments

Comments
 (0)