Skip to content

Commit c4818e9

Browse files
author
DavidQ
committed
Lock sample JSON audit output and CI regression guard - PR 11.68
1 parent 82e9229 commit c4818e9

12 files changed

Lines changed: 209 additions & 6 deletions

docs/dev/codex_commands.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
# Codex Commands — PR 11.67
1+
# Codex Command — PR 11.68
22

33
Model: GPT-5.4
44
Reasoning: high
55

66
```powershell
7-
codex --model gpt-5.4 --reasoning high "Run BUILD_PR_LEVEL_11_67_FINAL_SAMPLE_JSON_AUDIT_CLOSURE. Use docs/dev/reports/sample_json_js_reference_audit.csv as source of truth. Close remaining missing sample JSON references by generating palette JSON from existing sample JS color data, wiring existing/generated JSON through the existing loader pattern, removing stale metadata-only references, and documenting exact unresolved blockers. Keep changes surgical. Do not run full samples suite. Produce a ZIP at tmp/PR_11_67_FINAL_SAMPLE_JSON_AUDIT_CLOSURE.zip."
7+
codex exec --model gpt-5.4 --reasoning high "Apply docs/pr/PR_11_68_SAMPLE_JSON_AUDIT_LOCKDOWN.md exactly. Update only the audit script and required report files. Make default output counts-only, keep -Details for full listing, add -Ci failure mode for missing references, preserve CSV generation, run the listed validation commands, and write docs/dev/reports/PR_11_68_sample_json_audit_lockdown_report.md. Do not run the full samples suite."
88
```

docs/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Close remaining sample JSON audit gaps with palette/reference stabilization - PR 11.67
1+
Lock sample JSON audit output and CI regression guard - PR 11.68
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
# PR 11.68 Bundle Manifest
2+
3+
Files included:
4+
- docs/pr/PR_11_68_SAMPLE_JSON_AUDIT_LOCKDOWN.md
5+
- docs/dev/codex_commands.md
6+
- docs/dev/commit_comment.txt
7+
- docs/dev/reports/PR_11_68_bundle_manifest.md
8+
9+
Full samples test: skipped in this bundle because Codex will only change audit script/report behavior.
Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,44 @@
1+
# PR 11.68 Sample JSON Audit Lockdown Report
2+
3+
## Scope
4+
- Updated `scripts/PS/audit-sample-json-js-references.ps1` only.
5+
- Added explicit CI failure mode switch.
6+
- Preserved CSV generation at `docs/dev/reports/sample_json_js_reference_audit.csv`.
7+
- No sample/tool/runtime code changes.
8+
9+
## Script Changes
10+
- Added parameter: `[switch]$Ci`
11+
- Kept existing `[switch]$Details`
12+
- Kept counts-only default output.
13+
- Kept detailed YES/NO listing behind `-Details`.
14+
- Added CI behavior:
15+
- `-Ci` exits `1` when missing references exist.
16+
- `-Ci` exits `0` when missing references are zero.
17+
- Preserved existing `-FailOnMissing` behavior for backward compatibility.
18+
19+
## Before Counts
20+
Baseline run before edits:
21+
- JSON files scanned: `66`
22+
- Referenced: `66`
23+
- Missing reference: `0`
24+
25+
## After Counts
26+
Post-change run:
27+
- JSON files scanned: `66`
28+
- Referenced: `66`
29+
- Missing reference: `0`
30+
31+
## Validation Commands Run
32+
- `./scripts/PS/audit-sample-json-js-references.ps1`
33+
- `./scripts/PS/audit-sample-json-js-references.ps1 -Details`
34+
- `./scripts/PS/audit-sample-json-js-references.ps1 -Ci`
35+
36+
## Validation Results
37+
- Default mode counts-only output: PASS
38+
- Details mode detailed listing present: PASS
39+
- CI mode exit code: `0` (PASS, because missing references are `0`)
40+
- CSV generation preserved: PASS (`docs/dev/reports/sample_json_js_reference_audit.csv` produced)
41+
- PowerShell parse check for script: PASS
42+
43+
## Full Samples Suite
44+
- Skipped by design. Reason: PR scope is audit script/report behavior only.
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
exit_code=0
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
2+
Sample JSON reference audit complete.
3+
JSON files scanned: 66
4+
Referenced: 66
5+
Missing reference: 0
6+
Report: docs/dev/reports/sample_json_js_reference_audit.csv
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
exit_code=0
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
2+
Sample JSON reference audit complete.
3+
JSON files scanned: 66
4+
Referenced: 66
5+
Missing reference: 0
6+
Report: docs/dev/reports/sample_json_js_reference_audit.csv
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
exit_code=0
Lines changed: 72 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,72 @@
1+
YES - samples\metadata\samples.index.metadata.json -> metadataReference.js
2+
YES - samples\phase-02\0204\sample.0204.3d-asset-viewer.json -> sample.0204.asset-browser.json
3+
YES - samples\phase-02\0204\sample.0204.asset-browser.json -> main.js
4+
YES - samples\phase-02\0207\sample.0207.palette.json -> main.js
5+
YES - samples\phase-02\0207\sample.0207.sprite-editor.json -> AnimationSystemScene.js
6+
YES - samples\phase-02\0213\sample.0213.palette.json -> main.js
7+
YES - samples\phase-02\0213\sample.0213.sprite-editor.json -> SpriteRenderLayerScene.js
8+
YES - samples\phase-02\0214\sample.0214.palette.json -> main.js
9+
YES - samples\phase-02\0214\sample.0214.sprite-editor.json -> AnimationSpriteBindingScene.js
10+
YES - samples\phase-02\0219\sample.0219.palette.json -> main.js
11+
YES - samples\phase-02\0219\sample.0219.sprite-editor.json -> SpriteAtlasImageRenderingScene.js
12+
YES - samples\phase-02\0221\sample-0221-tile-map-editor-document.json -> sample.0221.tile-model-converter.json
13+
YES - samples\phase-02\0221\sample.0221.palette.json -> main.js
14+
YES - samples\phase-02\0221\sample.0221.tile-map-editor.json -> TilemapSystemScene.js
15+
YES - samples\phase-02\0221\sample.0221.tile-model-converter.json -> main.js
16+
YES - samples\phase-02\0224\sample-0224-tile-map-editor-document.json -> main.js
17+
YES - samples\phase-02\0224\sample.0224.palette.json -> main.js
18+
YES - samples\phase-02\0224\sample.0224.sprite-editor.json -> TileCameraSpriteSliceScene.js
19+
YES - samples\phase-02\0224\sample.0224.tile-map-editor.json -> TileCameraSpriteSliceScene.js
20+
YES - samples\phase-02\0226\sample.0226.skin-editor.json -> PrimitiveSkinEditorBreakoutReadinessScene.js
21+
YES - samples\phase-02\0227\sample.0227.skin-editor.json -> PrimitiveSkinEditorPongReadinessScene.js
22+
YES - samples\phase-03\0301\sample.0301.palette.json -> main.js
23+
YES - samples\phase-03\0301\sample.0301.sprite-editor.json -> RealSpriteRenderingScene.js
24+
YES - samples\phase-03\0302\sample.0302.palette.json -> main.js
25+
YES - samples\phase-03\0302\sample.0302.sprite-editor.json -> AnimationSystemScene.js
26+
YES - samples\phase-03\0305\sample-0305-tile-map-editor-document.json -> sample.0305.tile-model-converter.json
27+
YES - samples\phase-03\0305\sample.0305.palette.json -> main.js
28+
YES - samples\phase-03\0305\sample.0305.tile-map-editor.json -> TileMetadataScene.js
29+
YES - samples\phase-03\0305\sample.0305.tile-model-converter.json -> main.js
30+
YES - samples\phase-03\0308\sample.0308.palette.json -> main.js
31+
YES - samples\phase-03\0313\sample.0313.palette.json -> main.js
32+
YES - samples\phase-09\0901\sample.0901.palette.json -> main.js
33+
YES - samples\phase-09\0905\sample.0905.palette.json -> main.js
34+
YES - samples\phase-09\0905\sample.0905.sprite-editor.json -> PixelPerfectCollisionScene.js
35+
YES - samples\phase-12\1204\sample.1204.palette.json -> main.js
36+
YES - samples\phase-12\1205\sample.1205.palette.json -> main.js
37+
YES - samples\phase-12\1208\sample.1208.palette.json -> main.js
38+
YES - samples\phase-12\1208\sample.1208.parallax-editor.json -> index.html
39+
YES - samples\phase-12\1208\sample.1208.svg-asset-studio.json -> index.html
40+
YES - samples\phase-12\1208\sample.1208.tile-map-editor.json -> index.html
41+
YES - samples\phase-12\1209\sample-1209-tile-map-editor-document.json -> sample.1209.tile-model-converter.json
42+
YES - samples\phase-12\1209\sample.1209.palette.json -> presetReferences.js
43+
YES - samples\phase-12\1209\sample.1209.tile-map-editor.json -> index.html
44+
YES - samples\phase-12\1209\sample.1209.tile-model-converter.json -> presetReferences.js
45+
YES - samples\phase-12\1210\sample-1210-tile-map-editor-document.json -> presetReferences.js
46+
YES - samples\phase-12\1210\sample.1210.palette.json -> presetReferences.js
47+
YES - samples\phase-12\1210\sample.1210.tile-map-editor.json -> index.html
48+
YES - samples\phase-12\1211\sample-1211-tile-map-editor-document.json -> presetReferences.js
49+
YES - samples\phase-12\1211\sample.1211.palette.json -> presetReferences.js
50+
YES - samples\phase-12\1211\sample.1211.tile-map-editor.json -> index.html
51+
YES - samples\phase-12\1212\sample-1212-vector-map-editor.json -> index.html
52+
YES - samples\phase-12\1213\sample-1213-vector-map-editor.json -> index.html
53+
YES - samples\phase-12\1214\sample-1214-vector-map-editor.json -> index.html
54+
YES - samples\phase-12\1215\sample-1215-svg-asset-studio.json -> index.html
55+
YES - samples\phase-12\1216\sample-1216-svg-asset-studio.json -> index.html
56+
YES - samples\phase-12\1217\sample-1217-svg-asset-studio.json -> index.html
57+
YES - samples\phase-12\1218\sample-1218-parallax-editor.json -> index.html
58+
YES - samples\phase-12\1219\sample-1219-parallax-editor.json -> index.html
59+
YES - samples\phase-12\1220\sample-1220-parallax-editor.json -> index.html
60+
YES - samples\phase-14\1413\sample.1413.3d-asset-viewer.json -> sample.1413.asset-browser.json
61+
YES - samples\phase-14\1413\sample.1413.asset-browser.json -> sample.1413.asset-browser.json
62+
YES - samples\phase-14\1413\sample.1413.asset-pipeline-tool.json -> main.js
63+
YES - samples\phase-14\1414\sample.1414.palette.json -> main.js
64+
YES - samples\phase-14\1414\sample.1414.sprite-editor.json -> TextureSpritePreprocessPipelineScene.js
65+
YES - samples\phase-15\1505\sample.1505.asset-browser.json -> main.js
66+
YES - samples\phase-19\1902\sample.1902.workspace-all-tools.json -> main.js
67+
68+
Sample JSON reference audit complete.
69+
JSON files scanned: 66
70+
Referenced: 66
71+
Missing reference: 0
72+
Report: docs/dev/reports/sample_json_js_reference_audit.csv

0 commit comments

Comments
 (0)