Skip to content

Commit c3225ce

Browse files
author
DavidQ
committed
Rollback unstable Workspace V2 communication/runtime changes while preserving Session Inspector and cosmetic UI improvements - PR_26128_001-workspace-recovery-baseline
1 parent 9171787 commit c3225ce

3 files changed

Lines changed: 43 additions & 0 deletions

File tree

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
# PR_26128_001 Playwright Workspace Recovery
2+
3+
## Validation Results
4+
- `npm run test:workspace-v2`: Pass, 10 passed.
5+
- Targeted Workspace Manager V2 launch validation: Pass.
6+
- Targeted Preview Generator V2 workspace launch validation: Pass.
7+
- Repo selection without `showDirectoryPicker` dependency: Pass. The targeted probe disabled `window.showDirectoryPicker`, selected Asteroids in Workspace Manager V2, launched Preview Generator V2 from workspace context, hydrated `repoPath` from the session context, and wrote `games/Asteroids/assets/images/preview.svg` through the restored baseline write path.
8+
- Accordion controls: Pass. The targeted probe collapsed and reopened the Active Game accordion and verified `hidden` plus `aria-expanded` state changes.
9+
- Session Inspector launch: Not run. `tools/session-inspector/index.html` is not present in this checkout, so there was no Session Inspector page to launch after rollback.
10+
11+
## Removed Coupling Checks
12+
- `selectRepoButton` was absent from Workspace Manager V2 after rollback.
13+
- Node-backed repo endpoints and persisted repo handle stores were absent from the recovered Workspace Manager V2 path.
14+
- Preview Generator V2 workspace launch kept the repo picker hidden and hydrated from workspace session context.
15+
16+
## Full Samples Smoke Test
17+
- Full samples smoke test was skipped by BUILD instruction. This rollback is scoped to Workspace Manager V2, Preview Generator V2, and shared shell rollback validation, and the requested validation explicitly says to skip the full samples smoke test.
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
# PR_26128_001 Rollback Preserved Items
2+
3+
## Preserved Baseline
4+
- Preserved the committed Workspace Manager V2 accordion behavior in `tools/workspace-manager-v2/js/controls/AccordionSection.js`.
5+
- Preserved committed Workspace Manager V2 layout and non-runtime UI consistency updates in `tools/workspace-manager-v2/index.html` and `tools/workspace-manager-v2/styles/workspaceManagerV2.css`.
6+
- Preserved the committed Preview Generator V2 baseline where Workspace Manager launches hydrate from session context and tools-mode repo picking remains local to Preview Generator V2.
7+
- Preserved existing schema files exactly; no `tools/schemas/**` files were changed by this rollback.
8+
- Preserved sample JSON exactly; no `games/**`, `samples/**`, or sample manifest JSON files were changed by this rollback.
9+
- Preserved roadmap content exactly; no roadmap files were changed by this rollback.
10+
11+
## Session Inspector Note
12+
- `tools/session-inspector/**` is not present in this checkout after rollback, and no files under that path were available to preserve or modify.
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
# PR_26128_001 Rollback Removed Items
2+
3+
## Removed Runtime Rewrites
4+
- Removed the uncommitted Workspace Manager V2 repo scan/select rewrite that added `selectRepoButton`, `activeRepoSummary`, `selectRepoRoot`, repo handle persistence, and `/__repo/games` coupling.
5+
- Removed the uncommitted Preview Generator V2 node write mode rewrite that added `/__preview-generator-v2/write-preview`, `/__repo/status`, persisted repo handle restore, and node endpoint write selection.
6+
- Removed the uncommitted shared `tools/common/RepoHandleStore.js` coupling and `tools/preview-generator-v2/PreviewGeneratorV2RepoHandleStore.js` wrapper.
7+
- Removed the uncommitted `scripts/workspace-v2-dev-server.mjs` dev server and the related `package.json` `dev-tools` / `dev:workspace-v2` script additions.
8+
- Removed the uncommitted storage debug page replacement under `tests/index.html`, `tests/storage-debug.css`, and `tests/storage-debug.js`.
9+
- Removed the uncommitted Workspace V2 test rewrites that depended on node-backed repo selection, storage debug persistence, and persisted browser directory handles.
10+
11+
## Restored Baseline Behavior
12+
- Workspace Manager V2 now uses the committed static game list and sessionStorage-based workspace context flow.
13+
- Preview Generator V2 workspace launch uses the committed session-context repoPath hydration path and no longer depends on the removed node dev-tools server.
14+
- Preview Generator V2 tools-mode repo picking remains scoped to Preview Generator V2 and is not shared through IndexedDB or Workspace Manager V2 auto-wiring.

0 commit comments

Comments
 (0)