Fix accordion initialization and edge case behavior in Preview Generator V2 - PR_26126_048-preview-generator-v2-accordion_edge_cases

Author: DavidQ

docs/dev/reports/preview_generator_v2_accordion_edge_cases.txt

@@ -0,0 +1,39 @@
+PR_26126_048 Preview Generator V2 accordion edge cases
+
+Scope
+- Updated Preview Generator V2 Playwright coverage only.
+- No runtime tool behavior was changed.
+- No samples, schemas, or start_of_day files were modified.
+
+Edge-case audit
+- Browser measurement verified all accordion sections initialize open with matching aria-expanded and icon state.
+- Browser measurement verified all accordion sections respond on first click.
+- Browser measurement verified collapsed content height is zero and display is none.
+- Browser measurement verified reopened sections restore visible content.
+- Browser measurement verified Paths or IDs restores its flex/stretch behavior after reopening.
+- Browser measurement verified Status, Paths or IDs, and Last Generated Image behave correctly.
+
+Playwright coverage added
+- The shared accordion test helper now verifies initial open state before clicking.
+- The helper verifies icon state before collapse, after collapse, and after reopen.
+- The helper verifies content hidden state and display state after collapse/reopen.
+- The helper verifies collapsed content height is zero.
+- The helper verifies collapsed section flex resolves to header-only sizing.
+- The helper verifies collapsed section height is smaller than its expanded height.
+
+Validation
+- node --check tests/playwright/PreviewGeneratorV2Baseline.spec.mjs passed.
+- npm run test:workspace-v2 passed.
+- Result: 3 passed.
+- Confirmed no samples, schemas, or start_of_day changes.
+- Search found no Preview Generator V2 references to accordionV2.js, mountAccordionV2, or setAccordionV2Open.
+
+Full samples smoke test
+- Skipped intentionally.
+- Reason: this PR is a targeted Preview Generator V2 accordion edge-case coverage pass and does not modify sample JSON, sample launch code, or shared sample runtime behavior.
+
+Manual validation
+- Open tools/preview-generator-v2/index.html.
+- On first click, collapse each accordion and confirm it immediately closes.
+- Confirm no hidden content leaves a visible gap.
+- Reopen Status, Paths or IDs, and Last Generated Image and confirm each restores its expected layout.

tests/playwright/PreviewGeneratorV2Baseline.spec.mjs

@@ -113,18 +113,45 @@ async function expectAccordionToggles(page, contentId) {
   const header = page.locator(`.accordion-v2__header[aria-controls="${contentId}"]`);
   const content = page.locator(`#${contentId}`);
   const icon = header.locator(".accordion-v2__icon");
+  const readLayout = async () => await page.evaluate((id) => {
+    const contentEl = document.getElementById(id);
+    const section = contentEl.closest(".accordion-v2");
+    return {
+      sectionHeight: section.getBoundingClientRect().height,
+      contentHeight: contentEl.getBoundingClientRect().height,
+      sectionFlex: getComputedStyle(section).flex,
+      contentDisplay: getComputedStyle(contentEl).display,
+      contentHidden: contentEl.hidden
+    };
+  }, contentId);
+
   await expect(header).toBeVisible();
   await expect(content).toBeVisible();
+  await expect(header).toHaveAttribute("aria-expanded", "true");
+  await expect(icon).toHaveAttribute("data-accordion-v2-icon-state", "open");
+  const expandedLayout = await readLayout();
+  expect(expandedLayout.contentHidden).toBe(false);
+  expect(expandedLayout.contentDisplay).not.toBe("none");
 
   await header.click();
   await expect(content).toBeHidden();
   await expect(header).toHaveAttribute("aria-expanded", "false");
   await expect(icon).toHaveAttribute("data-accordion-v2-icon-state", "closed");
+  const collapsedLayout = await readLayout();
+  expect(collapsedLayout.contentHidden).toBe(true);
+  expect(collapsedLayout.contentDisplay).toBe("none");
+  expect(collapsedLayout.contentHeight).toBe(0);
+  expect(collapsedLayout.sectionHeight).toBeLessThan(expandedLayout.sectionHeight);
+  expect(collapsedLayout.sectionFlex).toContain("0 0");
 
   await header.click();
   await expect(content).toBeVisible();
   await expect(header).toHaveAttribute("aria-expanded", "true");
   await expect(icon).toHaveAttribute("data-accordion-v2-icon-state", "open");
+  const reopenedLayout = await readLayout();
+  expect(reopenedLayout.contentHidden).toBe(false);
+  expect(reopenedLayout.contentDisplay).not.toBe("none");
+  expect(reopenedLayout.contentHeight).toBeGreaterThan(0);
 }
 
 async function expectPathsOrIdsAccordionToggles(page) {