Skip to content

Commit b79e015

Browse files
author
DavidQ
committed
Update Asteroids manifest chrome assets to bezel1 and deluxe images - PR 11.84
1 parent 8ec5f28 commit b79e015

7 files changed

Lines changed: 73 additions & 24 deletions

File tree

docs/dev/codex_commands.md

Lines changed: 4 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,8 @@
1-
# Codex Commands — PR 11.83
1+
# Codex Command — PR 11.84
22

3-
Model: GPT-5.4
4-
Reasoning: high
3+
Model: GPT-5.4-mini
4+
Reasoning: medium
55

66
```text
7-
Run BUILD_PR_LEVEL_11_83_LOCK_ASSET_LOADING_TO_MANIFEST_ONLY.
8-
9-
Implement a targeted fix so Workspace Manager/game launch asset loading uses game.manifest.json as the only source of truth for game chrome assets. Do not guess /games/<Game>/assets/images/bezel.png or background.png. Do not add fallback assets. Do not add aliases or pass-through shims.
10-
11-
Tasks:
12-
1. Find code that derives game chrome image paths by convention, especially bezel/background.
13-
2. Replace convention-derived URLs with explicit manifest asset lookup.
14-
3. If a manifest does not declare an optional chrome asset, skip rendering/requesting that image and show safe empty state.
15-
4. Preserve games that already declare chrome assets in game.manifest.json.
16-
5. Search the repo for remaining hardcoded or derived references to /assets/images/bezel.png and /assets/images/background.png and remove convention-only loading paths.
17-
6. Run targeted validation only:
18-
- launch SolarSystem and verify no bezel/background 404s
19-
- launch a game with declared manifest chrome assets, such as Asteroids if available, and verify declared assets still load
20-
- run syntax/import checks for changed JS files
21-
7. Write evidence to docs/dev/reports/asset_manifest_only_validation.md.
22-
8. If roadmap status is touched, status-only update only.
23-
24-
Return a ZIP artifact at <project folder>/tmp/PR_11_83_LOCK_ASSET_LOADING_TO_MANIFEST_ONLY.zip.
7+
Apply PR 11.84 exactly as documented in docs/pr/PR_11_84_ASTEROIDS_MANIFEST_CHROME_ASSETS.md. Update only games/Asteroids/game.manifest.json so image.asteroids.bezel points to /games/Asteroids/assets/images/bezel1.png and image.asteroids.background points to /games/Asteroids/assets/images/deluxe.png. Preserve manifest structure. Do not modify other games, loaders, or shared asset behavior. Run the targeted validation commands and write results to docs/dev/reports/pr_11_84_asteroids_manifest_validation.md. Return a repo-structured ZIP at tmp/PR_11_84_ASTEROIDS_MANIFEST_CHROME_ASSETS.zip.
258
```

docs/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Lock game asset loading to manifest-declared assets only - PR 11.83
1+
Update Asteroids manifest chrome assets to bezel1 and deluxe images - PR 11.84

docs/dev/reports/launch_smoke_report.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Launch Smoke Report
22

3-
Generated: 2026-04-29T23:54:15.633Z
3+
Generated: 2026-04-30T00:05:34.081Z
44

55
Filters: games=true, samples=false, tools=false, sampleRange=all
66

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
# PR 11.84 Expected Validation
2+
3+
- Confirm `games/Asteroids/assets/images/bezel1.png` exists.
4+
- Confirm `games/Asteroids/assets/images/deluxe.png` exists.
5+
- Confirm `games/Asteroids/game.manifest.json` references both files.
6+
- Confirm Asteroids no longer requests guessed `bezel.png` or `background.png` chrome assets.
Lines changed: 55 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
1+
# PR 11.84 — Asteroids Manifest Chrome Assets
2+
3+
## Purpose
4+
Update the Asteroids `game.manifest.json` file so Workspace/Game launch uses declared manifest assets instead of guessed chrome asset paths.
5+
6+
## Required change
7+
Find the Asteroids manifest, expected path:
8+
9+
```text
10+
games/Asteroids/game.manifest.json
11+
```
12+
13+
Update or add the manifest asset entries so they resolve to:
14+
15+
```json
16+
"image.asteroids.bezel": {
17+
"path": "/games/Asteroids/assets/images/bezel1.png",
18+
"kind": "image",
19+
"source": "workspace-manager"
20+
},
21+
"image.asteroids.background": {
22+
"path": "/games/Asteroids/assets/images/deluxe.png",
23+
"kind": "image",
24+
"source": "workspace-manager"
25+
}
26+
```
27+
28+
## Guardrails
29+
- Do not add guessed fallback paths.
30+
- Do not modify other games.
31+
- Do not create placeholder image files.
32+
- Do not change shared asset-loading behavior in this PR.
33+
- Preserve existing manifest structure and ordering as much as possible.
34+
35+
## Validation
36+
Run targeted checks only:
37+
38+
```powershell
39+
Test-Path .\games\Asteroids\assets\images\bezel1.png
40+
Test-Path .\games\Asteroids\assets\images\deluxe.png
41+
Select-String -Path .\games\Asteroids\game.manifest.json -Pattern "bezel1.png|deluxe.png"
42+
```
43+
44+
Then open Asteroids through Workspace Manager and verify no request is made for:
45+
46+
```text
47+
/games/Asteroids/assets/images/bezel.png
48+
/games/Asteroids/assets/images/background.png
49+
```
50+
51+
## Acceptance
52+
- Asteroids manifest references `bezel1.png` for bezel.
53+
- Asteroids manifest references `deluxe.png` for background.
54+
- No hardcoded fallback asset paths are introduced.
55+
- Targeted validation report is written under `docs/dev/reports`.

games/Asteroids/game.manifest.json

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,12 @@
187187
"source": "workspace-manager"
188188
},
189189
"image.asteroids.bezel": {
190-
"path": "/games/Asteroids/assets/images/bezel.png",
190+
"path": "/games/Asteroids/assets/images/bezel1.png",
191+
"kind": "image",
192+
"source": "workspace-manager"
193+
},
194+
"image.asteroids.background": {
195+
"path": "/games/Asteroids/assets/images/deluxe.png",
191196
"kind": "image",
192197
"source": "workspace-manager"
193198
}

0 commit comments

Comments
 (0)