Skip to content

Commit afae1e0

Browse files
author
DavidQ
committed
PR_26126_096 asset manager center detail game session
1 parent 922c299 commit afae1e0

16 files changed

Lines changed: 616 additions & 453 deletions

‎.gitignore‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,3 +23,6 @@ codex_changed_files.txt
2323
docs/dev/reports/codex_changed_files.txt
2424
codex_review.diff
2525
docs/dev/reports/codex_review.diff
26+
27+
*.mp4
28+
*.mkv

‎docs/dev/reports/PR_26126_096_asset_manager_v2_games_only_workspace_context_notes.md‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
# PR_26126_096 Asset Manager V2 Games-Only Workspace Context Notes
2+
3+
## Context Model
4+
- Workspace preview context is now expressed as a games-only root: `games/<game>/`.
5+
- Asset Manager V2 does not introduce Sample or Tool workspace roots for preview resolution.
6+
- `projectId` is no longer treated as a game identifier fallback by the Asset Manager V2 Workspace bridge.
7+
- Workspace game id lookup is limited to explicit game fields such as `gameId`, `game`, `metadata.gameId`, and `workspaceMetadata.gameId`.
8+
9+
## Preview Resolution
10+
- File-backed Workspace asset paths stored as `assets/...` resolve to `games/<game>/assets/...` for preview only.
11+
- Existing `games/...` paths, protocol URLs, palette URLs, and non-asset paths are left unchanged.
12+
- Missing game context still produces a visible Status failure instead of falling back to `/assets/...`.
13+
14+
## Validation
15+
- Playwright validates Workspace-launched Asset Manager V2 reports preview context as `games/Asteroids/`.
16+
- Playwright validates that preview context does not contain `samples` or `tools` roots.
17+
- Playwright validates audio, font, and image preview paths resolve under `/games/Asteroids/assets/...`.

‎docs/dev/reports/PR_26126_096_asset_manager_v2_manual_validation_notes.md‎

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
# PR_26126_096 Asset Manager V2 Manual Validation Notes
2+
3+
## Commands
4+
- `node --check tools/asset-manager-v2/js/assetPreviewHelpers.js`
5+
- `node --check tools/asset-manager-v2/js/services/WorkspaceBridge.js`
6+
- `node --check tools/asset-manager-v2/js/services/TemporaryUatSamplePalette.js`
7+
- `node --check tools/asset-manager-v2/js/AssetManagerV2App.js`
8+
- `node --check tests/playwright/PreviewGeneratorV2Baseline.spec.mjs`
9+
- `npx playwright test tests/playwright/PreviewGeneratorV2Baseline.spec.mjs --project=playwright --reporter=list -g "Asset Manager V2"`
10+
- `npm run test:workspace-v2`
11+
12+
## Results
13+
- JavaScript syntax checks passed for changed runtime and Playwright files.
14+
- Focused Asset Manager V2 Playwright slice passed: 5 tests passed.
15+
- Required workspace-v2 Playwright gate passed: 12 tests passed.
16+
- `docs/dev/reports/playwright_v8_coverage_report.txt` was regenerated by the required workspace-v2 validation run.
17+
18+
## Manual Checks Covered By Tests
19+
- Selected Asset Detail is placed in the center panel, outside the Assets list, and does not span the full screen.
20+
- Selected Asset Detail height is increased to at least 220px.
21+
- Asset preview remains inside Selected Asset Detail.
22+
- Workspace preview context is games-only.
23+
- `?palette=sample` temporary UAT root uses `games/Asteroids/` for preview/path testing only.
24+
- `?palette=sample` image previews resolve under `/games/Asteroids/assets/...`.
25+
- Sample JSON files were not modified.

‎docs/dev/reports/PR_26126_096_asset_manager_v2_selected_detail_placement_notes.md‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
# PR_26126_096 Asset Manager V2 Selected Detail Placement Notes
2+
3+
## Placement
4+
- Selected Asset Detail moved into the Asset Manager V2 center panel.
5+
- Selected Asset Detail is no longer a full-width bottom control spanning left-to-right across the app shell.
6+
- The Assets list remains separate inside the Assets accordion.
7+
- `assetPreview` remains embedded inside Selected Asset Detail.
8+
9+
## Height
10+
- Selected Asset Detail now reserves 220px in the center panel.
11+
- This increases the previous 120px bottom-screen allocation by 100px.
12+
- The center panel keeps Assets as the fill area and Selected Asset Detail as a fixed-height detail/preview area.
13+
14+
## Validation
15+
- Playwright validates Selected Asset Detail is not inside `assetsContent`.
16+
- Playwright validates Selected Asset Detail is parented by the center panel.
17+
- Playwright validates the detail control stays inside the center panel and does not span the full app width.
18+
- Playwright validates the detail height is at least 220px.
19+
- Playwright validates `assetPreview` remains inside Selected Asset Detail.

‎docs/dev/reports/PR_26126_096_asset_manager_v2_temporary_uat_session_root_notes.md‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
# PR_26126_096 Asset Manager V2 Temporary UAT Session Root Notes
2+
3+
## Temporary Behavior
4+
- `?palette=sample` remains isolated in `TemporaryUatSamplePalette.js`.
5+
- For UAT preview/path testing only, `?palette=sample` now provides the temporary game root `games/Asteroids/`.
6+
- The temporary root is used only by Asset Manager V2 preview options.
7+
- Asset records still store normalized asset paths such as `assets/images/uat-preview.png`; the game root is not persisted into asset entries.
8+
- The code and Status log both mark this behavior as temporary UAT-only.
9+
10+
## Preview Result
11+
- During `?palette=sample`, file-backed previews for `assets/...` paths resolve through `/games/Asteroids/assets/...`.
12+
- The temporary preview path does not use Sample or Tool roots.
13+
- Palette color behavior remains unchanged and still uses the temporary sample palette swatches only.
14+
15+
## Validation
16+
- Playwright validates the temporary Status message for `games/Asteroids/`.
17+
- Playwright validates a `?palette=sample` image asset preview renders with `/games/Asteroids/assets/images/uat-preview.png`.
18+
- Playwright validates the UAT preview path excludes `/samples/` and `/tools/`.

‎docs/dev/reports/codex_changed_files.txt‎

Lines changed: 20 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -5,26 +5,28 @@ M docs/dev/reports/coverage_changed_js_guardrail.txt
55
M tools/asset-manager-v2/index.html
66
M tools/asset-manager-v2/js/AssetManagerV2App.js
77
M tools/asset-manager-v2/js/assetPreviewHelpers.js
8-
M tools/asset-manager-v2/js/controls/AssetCatalogControl.js
8+
M tools/asset-manager-v2/js/services/TemporaryUatSamplePalette.js
9+
M tools/asset-manager-v2/js/services/WorkspaceBridge.js
910
M tools/asset-manager-v2/styles/assetManager.css
10-
M tools/workspace-v2/index.js
11-
?? docs/dev/reports/PR_26126_095_asset_manager_v2_manual_validation_notes.md
12-
?? docs/dev/reports/PR_26126_095_asset_manager_v2_preview_path_resolution_notes.md
13-
?? docs/dev/reports/PR_26126_095_asset_manager_v2_selected_asset_detail_placement_notes.md
11+
?? docs/dev/reports/PR_26126_096_asset_manager_v2_games_only_workspace_context_notes.md
12+
?? docs/dev/reports/PR_26126_096_asset_manager_v2_manual_validation_notes.md
13+
?? docs/dev/reports/PR_26126_096_asset_manager_v2_selected_detail_placement_notes.md
14+
?? docs/dev/reports/PR_26126_096_asset_manager_v2_temporary_uat_session_root_notes.md
1415

1516
# git ls-files --others --exclude-standard
16-
docs/dev/reports/PR_26126_095_asset_manager_v2_manual_validation_notes.md
17-
docs/dev/reports/PR_26126_095_asset_manager_v2_preview_path_resolution_notes.md
18-
docs/dev/reports/PR_26126_095_asset_manager_v2_selected_asset_detail_placement_notes.md
17+
docs/dev/reports/PR_26126_096_asset_manager_v2_games_only_workspace_context_notes.md
18+
docs/dev/reports/PR_26126_096_asset_manager_v2_manual_validation_notes.md
19+
docs/dev/reports/PR_26126_096_asset_manager_v2_selected_detail_placement_notes.md
20+
docs/dev/reports/PR_26126_096_asset_manager_v2_temporary_uat_session_root_notes.md
1921

2022
# git diff --stat
21-
docs/dev/reports/coverage_changed_js_guardrail.txt | 10 ++--
22-
docs/dev/reports/playwright_v8_coverage_report.txt | 24 ++++----
23-
.../playwright/PreviewGeneratorV2Baseline.spec.mjs | 64 +++++++++++++++++++++-
24-
tools/asset-manager-v2/index.html | 21 +++----
25-
tools/asset-manager-v2/js/AssetManagerV2App.js | 1 +
26-
tools/asset-manager-v2/js/assetPreviewHelpers.js | 17 ++++--
27-
.../js/controls/AssetCatalogControl.js | 22 +++++++-
28-
tools/asset-manager-v2/styles/assetManager.css | 11 +++-
29-
tools/workspace-v2/index.js | 23 ++++++++
30-
9 files changed, 152 insertions(+), 41 deletions(-)
23+
docs/dev/reports/coverage_changed_js_guardrail.txt | 7 +--
24+
docs/dev/reports/playwright_v8_coverage_report.txt | 18 ++++---
25+
.../playwright/PreviewGeneratorV2Baseline.spec.mjs | 59 ++++++++++++++++++----
26+
tools/asset-manager-v2/index.html | 21 ++++----
27+
tools/asset-manager-v2/js/AssetManagerV2App.js | 14 ++++-
28+
tools/asset-manager-v2/js/assetPreviewHelpers.js | 15 ++++--
29+
.../js/services/TemporaryUatSamplePalette.js | 4 ++
30+
.../js/services/WorkspaceBridge.js | 20 +++++---
31+
tools/asset-manager-v2/styles/assetManager.css | 7 ++-
32+
9 files changed, 121 insertions(+), 44 deletions(-)

0 commit comments

Comments
 (0)