Log real repo root and verify Preview Generator V2 writes before reporting success - PR_26128_031-preview-generator-real-root-path

Author: DavidQ

docs/dev/reports/playwright_preview_generator_real_root_path.md

@@ -0,0 +1,29 @@
+# Playwright Preview Generator V2 Real Root Path
+
+## Commands
+- `node --check tools/preview-generator-v2/PreviewGeneratorV2App.js`
+- `node --check tests/playwright/tools/WorkspaceManagerV2.spec.mjs`
+- `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list -g "exports manifests and launches tools from fixed Workspace Manager V2 tiles|logs actionable Preview Generator V2 output path resolution failures|loads Gravity Well and Pong manifests"`
+- `npm run test:workspace-v2`
+- `git diff --check`
+
+## Results
+- JavaScript syntax checks: passed.
+- Focused Preview Generator V2 real-root-path coverage: passed 3/3.
+- Workspace Manager V2 suite: passed 17/17.
+- Diff whitespace check: passed.
+
+## Targeted Coverage
+- Generated a Pong preview with Force rewrite enabled.
+- Verified the log shows the actual repo root:
+  - `Repo root: C:\Users\davidq\Documents\GitHub\HTML-JavaScript-Gaming`
+- Verified the log shows:
+  - `Resolved relative output path: games/Pong/assets/images/preview.svg`
+  - `Full absolute output path: C:\Users\davidq\Documents\GitHub\HTML-JavaScript-Gaming\games\Pong\assets\images\preview.svg`
+- Verified `OK WRITE Pong` appears only after write verification passes.
+- Verified Force rewrite logs replacement verification after write read-back succeeds.
+- Verified summary `Written: 1` appears only for the verified write path.
+- Verified missing repo root state logs `FAIL` and does not log `OK WRITE`.
+
+## Skipped
+- Full samples smoke test was skipped by request. The required Preview Generator V2 path, verification, force-rewrite, failure, and Workspace launch paths are covered by `tests/playwright/tools/WorkspaceManagerV2.spec.mjs`.

docs/dev/reports/preview_generator_real_root_path.md

@@ -0,0 +1,36 @@
+# Preview Generator V2 Real Root Path
+
+## Scope
+- Updated Preview Generator V2 output path resolution so logged absolute paths are built from the selected repo root plus the resolved relative output path.
+- Workspace launch hydration now preserves the actual repo root path from `workspace.repo.reference`.
+- Execution logs the selected repo root before batch processing.
+- Each successful write logs:
+  - resolved relative output path
+  - repo root path
+  - full absolute output path
+  - source resolution context
+
+## Verification Behavior
+- If the repo root path is unavailable, Preview Generator V2 logs `FAIL Repo root path resolution` and does not claim `OK WRITE`.
+- Write success is counted only after `writePreview` returns a verified successful write result.
+- When file read-back is available, the written `preview.svg` is read back and compared to the generated SVG before `OK WRITE` is logged.
+- Force rewrite logs verification only after the replacement write passes read-back verification.
+- Verification failures log `FAIL` with the expected full absolute output path and do not increment `Written`.
+
+## Pong Target
+- Force rewrite validation covers Pong.
+- Expected repo root:
+  - `C:\Users\davidq\Documents\GitHub\HTML-JavaScript-Gaming`
+- Expected full absolute output path:
+  - `C:\Users\davidq\Documents\GitHub\HTML-JavaScript-Gaming\games\Pong\assets\images\preview.svg`
+- The resolved relative output path remains:
+  - `games/Pong/assets/images/preview.svg`
+
+## Guardrails
+- No hidden fallback output paths were added.
+- No sample JSON was modified.
+- No roadmap content was modified.
+- Source resolution context logging was preserved.
+
+## Skipped
+- Full samples smoke test was skipped by request. The changed surface is Preview Generator V2 path logging and write verification, covered by the targeted Pong generation path plus the full Workspace V2 Playwright suite.

games/pong/assets/images/preview.svg games/pong/assets/images/preview1.svggames/pong/assets/images/preview.svg renamed to games/pong/assets/images/preview1.svg

@@ -43,6 +43,14 @@ function manifestRepoPath(server) {
   return server.repoRoot.replaceAll("\\", "/");
 }
 
+function displayRepoRootPath(server) {
+  return server.repoRoot.replaceAll("/", "\\").replace(/\\+$/, "");
+}
+
+function displayAbsoluteOutputPath(server, relativePath) {
+  return `${displayRepoRootPath(server)}\\${relativePath.replaceAll("/", "\\")}`;
+}
+
 async function installMockRepoPicker(page) {
   await page.addInitScript(() => {
     const defaultManifestPaths = [
@@ -1894,12 +1902,15 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       expect(previewStatusHeaderOrder).toEqual(["Status", "+", "Clear"]);
       await page.locator("#executeBtn").click();
       await expect(page.locator("#log")).toContainText("Starting execution...", { timeout: 20000 });
+      await expect(page.locator("#log")).toContainText(`Repo root: ${displayRepoRootPath(server)}`, { timeout: 20000 });
       await expect(page.locator("#log")).toContainText("RUN  Asteroids", { timeout: 20000 });
       await expect(page.locator("#log")).toContainText("OUT  games\\Asteroids\\assets\\images\\preview.svg", { timeout: 20000 });
       await expect(page.locator("#log")).toContainText("OK WRITE Asteroids", { timeout: 20000 });
       await expect(page.locator("#log")).toContainText("Resolved relative output path: games/Asteroids/assets/images/preview.svg", { timeout: 20000 });
-      await expect(page.locator("#log")).toContainText("Absolute output path: HTML-JavaScript-Gaming/games/Asteroids/assets/images/preview.svg", { timeout: 20000 });
+      await expect(page.locator("#log")).toContainText(`Repo root: ${displayRepoRootPath(server)}`, { timeout: 20000 });
+      await expect(page.locator("#log")).toContainText(`Full absolute output path: ${displayAbsoluteOutputPath(server, "games/Asteroids/assets/images/preview.svg")}`, { timeout: 20000 });
       await expect(page.locator("#log")).toContainText("Source resolution context: workspace.tools.preview-generator-v2.data; selected game: Asteroids; resolved assets/images target: assets/images; target type: games", { timeout: 20000 });
+      await expect(page.locator("#log")).toContainText(`Write verification passed: file exists at ${displayAbsoluteOutputPath(server, "games/Asteroids/assets/images/preview.svg")}.`, { timeout: 20000 });
       await expect(page.locator("#log")).toContainText("OK   Asteroids", { timeout: 20000 });
       await expect(page.locator("#log")).toContainText("Done.", { timeout: 20000 });
       await expect(page.locator("#lastGeneratedImageMeta")).toHaveText("Last generated: Asteroids");
@@ -2127,11 +2138,15 @@ test.describe("Workspace Manager V2 bootstrap", () => {
 
       await page.locator("#executeBtn").click();
       const log = page.locator("#log");
+      await expect(log).toContainText("Repo root: unavailable", { timeout: 10000 });
+      await expect(log).toContainText("FAIL Repo root path resolution: Repo root path is unavailable; cannot resolve a full absolute output path.", { timeout: 10000 });
       await expect(log).toContainText("FAIL PATH MissingGame", { timeout: 10000 });
-      await expect(log).toContainText("Unable to resolve target directory: Missing directory: HTML-JavaScript-Gaming/games/MissingGame", { timeout: 10000 });
+      await expect(log).toContainText("Repo root path is unavailable; cannot resolve a full absolute output path.", { timeout: 10000 });
       await expect(log).toContainText("relative output path: games/MissingGame/assets/images/preview.svg", { timeout: 10000 });
-      await expect(log).toContainText("absolute output path: HTML-JavaScript-Gaming/games/MissingGame/assets/images/preview.svg", { timeout: 10000 });
+      await expect(log).toContainText("repo root: (unavailable)", { timeout: 10000 });
+      await expect(log).toContainText("full absolute output path: (unavailable)", { timeout: 10000 });
       await expect(log).toContainText("source resolution context: preview-generator-v2 form controls; selected game: MissingGame; resolved assets/images target: assets/images; target type: games", { timeout: 10000 });
+      await expect(log).not.toContainText("OK WRITE MissingGame");
       await expect(log).toContainText("Written: 0", { timeout: 10000 });
       await expect(log).toContainText("Failed: 1", { timeout: 10000 });
       await expect(log).toContainText("Skipped: 0", { timeout: 10000 });
@@ -2247,6 +2262,24 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       await expect(page.locator("#log")).toContainText("OK Workspace repo session reference loaded from workspace.repo.reference for HTML-JavaScript-Gaming.");
       await expect(page.locator("#log")).toContainText("Workspace launch repo context resolved from session storage; independent repo selection is not required.");
       await expect(page.locator("#log")).toContainText("Generated preview target: games/Pong/assets/images/preview.svg");
+      await page.locator("#forceRewrite").check();
+      await expect(page.locator("#executeBtn")).toBeEnabled();
+      await page.locator("#executeBtn").click();
+      await expect(page.locator("#log")).toContainText("Force rewrite: true", { timeout: 20000 });
+      await expect(page.locator("#log")).toContainText(`Repo root: ${displayRepoRootPath(server)}`, { timeout: 20000 });
+      await expect(page.locator("#log")).toContainText("RUN  Pong", { timeout: 20000 });
+      await expect(page.locator("#log")).toContainText("OK WRITE Pong", { timeout: 20000 });
+      await expect(page.locator("#log")).toContainText("Resolved relative output path: games/Pong/assets/images/preview.svg", { timeout: 20000 });
+      await expect(page.locator("#log")).toContainText(`Full absolute output path: ${displayAbsoluteOutputPath(server, "games/Pong/assets/images/preview.svg")}`, { timeout: 20000 });
+      await expect(page.locator("#log")).toContainText("Source resolution context: workspace.tools.preview-generator-v2.data; selected game: Pong; resolved assets/images target: assets/images; target type: games", { timeout: 20000 });
+      await expect(page.locator("#log")).toContainText(`Write verification passed: file exists at ${displayAbsoluteOutputPath(server, "games/Pong/assets/images/preview.svg")}.`, { timeout: 20000 });
+      await expect(page.locator("#log")).toContainText(`Force rewrite verification passed for ${displayAbsoluteOutputPath(server, "games/Pong/assets/images/preview.svg")}.`, { timeout: 20000 });
+      await expect(page.locator("#log")).toContainText("Written: 1", { timeout: 20000 });
+      await expect(page.locator("#log")).toContainText("Failed: 0", { timeout: 20000 });
+      await expect(page.locator("#log")).toContainText("Done.", { timeout: 20000 });
+      const pongPreviewWrites = await page.evaluate(() => JSON.parse(sessionStorage.getItem("workspace.repo.writes") || "[]"));
+      expect(pongPreviewWrites.at(-1).path).toBe("HTML-JavaScript-Gaming/games/Pong/assets/images/preview.svg");
+      expect(pongPreviewWrites.at(-1).contents).toContain("<svg");
       await page.locator("#returnToWorkspaceButton").click();
       await expect(page).toHaveURL(/workspace-manager-v2\/index\.html\?hostContextId=workspace-manager-v2-/);