Require repair-or-report execution for direct JSON cleanup lane - PR 11.113

Author: DavidQ

docs/dev/codex_commands.md

@@ -4,73 +4,124 @@ Model: GPT-5.3-codex
 Reasoning: medium
 
 ## PR
-BUILD_PR_LEVEL_11_111_TEST_SCHEMA_RELOCATION_AND_INFER_PATH_REMOVAL
+BUILD_PR_LEVEL_11_113_CODEX_REPAIR_OR_REPORT_ENFORCEMENT
 
 ## Execute
 
-1. Move test-only schema files out of runtime tool folders:
-   - tools/palette-editor/tool.schema.json -> tests/fixtures/tool-schemas/palette-editor/tool.schema.json
-   - tools/vector-asset-studio/tool.schema.json -> tests/fixtures/tool-schemas/vector-asset-studio/tool.schema.json
-   - tools/vector-map-editor/tool.schema.json -> tests/fixtures/tool-schemas/vector-map-editor/tool.schema.json
+This PR exists because the previous run applied no changes and left reports empty.
 
-2. Update any tests or scripts that referenced the old paths.
+### Mandatory Rule
 
-3. Do not leave duplicate runtime copies at:
-   - tools/palette-editor/tool.schema.json
-   - tools/vector-asset-studio/tool.schema.json
-   - tools/vector-map-editor/tool.schema.json
+Do not finish with empty reports.
 
-4. Search focused tool input/loading/shared code for inference and compatibility helpers:
-   - infer*
-   - normalize*
-   - transform*
-   - convert*
-   - coerce*
-   - resolve*Legacy*
-   - fallback*
-   - default* when used as hidden input/data injection
-   - alias/remap helpers
+For every requested item, do one:
+1. Fix it.
+2. Prove no fix is needed with file/path evidence.
+3. Report a precise blocker with file/path/line evidence and the next required action.
 
-5. Remove the smallest safe set of shared inference/compatibility code that affects tool input/source/payload loading.
+### Repair Loop
 
-6. Keep only allowed pre-schema checks:
-   - file exists
-   - JSON parse
+For each issue:
+1. Search.
+2. Record search scope and pattern.
+3. If found, fix if in scope.
+4. Re-run targeted validation.
+5. If not fixed, report exact blocker.
+6. Repeat until fixed or explicitly blocked.
 
-7. Ensure all other input validation is schema-only.
+### Revisit all active cleanup requests
 
-8. Ensure failures render visible screen errors:
-   - missing file
-   - malformed JSON
-   - schema mismatch
+1. Direct JSON only:
+   - no presets
+   - no normalizers
+   - no transformers
+   - no converters
+   - no default/demo/fallback data
 
-9. Preserve direct flow:
-   explicit JSON file -> schema validation -> render as-is
+2. Schema-only validation:
+   - allowed pre-schema checks: file exists, JSON parse
+   - all other validation belongs in schema
+   - invalid input renders visible screen error
 
-10. Preserve canonical names:
+3. Move test-only schema files:
+   - tools/palette-editor/tool.schema.json
+   - tools/vector-asset-studio/tool.schema.json
+   - tools/vector-map-editor/tool.schema.json
+   into:
+   - tests/fixtures/tool-schemas/<tool-id>/tool.schema.json
+   Remove runtime duplicates.
+
+4. Remove/report shared/tool input code:
+   - infer*
+   - normalize*
+   - tryLoadPreset*
+   - buildPreset*
+   - input-mutation replace*
+   - legacy remappers
+   - alias acceptance
+   - fallback/default data injection
+
+5. Enforce canonical names:
    - palette-browser
    - 3d-json-payload
    - asset-pipeline
 
-11. Preserve compact primitive-array formatting.
-
-12. Validate targeted paths:
-   - moved fixture files exist
-   - old runtime tool.schema.json files are gone
-   - changed test/script references work
-   - changed JSON parses
-   - changed manifests validate
-   - no removed helper references remain
-
-13. Write reports:
-   - docs/dev/reports/tool_schema_fixture_relocation_11_111.txt
-   - docs/dev/reports/inference_path_removal_11_111.txt
-   - docs/dev/reports/schema_only_runtime_check_11_111.txt
-
-14. Roadmap:
-   - update status markers only if execution-backed
-   - do not rewrite roadmap text
-   - do not delete roadmap text
-
-15. Package Codex output ZIP at:
-   tmp/PR_11_111_TEST_SCHEMA_RELOCATION_AND_INFER_PATH_REMOVAL.zip
+6. Remove stale names:
+   - palette as a tool key/name
+   - palette-editor
+   - 3d-json-payload-normalizer
+   - Asset Pipeline Tool
+   - asset-pipeline-tool
+
+7. Enforce sample/tool truthfulness:
+   - if sample cannot load in aligned tool, remove the tool reference
+   - do not add fake data
+
+8. Restore compact primitive arrays:
+   - primitive arrays must be compact grouped
+   - do not expand simple arrays one value per line
+
+### Validation
+
+Run targeted validation and include command/result in reports:
+- changed JSON parses
+- changed manifests validate
+- helper references removed or justified
+- moved files exist
+- old files removed
+- invalid input shows visible screen error if affected path changed
+
+### Reports
+
+Write populated reports:
+- docs/dev/reports/repair_or_report_summary_11_113.txt
+- docs/dev/reports/json_schema_repair_loop_11_113.txt
+- docs/dev/reports/shared_code_cleanup_11_113.txt
+- docs/dev/reports/tool_binding_truthfulness_11_113.txt
+- docs/dev/reports/blockers_11_113.txt
+
+Each report must include:
+- files searched
+- matches found
+- files changed
+- skipped items
+- exact reason skipped
+- validation command used
+- validation result
+- remaining blockers
+
+If zero matches:
+- report the exact search pattern
+- report the scope searched
+- state that zero matches were found
+
+### Roadmap
+
+- status-only update if execution-backed
+- do not rewrite roadmap text
+- do not delete roadmap text
+
+### Output
+
+Package Codex output ZIP at:
+tmp/PR_11_113_CODEX_REPAIR_OR_REPORT_ENFORCEMENT.zip

docs/dev/commit_comment.txt

@@ -1 +1 @@
-Move test tool schemas to fixtures and remove inference input paths - PR 11.111
+Require repair-or-report execution for direct JSON cleanup lane - PR 11.113

docs/dev/reports/blockers_11_113.txt

@@ -0,0 +1,88 @@
+PR 11.113 Blockers
+Date: 2026-04-30
+
+Blocker 1: Broad removal of tryLoadPreset/buildPreset helpers would break current standalone sample launch contract
+- Evidence
+  - `tryLoadPresetFromQuery` exists in standalone tools:
+    - tools/3D Asset Viewer/main.js
+    - tools/3D Camera Path Editor/main.js
+    - tools/3D JSON Payload/main.js
+    - tools/Asset Pipeline/main.js
+    - tools/Palette Browser/main.js
+    - tools/Performance Profiler/main.js
+    - tools/Physics Sandbox/main.js
+    - tools/Replay Visualizer/main.js
+    - tools/State Inspector/main.js
+    - tools/Tile Model Converter/main.js
+    - tools/Vector Map Editor/editor/VectorMapEditorApp.js
+  - These paths also emit visible errors on failure (`Preset load failed...`) and explicit no-default states (`Awaiting source ... No default ...`).
+- Why blocked
+  - Removing these helpers without replacing sample launch/query contract would break executable sample/tool flows.
+- Next required action
+  - New dedicated PR to replace query-driven sample preset loading with a new direct-input contract and update all sample entrypoints/tests together.
+
+Blocker 2: Extensive normalize*/infer* helpers include valid runtime behavior, not only legacy compatibility
+- Evidence
+  - `tools/shared/toolLoadDiagnostics.js` contains infer/normalize helpers used for diagnostics boundary classification.
+  - `tools/shared/platformShell.js` contains normalize utilities for URL/path/tool key sanitation and display summarization.
+  - `tools/Asset Pipeline/main.js` contains inferDomainFromCatalogKind/inferSourceToolIdForDomain used by pipeline mapping behavior.
+- Why blocked
+  - Blanket removal is high-risk and exceeds surgical cleanup scope.
+- Next required action
+  - Follow-up PR with explicit allowlist/denylist for helper families and behavioral parity tests before removal/rename.
+
+Blocker 3: `asset-pipeline-tooling` identifier contains stale substring but represents an internal schema token, not a tool id
+- Evidence
+  - tools/Asset Pipeline/main.js: `schema: "html-js-gaming.asset-pipeline-tooling"`
+  - tools/shared/pipeline/assetPipelineTooling.js: `ASSET_PIPELINE_TOOLING_SCHEMA = "html-js-gaming.asset-pipeline-tooling"`
+- Why blocked
+  - Renaming this token without a coordinated schema/version migration can break downstream tooling outputs.
+- Next required action
+  - Dedicated nomenclature migration PR for pipeline output schema ids, with versioning/migration notes and validation updates.
+
+Blocker 4: Required fixture destination preserves `palette-editor` token in path
+- Evidence
+  - tests/tools/ToolWorkspaceSchemaManifestBoundaries.test.mjs references:
+    - tests/fixtures/tool-schemas/palette-editor/tool.schema.json
+- Why blocked
+  - BUILD requires this exact destination path for relocated fixture files.
+- Next required action
+  - If canonical naming must eliminate `palette-editor` token entirely, update BUILD contract/tests/fixture destination in a dedicated PR.
+
+Files searched
+- tools/shared/platformShell.js
+- tools/shared/toolLoadDiagnostics.js
+- tools/shared/schemaOnlyToolPresetValidation.js
+- tools/3D Asset Viewer/main.js
+- tools/3D Camera Path Editor/main.js
+- tools/3D JSON Payload/main.js
+- tools/Asset Pipeline/main.js
+- tools/Palette Browser/main.js
+- tools/Performance Profiler/main.js
+- tools/Physics Sandbox/main.js
+- tools/Replay Visualizer/main.js
+- tools/State Inspector/main.js
+- tools/Tile Model Converter/main.js
+- tools/Vector Map Editor/editor/VectorMapEditorApp.js
+- tests/tools/ToolWorkspaceSchemaManifestBoundaries.test.mjs
+
+Matches found
+- Multiple `tryLoadPresetFromQuery` and `buildPresetLoadedStatus` matches in tool entrypoints.
+- Multiple `normalize*`/`infer*` matches in shared and tool files as noted above.
+
+Files changed (for blocker handling)
+- None directly for blocker-only items.
+
+Skipped items
+- Broad helper removal and nomenclature token migration.
+- Exact reason: requires cross-file contract migration and test updates beyond surgical scope.
+
+Validation command used
+- rg scans for helper/name patterns
+- targeted runtime/schema checks in other reports
+
+Validation result
+- Blockers documented with file/path evidence and explicit next action.
+
+Remaining blockers
+- Blockers 1 through 4 remain open.

docs/dev/reports/direct_json_validation_11_112.txt

@@ -0,0 +1 @@
+Generated by Codex during PR 11.112 execution.

docs/dev/reports/json_schema_repair_loop_11_113.txt

@@ -0,0 +1,95 @@
+PR 11.113 JSON/Schema Repair Loop Evidence
+Date: 2026-04-30
+
+Files searched
+- tests/tools/ToolWorkspaceSchemaManifestBoundaries.test.mjs
+- tools/shared/toolLoadDiagnostics.js
+- tools/shared/schemaOnlyToolPresetValidation.js
+- samples/metadata/samples.index.metadata.json
+- samples/phase-02/0204/*
+- samples/phase-14/1413/*
+- src tools samples games tests scripts (pattern scans)
+
+Issue A: Test-only tool schema relocation
+Search scope + pattern
+- Scope: tools/* and tests/*
+- Pattern: tools/(palette-editor|vector-asset-studio|vector-map-editor)/tool.schema.json + tests/fixtures path
+Matches found
+- Runtime paths: absent
+- Fixture paths: present in `tests/tools/ToolWorkspaceSchemaManifestBoundaries.test.mjs`
+Fix applied
+- None in this PR (already fixed in previous pass).
+Validation
+- Runtime files missing:
+  - tools/palette-editor/tool.schema.json
+  - tools/vector-asset-studio/tool.schema.json
+  - tools/vector-map-editor/tool.schema.json
+- Fixture files exist:
+  - tests/fixtures/tool-schemas/palette-editor/tool.schema.json
+  - tests/fixtures/tool-schemas/vector-asset-studio/tool.schema.json
+  - tests/fixtures/tool-schemas/vector-map-editor/tool.schema.json
+- Test run: PASS ToolWorkspaceSchemaManifestBoundaries
+
+Issue B: Schema-only runtime validation still enforced
+Search scope + pattern
+- Scope: tools/shared/toolLoadDiagnostics.js, tools/shared/schemaOnlyToolPresetValidation.js
+- Pattern: enforceToolPresetSchemaOnlyContract|Input validation failed
+Matches found
+- `toolLoadDiagnostics.js` imports and calls `enforceToolPresetSchemaOnlyContract` (loaded boundary)
+- `schemaOnlyToolPresetValidation.js` emits detailed visible error text beginning with `Input validation failed...`
+Fix applied
+- None required in this PR.
+Validation result
+- Existing schema-only enforcement path is present.
+
+Issue C: Canonical naming/stale naming check (runtime/source scope)
+Search scope + pattern
+- Scope: src tools samples games tests scripts (excluding docs/reports)
+- Pattern: asset-pipeline-tool|3d-json-payload-normalizer|Asset Pipeline Tool|palette-editor
+Matches found
+- No runtime/source hits for `asset-pipeline-tool`, `3d-json-payload-normalizer`, `Asset Pipeline Tool`
+- One hit for `palette-editor` at required fixture path in test file
+Fix applied
+- None required for runtime ids.
+Skipped items
+- `palette-editor` fixture path retained because BUILD explicitly requires destination `tests/fixtures/tool-schemas/palette-editor/tool.schema.json`.
+
+Issue D: Sample/tool truthfulness (audit-confirmed missing references)
+Search scope + pattern
+- Scope: samples/** and samples metadata
+- Command: audit-sample-json-js-references.ps1 -Details
+Matches found (before)
+- Missing reference files:
+  - samples/phase-02/0204/sample.0204.3d-asset-viewer.json
+  - samples/phase-14/1413/sample.1413.3d-asset-viewer.json
+  - samples/phase-14/1413/sample.1413.asset-browser.json
+Fix applied
+- Deleted all three dead JSON files.
+- Updated sample 1413 metadata block to remove stale 3d-asset-viewer tool hint/preset path.
+Validation (after)
+- Audit result: scanned=63 referenced=63 missing=0
+- Deleted file references no longer found by targeted `rg` checks.
+- Changed JSON parses: `samples/metadata/samples.index.metadata.json` -> JSON_OK
+
+Files changed
+- samples/metadata/samples.index.metadata.json
+- samples/phase-02/0204/sample.0204.3d-asset-viewer.json (deleted)
+- samples/phase-14/1413/sample.1413.3d-asset-viewer.json (deleted)
+- samples/phase-14/1413/sample.1413.asset-browser.json (deleted)
+- docs/dev/reports/sample_json_js_reference_audit.csv (regenerated)
+
+Skipped items + exact reason
+- No broad schema file rewrites were made because this PR did not expose schema parse/validation failures in changed files.
+- No broad tool-id migration was made because runtime/source stale-id scans were already clean in scoped paths.
+
+Validation commands used
+- powershell -ExecutionPolicy Bypass -File .\scripts\PS\audit-sample-json-js-references.ps1 -Details
+- node --input-type=module -e "import { run } from './tests/tools/ToolWorkspaceSchemaManifestBoundaries.test.mjs'; await run(); console.log('PASS ToolWorkspaceSchemaManifestBoundaries');"
+- node JSON parse check for samples/metadata/samples.index.metadata.json
+- rg fixed-string checks for deleted JSON paths
+
+Validation result
+- PASS (targeted).
+
+Remaining blockers
+- See blockers_11_113.txt (shared helper naming/flow items needing dedicated follow-up).

docs/dev/reports/normalize_path_removal_11_112.txt

@@ -0,0 +1 @@
+Generated by Codex during PR 11.112 execution.

docs/dev/reports/preset_path_removal_11_112.txt

@@ -0,0 +1 @@
+Generated by Codex during PR 11.112 execution.