Wire Object Vector Studio V2 into Workspace Manager V2 and add Asteroids object vector assets - PR_26132_010-object-vector-workspace-asteroids-assets

Author: DavidQ

docs/dev/reports/playwright_v8_coverage.txt

@@ -20,9 +20,11 @@ Exercised tool entry points detected:
 (0%) Workspace Manager - not exercised by this Playwright run
 
 Changed runtime JS files covered:
-(80%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 70/70; executed functions 4/5
-(90%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 1592/1592; executed functions 170/189
+(86%) tools/workspace-manager-v2/js/WorkspaceManagerV2App.js - executed lines 963/963; executed functions 42/49
+(91%) tools/workspace-manager-v2/js/services/WorkspaceManagerV2ContextService.js - executed lines 1598/1598; executed functions 145/159
 (92%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - executed lines 286/286; executed functions 33/36
+(92%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 1595/1595; executed functions 174/189
+(93%) tools/workspace-manager-v2/js/controls/ToolTilesControl.js - executed lines 137/137; executed functions 14/15
 
 Files with executed line/function counts where available:
 (2%) src/engine/input/ActionInputService.js - executed lines 397/397; executed functions 1/51
@@ -46,7 +48,6 @@ Files with executed line/function counts where available:
 (14%) src/engine/scene/TransitionScene.js - executed lines 58/58; executed functions 1/7
 (15%) games/Asteroids/game/AsteroidsAttractAdapter.js - executed lines 229/229; executed functions 3/20
 (15%) src/engine/audio/MediaTrackService.js - executed lines 139/139; executed functions 2/13
-(16%) samples/shared/sampleDetailPageEnhancement.js - executed lines 471/471; executed functions 5/32
 (16%) src/engine/audio/AudioService.js - executed lines 258/258; executed functions 4/25
 (17%) src/engine/camera/Camera2D.js - executed lines 44/44; executed functions 1/6
 (17%) src/engine/collision/polygon.js - executed lines 73/73; executed functions 1/6
@@ -93,7 +94,6 @@ Files with executed line/function counts where available:
 (33%) src/engine/persistence/WorldSerializer.js - executed lines 12/12; executed functions 1/3
 (33%) src/engine/runtime/MobileRuntimeTweaks.js - executed lines 21/21; executed functions 1/3
 (33%) src/engine/scene/SceneTransitionController.js - executed lines 22/22; executed functions 1/3
-(33%) src/shared/number/numberUtils.js - executed lines 14/14; executed functions 1/3
 (33%) tools/shared/projectSystemValueUtils.js - executed lines 9/9; executed functions 1/3
 (33%) tools/shared/uiSafeUtils.js - executed lines 32/32; executed functions 2/6
 (36%) games/Asteroids/index.js - executed lines 179/179; executed functions 4/11
@@ -145,6 +145,7 @@ Files with executed line/function counts where available:
 (64%) games/Pong/game/PongScene.js - executed lines 521/521; executed functions 21/33
 (65%) tools/palette-manager-v2/controls/SourcePaletteBrowserControl.js - executed lines 121/121; executed functions 15/23
 (67%) games/Asteroids/utils/math.js - executed lines 14/14; executed functions 2/3
+(67%) src/shared/number/numberUtils.js - executed lines 14/14; executed functions 2/3
 (67%) tools/asset-manager-v2/js/controls/AssetManagerShellControl.js - executed lines 100/100; executed functions 8/12
 (67%) tools/palette-manager-v2/modules/paletteUtils.js - executed lines 41/41; executed functions 6/9
 (67%) tools/world-vector-studio-v2/js/controls/ToolStarterShellControl.js - executed lines 111/111; executed functions 8/12
@@ -180,6 +181,7 @@ Files with executed line/function counts where available:
 (80%) tools/preview-generator-v2/PreviewGeneratorV2Logger.js - executed lines 19/19; executed functions 4/5
 (80%) tools/workspace-manager-v2/js/controls/AccordionSection.js - executed lines 27/27; executed functions 4/5
 (80%) tools/world-vector-studio-v2/js/controls/AccordionSection.js - executed lines 27/27; executed functions 4/5
+(81%) samples/shared/sampleDetailPageEnhancement.js - executed lines 471/471; executed functions 35/43
 (82%) src/engine/rendering/CanvasRenderer.js - executed lines 100/100; executed functions 9/11
 (82%) tools/session-inspector-v2/js/controls/EntryListControl.js - executed lines 59/59; executed functions 9/11
 (83%) tools/palette-manager-v2/main.js - executed lines 227/227; executed functions 15/18
@@ -188,29 +190,29 @@ Files with executed line/function counts where available:
 (86%) games/shared/workspaceGameAssetCatalog.js - executed lines 253/253; executed functions 18/21
 (86%) tools/asset-manager-v2/js/controls/AssetCatalogControl.js - executed lines 134/134; executed functions 12/14
 (86%) tools/workspace-manager-v2/js/controls/RepoDestinationControl.js - executed lines 25/25; executed functions 6/7
-(86%) tools/workspace-manager-v2/js/WorkspaceManagerV2App.js - executed lines 945/945; executed functions 42/49
+(86%) tools/workspace-manager-v2/js/WorkspaceManagerV2App.js - executed lines 963/963; executed functions 42/49
 (88%) games/Pong/game/PongInputController.js - executed lines 77/77; executed functions 7/8
 (88%) tools/preview-generator-v2/PreviewGeneratorV2App.js - executed lines 1498/1498; executed functions 107/121
 (88%) tools/shared/toolLaunchSSoTData.js - executed lines 112/112; executed functions 14/16
 (88%) tools/text2speech-V2/js/controls/TextInputControl.js - executed lines 24/24; executed functions 7/8
 (88%) tools/world-vector-studio-v2/js/controls/SourceInputControl.js - executed lines 33/33; executed functions 7/8
 (89%) tools/asset-manager-v2/js/services/AssetSchemaValidator.js - executed lines 295/295; executed functions 25/28
 (89%) tools/preview-generator-v2/controls/StatusLogControl.js - executed lines 32/32; executed functions 8/9
-(90%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 1592/1592; executed functions 170/189
 (90%) tools/palette-manager-v2/modules/PaletteValidationService.js - executed lines 88/88; executed functions 9/10
 (90%) tools/text2speech-V2/js/controls/ActionNavControl.js - executed lines 117/117; executed functions 19/21
 (90%) tools/text2speech-V2/js/TextToSpeechToolApp.js - executed lines 807/807; executed functions 62/69
 (91%) games/Asteroids/entities/Asteroid.js - executed lines 72/72; executed functions 10/11
 (91%) tools/object-vector-studio-v2/js/controls/ActionNavControl.js - executed lines 75/75; executed functions 10/11
 (91%) tools/toolRegistry.js - executed lines 526/526; executed functions 10/11
-(91%) tools/workspace-manager-v2/js/services/WorkspaceManagerV2ContextService.js - executed lines 1583/1583; executed functions 145/159
+(91%) tools/workspace-manager-v2/js/services/WorkspaceManagerV2ContextService.js - executed lines 1598/1598; executed functions 145/159
 (92%) tools/object-vector-studio-v2/js/controls/ToolStarterShellControl.js - executed lines 112/112; executed functions 11/12
 (92%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - executed lines 286/286; executed functions 33/36
+(92%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 1595/1595; executed functions 174/189
 (93%) tools/asset-manager-v2/js/services/WorkspaceBridge.js - executed lines 305/305; executed functions 25/27
 (93%) tools/session-inspector-v2/js/SessionInspectorV2App.js - executed lines 337/337; executed functions 42/45
 (93%) tools/text2speech-V2/js/controls/QueueControl.js - executed lines 122/122; executed functions 26/28
 (93%) tools/workspace-manager-v2/js/controls/GameSelectorControl.js - executed lines 59/59; executed functions 13/14
-(93%) tools/workspace-manager-v2/js/controls/ToolTilesControl.js - executed lines 130/130; executed functions 14/15
+(93%) tools/workspace-manager-v2/js/controls/ToolTilesControl.js - executed lines 137/137; executed functions 14/15
 (94%) games/shared/workspaceGameMetadataHydrator.js - executed lines 106/106; executed functions 16/17
 (94%) tools/common/PaletteSortService.js - executed lines 103/103; executed functions 17/18
 (95%) tools/session-inspector-v2/js/services/SessionInspectorV2StorageService.js - executed lines 142/142; executed functions 18/19
@@ -294,6 +296,8 @@ Uncovered or low-coverage changed JS files:
 Changed JS files considered:
 (0%) tests/playwright/tools/WorkspaceManagerV2.spec.mjs - changed JS file not collected as browser runtime coverage
 (0%) tools/object-vector-studio-v2/tests/playwright/FirstClassToolStarter.spec.mjs - changed JS file not collected as browser runtime coverage
-(80%) tools/object-vector-studio-v2/js/bootstrap.js - changed JS file with browser V8 coverage
-(90%) tools/object-vector-studio-v2/js/ToolStarterApp.js - changed JS file with browser V8 coverage
+(86%) tools/workspace-manager-v2/js/WorkspaceManagerV2App.js - changed JS file with browser V8 coverage
+(91%) tools/workspace-manager-v2/js/services/WorkspaceManagerV2ContextService.js - changed JS file with browser V8 coverage
 (92%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - changed JS file with browser V8 coverage
+(92%) tools/object-vector-studio-v2/js/ToolStarterApp.js - changed JS file with browser V8 coverage
+(93%) tools/workspace-manager-v2/js/controls/ToolTilesControl.js - changed JS file with browser V8 coverage

docs/pr/PR_26132_010-object-vector-workspace-asteroids-assets.md

@@ -0,0 +1,100 @@
+# PR_26132_010-object-vector-workspace-asteroids-assets
+
+## Purpose
+
+Wire Object Vector Studio V2 into Workspace Manager V2 launch/session flow and seed Asteroids with schema-valid object vector assets.
+
+## Scope
+
+- Added Object Vector Studio V2 to Workspace Manager V2 launchable tool tiles.
+- Added Object Vector Studio V2 schema validation to Workspace Manager V2 tool payload validation.
+- Added Asteroids `root.tools.object-vector-studio-v2` durable object asset data for:
+  - Asteroids Ship
+  - Large Asteroid
+  - Medium Asteroid
+  - Small Asteroid
+  - Large UFO
+  - Small UFO
+- Kept palette data out of the Object Vector Studio V2 object payload.
+- Prefer the active workspace palette session on workspace launch before runtime palette cache.
+- Added tile detail/count display for Object Vector Studio V2 object assets.
+- Added workspace launch logging that names the object payload source and separate palette session source.
+
+## Validation
+
+Commands run:
+
+```powershell
+node -e "const fs=require('fs'); for (const p of ['games/Asteroids/game.manifest.json','tools/schemas/workspace.manifest.schema.json']) { JSON.parse(fs.readFileSync(p,'utf8').replace(/^\uFEFF/,'')); } console.log('json ok')"
+@'
+const fs = require('fs');
+const path = require('path');
+const { pathToFileURL } = require('url');
+(async () => {
+  const root = process.cwd();
+  const { ObjectVectorStudioV2SchemaService } = await import(pathToFileURL(path.join(root, 'tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js')).href);
+  const service = new ObjectVectorStudioV2SchemaService({
+    fetchRef: async (url) => ({
+      ok: true,
+      json: async () => JSON.parse(fs.readFileSync(new URL(url), 'utf8').replace(/^\uFEFF/, ''))
+    })
+  });
+  await service.loadSchema();
+  const manifest = JSON.parse(fs.readFileSync('games/Asteroids/game.manifest.json', 'utf8').replace(/^\uFEFF/, ''));
+  const result = service.validatePayload(manifest.game.workspace.tools['object-vector-studio-v2']);
+  console.log(JSON.stringify({ ok: result.ok, errors: result.errors, objects: result.payload?.objects?.length }, null, 2));
+})();
+'@ | node -
+npm run test:workspace-v2
+```
+
+Result:
+
+```text
+39 passed
+```
+
+## Playwright Coverage
+
+Workspace Manager V2 coverage now verifies:
+
+- Object Vector Studio V2 is listed as a Workspace Manager V2 tile.
+- Asteroids enables the Object Vector Studio V2 tile after repo/game selection.
+- Workspace Manager V2 launches Object Vector Studio V2 with `launch=workspace`, `fromTool=workspace-manager-v2`, and `hostContextId`.
+- Asteroids manifest/session exposes ship, asteroid, and UFO object vector assets.
+- Object Vector Studio V2 loads palette data from `workspace.tools.palette-manager-v2.data`, not the object schema payload.
+- Object Vector Studio V2 object JSON does not include `palette`.
+
+## Coverage Report
+
+Runtime JavaScript changed, so `docs/dev/reports/playwright_v8_coverage.txt` was refreshed from the Workspace Manager V2 Playwright run.
+
+## Known Issue
+
+All games fullscreen currently fullscreen the page but not the game canvas. This PR documents the issue only and does not change fullscreen game behavior.
+
+Recommended follow-up PR:
+
+```text
+PR_26132_FOLLOWUP-fullscreen-canvas-behavior
+- Audit shared game fullscreen behavior.
+- Ensure each game fullscreen action expands the canvas/render surface, not only the page shell.
+- Add targeted Playwright coverage for canvas dimensions before/after fullscreen.
+```
+
+## Full Samples Smoke Test
+
+Skipped. This PR is limited to Workspace Manager V2 Object Vector Studio V2 launch wiring, Asteroids object-vector payload data, and targeted Workspace Manager V2 Playwright coverage.
+
+## Out Of Scope
+
+- World Vector Studio V2 changes.
+- Deprecated Primitive Skin Editor or Vector Map Editor deletion/rename.
+- Fullscreen canvas behavior fix.
+- Full samples smoke test.
+
+## Commit Comment
+
+```text
+PR_26132_010 wires Object Vector Studio V2 into Workspace Manager V2, adds strict Asteroids object vector assets for ship/asteroids/UFOs without embedded palette data, validates workspace launch/session palette sourcing, and documents the fullscreen canvas follow-up.
+```