|
1 | | -# Codex Commands - PR_26126_029-preview-generator-v2-fullscreen-native-size |
| 1 | +# Codex Commands - PR_26126_030-preview-generator-v2-status-header-and-fullscreen-css-fix |
2 | 2 |
|
3 | 3 | ```bash |
4 | | -codex run "Create PR_26126_029-preview-generator-v2-fullscreen-native-size. Fix Preview Generator V2 fullscreen capture wording and behavior only. Preserve existing generation behavior. Full Screen capture must not require 1600x900; use the actual available fullscreen/browser viewport size. Update Capture mode label from \"Full Screen (1600x900 HTML Page)\" to \"Full Screen\". Remove hardcoded 1600x900 wording from UI, logs, errors, and tests. If fullscreen capture fails, report \"Full Screen capture failed\" with the underlying error, not \"failed at 1600x900\". Preserve Canvas Only behavior. Do not modify samples. Do not add schema. Produce review artifacts." |
| 4 | +codex run "Create PR_26126_030-preview-generator-v2-status-header-and-fullscreen-css-fix. Fix Preview Generator V2 UI/capture only. Preserve existing generation behavior. Status must not render accordion affordances; remove the \"+\" from the Status header. Keep Clear on the same line as Status, but render it as a normal button, not accordion UI. Fix Full Screen capture failure caused by unsupported CSS color(...) values by sanitizing/normalizing unsupported CSS color functions only for the cloned capture DOM before html2canvas runs. Do not change live page styling. Do not fall back silently. Full Screen should succeed when the only blocker is unsupported CSS color(...). Preserve Canvas Only behavior. Do not modify samples. Do not add schema. Produce review artifacts." |
5 | 5 | ``` |
6 | 6 |
|
7 | 7 | ## Validation Commands |
8 | 8 |
|
9 | 9 | ```bash |
10 | | -rg -n "1600|900|1600x900|fullscreen1600|Full Screen \\(|failed at" tools/preview-generator-v2/index.html |
11 | | -rg -n "Full Screen capture failed|Full Screen|Canvas Only|fullscreen|getAvailableFullScreenCaptureSize|extractFullPageSvg" tools/preview-generator-v2/index.html |
| 10 | +rg -n "statusAccordion|Status|accordion-v2__icon|preview-generator-v2__status-header-row|preview-generator-v2__status-content|replaceUnsupportedColorFunctions|sanitizeComputedColorStyles|sanitizeClonedToolDocument|onclone" tools/preview-generator-v2/index.html |
| 11 | +node -e "const fs=require('fs');const html=fs.readFileSync('tools/preview-generator-v2/index.html','utf8');const status=html.match(/<section id=\"statusAccordion\"[\\s\\S]*?<\\/section>/)?.[0]||'';if(!status)throw new Error('Missing status section');if(status.includes('accordion-v2__icon')||status.includes('accordion-v2__header'))throw new Error('Status still has accordion affordance markup');console.log('status section has no accordion affordance');" |
12 | 12 | node -e "const fs=require('fs');const html=fs.readFileSync('tools/preview-generator-v2/index.html','utf8');const scripts=[...html.matchAll(/<script(?![^>]*\\bsrc=)[^>]*>([\\s\\S]*?)<\\/script>/gi)].map(m=>m[1]);scripts.forEach((script,i)=>{new Function(script);console.log('inline script '+(i+1)+' syntax ok');});" |
13 | 13 | git diff --check |
14 | | -git diff --name-only -- tools/preview-generator-v2/index.html docs/dev/codex_commands.md docs/dev/commit_comment.txt docs/dev/reports/codex_changed_files.txt docs/dev/reports/codex_review.diff |
15 | 14 | git diff --name-only -- '*.json' tools/shared tools/schemas start_of_day |
16 | 15 | npm run test:workspace-v2 |
17 | 16 | npm test |
18 | 17 | ``` |
19 | 18 |
|
20 | 19 | ## Playwright |
21 | 20 |
|
22 | | -No Playwright test was added. This PR changes Preview Generator V2 fullscreen capture wording and capture sizing only. `npm run test:workspace-v2` is attempted as the standard command if available. |
| 21 | +No Playwright test was added. This PR changes Preview Generator V2 status header markup and cloned-DOM fullscreen capture sanitization only. `npm run test:workspace-v2` is attempted as the standard command if available. |
23 | 22 |
|
24 | 23 | ## Test Notes |
25 | 24 |
|
26 | 25 | `npm run test:workspace-v2` is not defined in the current `package.json`. `npm test` was attempted and still fails in the existing shared extraction guard baseline, outside this PR scope. |
27 | 26 |
|
28 | 27 | ## Manual Test |
29 | 28 |
|
30 | | -Use Preview Generator V2 with Canvas Only to confirm existing canvas capture still works. Use Full Screen on a target with unsupported fullscreen capture CSS and confirm it logs `Full Screen capture failed: <underlying error>` without fallback or fixed-size wording. |
| 29 | +Open Preview Generator V2 and confirm Status has no accordion plus/minus affordance, with Clear on the same line. Run Full Screen capture against a page whose only blocker is CSS `color(...)` and confirm it no longer fails for that parser error. Recheck Canvas Only capture still works. |
0 commit comments