Skip to content

Commit 98a737b

Browse files
author
DavidQ
committed
Expand MASTER_ROADMAP_STYLE with the missing style-system guardrails and implement the first real /index.html migration slice.
Add the missing roadmap items so they are not forgotten. Reset /index.html onto the new Toolbox Aid-derived theme foundation. Keep the implementation narrow, testable, and free of embedded styling. PR: BUILD_PR_STYLE_02_INDEX_IMPLEMENTATION_AND_ROADMAP_EXPANSION & MODEL: GPT-5.4-codex REASONING: high COMMAND: Create BUILD_PR_STYLE_03_SAMPLES_INDEX_RESET Tasks: 1. Reset `/samples/index.html` to new theme system 2. Use shared header from src/engine/theme/toolboxaid-header.html 3. Remove all embedded CSS and JS styling 4. Match structure and spacing of `/index.html` 5. Keep implementation minimal and testable Output: <project folder>/tmp/BUILD_PR_STYLE_03_SAMPLES_INDEX_RESET.zip
1 parent 986ef37 commit 98a737b

15 files changed

Lines changed: 495 additions & 2032 deletions

docs/dev/codex_commands.md

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,15 @@
1-
MODEL: GPT-5.3-codex
2-
REASONING: medium
1+
MODEL: GPT-5.4-codex
2+
REASONING: high
33

44
COMMAND:
5-
- Implement validation scan across samples
6-
- Report any fullscreen usage outside sample 0713
7-
- Verify 0713 scaling behavior
8-
- No engine changes
5+
Create BUILD_PR_STYLE_03_SAMPLES_INDEX_RESET
6+
7+
Tasks:
8+
1. Reset `/samples/index.html` to new theme system
9+
2. Use shared header from src/engine/theme/toolboxaid-header.html
10+
3. Remove all embedded CSS and JS styling
11+
4. Match structure and spacing of `/index.html`
12+
5. Keep implementation minimal and testable
13+
14+
Output:
15+
<project folder>/tmp/BUILD_PR_STYLE_03_SAMPLES_INDEX_RESET.zip
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
Style roadmap expansion summary
2+
3+
Added tracking for:
4+
- font baseline policy
5+
- spacing scale policy
6+
- container-width vs full-width policy
7+
- header CSS dependency extraction
8+
- compact tool-header evaluation
9+
- shared page shell standard
10+
- collapsible structure naming
11+
- host strategy clarity
12+
- hover/focus/active state standardization
13+
- no-legacy-dependency verification
14+
- minimal-JS policy and responsive baseline
15+
16+
Execution slice:
17+
- implement /index.html only

docs/dev/roadmaps/MASTER_ROADMAP_STYLE.md

Lines changed: 88 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ Track the style-system migration for HTML-JavaScript-Gaming using Toolbox Aid as
1515
- No style strings injected from JS.
1616
- Shared theme CSS lives under `src/engine/theme/`.
1717
- Theme does not move into `src/engine/ui/`.
18+
- No deletes from this roadmap during style migration planning; only additive roadmap updates unless explicit closeout status changes are earned.
1819

1920
## Folder Responsibilities
2021
### src/engine/theme/
@@ -59,6 +60,9 @@ Behavior only:
5960
- fixed right column
6061
- only center grows/shrinks
6162
- Minimal JS for HTML pages.
63+
- Normal content pages use a centered content-width policy.
64+
- Tool pages use a full-width policy.
65+
- Header area may gain a compact mode for tool pages if needed after validation, but only as an explicit tracked slice.
6266

6367
## UX Clarification
6468
### Tool launch labels
@@ -85,23 +89,29 @@ This explanation should be kept visible in related UI/help text so launch choice
8589
- border radius
8690
- shadows
8791
- transition timings
92+
- content widths
93+
- rail widths for tool layouts
8894
[ ] Base layout primitives:
8995
- page shell
9096
- content container
9197
- full-width section
9298
- intro/title block
9399
- nav row
100+
- fixed-rail / fluid-center tool shell
94101
[ ] Document which live Toolbox Aid behaviors are intentionally carried forward.
95102
[ ] Do not pull from existing project styling.
96103

97104
### A2. Establish shared file layout
98105
[ ] Create/confirm:
99106
- `src/engine/theme/main.css`
100-
- `src/engine/theme/header.css` or fold into main if still clean
107+
- `src/engine/theme/header.css`
108+
- `src/engine/theme/nav.css`
109+
- `src/engine/theme/layout.css`
101110
- `src/engine/theme/accordion.css`
102111
- `src/engine/theme/tools.css`
103112
- `src/engine/theme/games.css`
104113
- `src/engine/theme/samples.css`
114+
- `src/engine/theme/pages.css`
105115
[ ] Keep `main.css` foundational, not a dumping ground.
106116

107117
### A3. Shared selector hygiene
@@ -110,6 +120,13 @@ This explanation should be kept visible in related UI/help text so launch choice
110120
[ ] Remove embedded styling from migrated pages only.
111121
[ ] Ban new embedded styling in HTML and JS.
112122

123+
### A4. Theme baseline details
124+
[ ] Define font baseline and font stack policy.
125+
[ ] Define spacing scale and usage policy.
126+
[ ] Define container-width policy for content pages.
127+
[ ] Define full-width policy for tools.
128+
[ ] Define shadow/border/radius policy so ad hoc visual drift does not return.
129+
113130
---
114131

115132
## Track B — Shared Header System
@@ -127,6 +144,7 @@ This explanation should be kept visible in related UI/help text so launch choice
127144

128145
### B2. Shared header assets and styling
129146
[ ] Pull the required Toolbox Aid CSS needed to reproduce the header look.
147+
[ ] Extract the minimum required CSS for correct rendering; do not rely on unrelated project CSS.
130148
[ ] Keep the header image behavior:
131149
- full-width feel
132150
- maintain aspect ratio
@@ -137,13 +155,18 @@ This explanation should be kept visible in related UI/help text so launch choice
137155
- nav row
138156
- social area if retained
139157
[ ] Preserve the menu hover line effect from Toolbox Aid baseline.
158+
[ ] Validate the header against missing global dependencies such as resets, fonts, spacing, and wrappers.
140159

141160
### B3. Header loading
142161
[ ] Provide one shared import path.
143162
[ ] Avoid duplicating header markup across pages.
144163
[ ] Minimize JS required to place the shared header into HTML pages.
145164
[ ] Keep HTML-page JS minimal and boring.
146165

166+
### B4. Header modes
167+
[ ] Evaluate whether tools need a compact header mode after the main entry pages land.
168+
[ ] If needed, implement compact mode as a tracked, explicit slice rather than as ad hoc page-specific overrides.
169+
147170
---
148171

149172
## Track C — Main Entry Pages
@@ -157,6 +180,7 @@ This explanation should be kept visible in related UI/help text so launch choice
157180
[ ] Validate spacing consistency.
158181
[ ] Validate nav behavior.
159182
[ ] Validate responsive behavior.
183+
[ ] Validate that `/index.html` uses no embedded styling and no JS-driven styling.
160184

161185
### C2. Reset `/samples/index.html`
162186
[ ] Apply same shell and shared header.
@@ -173,6 +197,14 @@ This explanation should be kept visible in related UI/help text so launch choice
173197
[ ] Keep page visually very close to `/index.html`.
174198
[ ] Use `tools.css` only for content-specific differences.
175199

200+
### C5. Shared page-shell standard
201+
[ ] Standardize all four main pages around:
202+
- shared header
203+
- shared intro/title area
204+
- shared content shell
205+
- shared footer policy if footer is used later
206+
[ ] Avoid page-by-page shell drift.
207+
176208
---
177209

178210
## Track D — Collapsible Pattern
@@ -187,6 +219,14 @@ This explanation should be kept visible in related UI/help text so launch choice
187219
[ ] Add minimal JS only if needed for accessibility or state persistence.
188220
[ ] Use for shared header/page intro compaction where appropriate.
189221

222+
### D3. Collapsible structure
223+
[ ] Standardize collapsible naming:
224+
- `.is-collapsible`
225+
- `.is-collapsible__summary`
226+
- `.is-collapsible__content`
227+
- `.is-collapsible--collapsed`
228+
[ ] Avoid vague state naming.
229+
190230
---
191231

192232
## Track E — Tool Shell UX
@@ -209,6 +249,10 @@ This explanation should be kept visible in related UI/help text so launch choice
209249
- Open Tool = launch the tool directly/standalone
210250
- Open In Host = launch the same tool inside a shared host shell/container
211251

252+
### E4. Host strategy clarity
253+
[ ] Decide whether both launch modes remain permanent, get relabeled later, or eventually converge.
254+
[ ] Keep the current explanation visible until that decision is made.
255+
212256
---
213257

214258
## Track F — Spacing, Typography, and Consistency
@@ -236,6 +280,12 @@ This explanation should be kept visible in related UI/help text so launch choice
236280
- helper text
237281
- tool labels
238282

283+
### F4. Hover, focus, and active states
284+
[ ] Standardize hover behavior.
285+
[ ] Standardize focus-visible behavior.
286+
[ ] Standardize active/current-nav states.
287+
[ ] Preserve Toolbox Aid-style hover line treatment where adopted.
288+
239289
---
240290

241291
## Track G — Migration Rules
@@ -255,6 +305,27 @@ This explanation should be kept visible in related UI/help text so launch choice
255305
[ ] Delete embedded `<style>` only after migrated coverage is validated.
256306
[ ] Delete JS styling only after migrated coverage is validated.
257307

308+
### G4. No-legacy-dependency verification
309+
[ ] For each migrated page, verify that no old project-local style dependency remains.
310+
[ ] Record what was removed and what replaced it.
311+
312+
---
313+
314+
## Track H — Accessibility and Interaction Baseline
315+
316+
### H1. Shared interaction states
317+
[ ] Ensure nav, buttons, and accordions have keyboard-usable states.
318+
[ ] Keep focus-visible styling consistent.
319+
320+
### H2. Minimal-JS HTML policy
321+
[ ] Document what JS is allowed on plain HTML pages.
322+
[ ] Keep header loading and collapsible behavior minimal and auditable.
323+
324+
### H3. Responsive baseline
325+
[ ] Validate common desktop widths first.
326+
[ ] Validate narrower widths for page-shell wrapping and nav behavior.
327+
[ ] Prevent fixed rails from collapsing the center below usable limits.
328+
258329
---
259330

260331
## Suggested Execution Order
@@ -265,4 +336,19 @@ This explanation should be kept visible in related UI/help text so launch choice
265336
[ ] STYLE_05 — Add `.is-collapsible` shared accordion behavior.
266337
[ ] STYLE_06 — Establish shared tool shell and migrate one tool.
267338
[ ] STYLE_07 — Clarify tool launch labels/help text.
268-
[ ] STYLE_08+ — Continue tool UX migration tool-by-tool.
339+
[ ] STYLE_08 — Evaluate compact tool-header mode if still needed.
340+
[ ] STYLE_09+ — Continue tool UX migration tool-by-tool.
341+
342+
---
343+
344+
## STYLE_02 Additive Expansion Bundle
345+
346+
The following additive requirements are explicitly tracked for STYLE_02 implementation and validation:
347+
348+
- [ ] Confirm `/index.html` imports only `src/engine/theme/main.css` for page styling.
349+
- [ ] Confirm shared header styles are resolved through theme-level imports rather than page-local overrides.
350+
- [ ] Confirm header template content changes remain limited to:
351+
- tagline = `HTML-JavaScript Gaming`
352+
- menu = Home / Games / Samples / Tools
353+
- [ ] Confirm `/index.html` contains no embedded `<style>` and no inline `style=""`.
354+
- [ ] Confirm plain-page JS remains minimal and limited to shared-header mounting.
Lines changed: 34 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,36 @@
1-
MODEL: GPT-5.3-codex
2-
REASONING: low
1+
MODEL: GPT-5.4-codex
2+
REASONING: high
33

44
COMMAND:
5-
- Maintain roadmap lock enforcement
6-
- Reject non-status changes
5+
Create BUILD_PR_STYLE_02_INDEX_IMPLEMENTATION_AND_ROADMAP_EXPANSION as one focused, testable PR.
6+
7+
Rules:
8+
- one PR purpose only
9+
- add to MASTER_ROADMAP_STYLE only; do not remove roadmap items
10+
- no big-bang migration
11+
- do not use existing HTML-JavaScript-Gaming styling as the base
12+
- derive the new style baseline from Toolbox Aid
13+
- no embedded <style> in HTML
14+
- no inline style=""
15+
- no JS-generated styling
16+
- theme stays under src/engine/theme
17+
- keep HTML-page JS minimal
18+
19+
Required work:
20+
1. Update docs/dev/roadmaps/MASTER_ROADMAP_STYLE.md with the bundled additive items.
21+
2. Create the theme foundation files under src/engine/theme:
22+
- main.css
23+
- header.css
24+
- nav.css
25+
- layout.css
26+
- pages.css
27+
- any additional theme file only if justified
28+
3. Pull the Toolbox Aid header into src/engine/theme/toolboxaid-header.html with only:
29+
- tagline changed to HTML-JavaScript Gaming
30+
- menu changed to Home / Games / Samples / Tools
31+
4. Extract the minimum required CSS so the header renders correctly without legacy dependencies.
32+
5. Reset /index.html onto the new theme and shared header.
33+
6. Remove old embedded/page-local styling dependencies from /index.html.
34+
7. Keep the implementation surgical and testable.
35+
8. Package to:
36+
<project folder>/tmp/BUILD_PR_STYLE_02_INDEX_IMPLEMENTATION_AND_ROADMAP_EXPANSION.zip
Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1-
Confirm roadmap lock enforcement.
1+
Expand MASTER_ROADMAP_STYLE with the missing style-system guardrails and implement the first real /index.html migration slice.
22

3-
No changes required. Validation-only confirmation.
3+
Add the missing roadmap items so they are not forgotten.
4+
Reset /index.html onto the new Toolbox Aid-derived theme foundation.
5+
Keep the implementation narrow, testable, and free of embedded styling.
46

5-
PR: LEVEL 24.4 ROADMAP LOCK VALIDATION
7+
PR: BUILD_PR_STYLE_02_INDEX_IMPLEMENTATION_AND_ROADMAP_EXPANSION
Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
# BUILD_PR_STYLE_02_INDEX_IMPLEMENTATION_AND_ROADMAP_EXPANSION
2+
3+
## Purpose
4+
Expand the style roadmap so no important style-system requirements are lost, and execute the next real testable slice: implement the `/index.html` migration on the new Toolbox Aid-derived theme base.
5+
6+
## Single PR Purpose
7+
Implement `/index.html` on the new shared style system and record the expanded roadmap requirements.
8+
9+
## Required Deliverables
10+
1. Update `docs/dev/roadmaps/MASTER_ROADMAP_STYLE.md` with the bundled additive expansions only.
11+
2. Add the new theme foundation files under `src/engine/theme/`.
12+
3. Add `src/engine/theme/toolboxaid-header.html` sourced from Toolbox Aid with only the approved content changes:
13+
- tagline = `HTML-JavaScript Gaming`
14+
- menu = Home / Games / Samples / Tools
15+
4. Extract the minimum required CSS for the header to render correctly without relying on legacy project CSS.
16+
5. Reset `/index.html` to use the new theme only.
17+
6. Remove any embedded styling from `/index.html`.
18+
7. Keep plain-page JS minimal.
19+
20+
## Must Not Do
21+
- do not inspect or preserve old project CSS/HTML as the styling baseline
22+
- do not migrate `/samples/index.html`, `/games/index.html`, or `/tools/index.html` in this PR
23+
- do not add inline style or JS-generated styling
24+
- do not turn `main.css` into a dumping ground
25+
26+
## Acceptance
27+
- roadmap gains the additive tracking items from this bundle
28+
- `/index.html` becomes a clean testable implementation slice
29+
- `/index.html` depends only on the new theme path
30+
- header renders from shared source
31+
- no embedded styling remains on `/index.html`
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
# BUILD_PR_STYLE_03_SAMPLES_INDEX_RESET
2+
3+
## Purpose
4+
Apply the same clean, Toolbox Aid–derived style system to `/samples/index.html` using the established `/index.html` pattern.
5+
6+
## Scope
7+
- Reset `/samples/index.html` to use shared theme only
8+
- Use shared header (no duplication)
9+
- No embedded CSS or JS styling
10+
- Match `/index.html` structure closely
11+
12+
## Rules
13+
- Do NOT reuse old classes/ids
14+
- Do NOT inspect old styling as baseline
15+
- Keep layout consistent with `/index.html`
16+
- Use only theme files under `src/engine/theme/`
17+
18+
## Acceptance
19+
- `/samples/index.html` visually aligns with `/index.html`
20+
- No embedded styles exist
21+
- Header loads from shared source
22+
- Clean, testable page

index.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
<title>HTML JavaScript Gaming</title>
1313
<link rel="icon" href="favicon.ico" />
1414
<link rel="stylesheet" href="src/engine/theme/main.css" />
15-
<link rel="stylesheet" href="src/engine/theme/toolboxaid-header.css" />
1615
</head>
1716
<body>
1817
<main class="page-shell">

0 commit comments

Comments
 (0)