Clarify Workspace V2 toolState lifecycle with named drafts, promotion move semantics, and copy-back from published tools - PR_26124_018-workspace-toolstate-lifecycle-ux

Author: DavidQ

docs/dev/codex_commands.md

@@ -341,3 +341,10 @@ PR_26124_018-clarify-tools-vs-toolstate-ux
 ```bash
 npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_26124_018-clarify-tools-vs-toolstate-ux."
 ```
+
+---
+PR_26124_018-workspace-toolstate-lifecycle-ux
+
+```bash
+npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_26124_018-workspace-toolstate-lifecycle-ux."
+```

docs/dev/commit_comment.txt

@@ -1 +1 @@
-Clarify Workspace V2 tools output vs active/saved toolState UX with explicit direct publish action and published tools list - PR_26124_018-clarify-tools-vs-toolstate-ux
+Clarify Workspace V2 toolState lifecycle ownership across Producer, Tool State Library, and Published Tools with explicit named create/load/promotion flows - PR_26124_018-workspace-toolstate-lifecycle-ux

docs/dev/reports/PR_26124_018_workspace_toolstate_lifecycle_ux_report.md

@@ -0,0 +1,43 @@
+# PR_26124_018-workspace-toolstate-lifecycle-ux
+
+## Scope
+- `tools/workspace-v2/index.html`
+- `tools/workspace-v2/index.js`
+- `tests/playwright/workspace-v2.validation.spec.js`
+- `tests/ui/workspace-v2.asset-manager.spec.js`
+
+## Implementation Summary
+- Moved Tool State Library UI into the Producer panel so Producer owns:
+  - tool selector
+  - toolState ID input
+  - load/create/open/direct/promote actions
+  - saved Tool State Library list
+- Enforced named toolState lifecycle for Producer actions:
+  - `Load Tool State` now requires a valid toolState ID, loads fixture payload, saves/overwrites `savedToolStates[toolStateId]`, sets it active, and opens the selected tool.
+  - `Create & Open Tool State` now requires a valid toolState ID, saves a new `savedToolStates[toolStateId]` from active payload, sets it active, and opens the selected tool.
+  - Added seeded generated toolState ID when the input is empty to support "provide or accept generated" workflow.
+- Active promotion lifecycle:
+  - `Promote Active Tool State to Tools` publishes to `tools.<toolId>`,
+  - removes matching saved draft if present,
+  - clears active workspace toolState after publish.
+- Saved card promotion lifecycle:
+  - each card `Promote to Tools` publishes to `tools.<toolId>` and removes the saved draft entry.
+- Published Tools visibility:
+  - kept visible `Published Tools` output,
+  - excludes `workspace-v2`,
+  - includes `palette-browser` and published non-palette tools,
+  - added `Copy to Tool State` on each published non-palette tool to create a new saved draft without removing the published tool.
+- Preserved constraints:
+  - no `palette-manager-v2` toolState producer option,
+  - no palette-manager promotion path,
+  - no session wording reintroduced,
+  - no sample JSON changes.
+
+## Validation
+- `node --check tools/workspace-v2/index.js` -> pass
+- `node --check tests/playwright/workspace-v2.validation.spec.js` -> pass
+- `node --check tests/ui/workspace-v2.asset-manager.spec.js` -> pass
+- `npm run test:workspace-v2` -> pass (`20 passed`, `0 failed`)
+
+## Full Samples Smoke
+- Skipped intentionally. This PR is Workspace V2 + targeted Playwright coverage only and does not modify shared sample framework paths.

docs/dev/reports/codex_changed_files.txt

@@ -1,21 +1,19 @@
 git status --short
  M docs/dev/codex_commands.md
  M docs/dev/commit_comment.txt
- M docs/dev/reports/codex_changed_files.txt
  M docs/dev/reports/codex_review.diff
  M tests/playwright/workspace-v2.validation.spec.js
  M tests/ui/workspace-v2.asset-manager.spec.js
  M tools/workspace-v2/index.html
  M tools/workspace-v2/index.js
-?? docs/dev/reports/PR_26124_018_clarify_tools_vs_toolstate_ux_report.md
+?? docs/dev/reports/PR_26124_018_workspace_toolstate_lifecycle_ux_report.md
 
 git diff --stat
  docs/dev/codex_commands.md                       |   7 +
  docs/dev/commit_comment.txt                      |   2 +-
- docs/dev/reports/codex_changed_files.txt         | Bin 535 -> 1990 bytes
- docs/dev/reports/codex_review.diff               | 300 +++++++++++++++++++++--
- tests/playwright/workspace-v2.validation.spec.js |  11 +-
- tests/ui/workspace-v2.asset-manager.spec.js      |   2 +-
- tools/workspace-v2/index.html                    |   7 +-
- tools/workspace-v2/index.js                      |  71 +++++-
- 8 files changed, 364 insertions(+), 36 deletions(-)
+ docs/dev/reports/codex_review.diff               | 654 ++++++++++++++++-------
+ tests/playwright/workspace-v2.validation.spec.js |  30 +-
+ tests/ui/workspace-v2.asset-manager.spec.js      |   6 +-
+ tools/workspace-v2/index.html                    |  35 +-
+ tools/workspace-v2/index.js                      | 216 +++++++-
+ 7 files changed, 706 insertions(+), 244 deletions(-)