Guard session deletion add workspace save and verify Preview Generator V2 writes through repo handle - PR_26128_033-session-delete-save-and-preview-root-handle

Author: DavidQ

docs/dev/reports/playwright_session_delete_save_and_preview_root_handle.md

@@ -0,0 +1,35 @@
+# Playwright Session Delete Save And Preview Root Handle
+
+## Commands
+- `node --check tools/workspace-manager-v2/js/WorkspaceManagerV2App.js`
+- `node --check tools/workspace-manager-v2/js/services/WorkspaceManagerV2ContextService.js`
+- `node --check tools/workspace-manager-v2/js/controls/ManifestMenuControl.js`
+- `node --check tools/workspace-manager-v2/js/controls/StatusLogControl.js`
+- `node --check tools/session-inspector-v2/js/SessionInspectorV2App.js`
+- `node --check tools/preview-generator-v2/PreviewGeneratorV2App.js`
+- `node --check tools/preview-generator-v2/PreviewGeneratorV2RepoAccess.js`
+- `node --check tests/playwright/tools/WorkspaceManagerV2.spec.mjs`
+- `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list -g "launches Session Inspector V2 with V2 labels|starts with no active game even when stale session hydration exists|exports manifests and launches tools from fixed Workspace Manager V2 tiles|keeps Preview Generator V2 repo writer after Asset Manager V2 deletes the preview asset entry|guards Workspace Manager V2 Close Workspace with dirty sessions|logs actionable Preview Generator V2 output path resolution failures"`
+- `npm run test:workspace-v2`
+- `git diff --check`
+
+## Results
+- JavaScript syntax checks: passed.
+- Focused Workspace V2 coverage: passed 6/6 after the palette fixture correction.
+- Workspace Manager V2 suite: passed 19/19.
+- Diff whitespace check: passed.
+
+## Targeted Coverage
+- Verified Session Inspector V2 per-tile Delete removes one key and logs it.
+- Verified Session Inspector V2 Delete All removes displayed keys and logs individual removals plus the summary.
+- Verified Close Workspace warns and does not close when a dirty tool session exists.
+- Verified Save persists dirty session data into the Workspace Manager V2 session context and marks the dirty session clean.
+- Verified Close Workspace clears workspace session data only after dirty sessions are clean.
+- Verified Close Workspace logs each removed workspace session key.
+- Verified Preview Generator V2 logs repo handle presence and handle root name.
+- Verified Preview Generator V2 resolves `games/Asteroids/assets/images` through the repo handle.
+- Verified missing folder checks report handle-root-relative resolution details.
+- Verified `OK WRITE` appears only after handle read-back verification passes.
+
+## Skipped
+- Full samples smoke test was skipped by request. The required session deletion, Save/Close, and Preview Generator handle-root behavior is covered by `tests/playwright/tools/WorkspaceManagerV2.spec.mjs`.

docs/dev/reports/session_delete_save_and_preview_root_handle.md

@@ -0,0 +1,45 @@
+# Session Delete Save And Preview Root Handle
+
+## Scope
+- Added Workspace Manager V2 `Save` and `Close Workspace` controls.
+- Restricted Workspace Manager V2 session deletion to the explicit `Close Workspace` path.
+- Preserved Session Inspector V2 per-entry Delete and Delete All deletion behavior.
+- Updated Session Inspector V2 Delete All to log each removed key before the summary.
+- Updated Preview Generator V2 repo handle diagnostics and handle-based write verification.
+
+## Session Deletion Guardrails
+- Workspace Manager V2 lifecycle paths no longer delete normalized `workspace.tools.<tool-id>` keys.
+- Workspace Manager V2 Close Workspace checks every normalized `workspace.tools.<tool-id>.dirty` object before clearing workspace session data.
+- If any dirty session has `isDirty: true`, Close Workspace logs a visible `WARN` and leaves all session data in place.
+- If dirty state is clean and known, Close Workspace clears workspace session data and logs each removed key.
+- Session Inspector V2 Delete and Delete All remain explicit user actions and continue to log removed keys.
+
+## Save Behavior
+- Save refreshes the active workspace context from normalized tool session data.
+- Save persists the refreshed context to the current Workspace Manager V2 session context key.
+- Save marks dirty enabled tool sessions clean after the refreshed context is persisted.
+- Tool tiles refresh dirty status after Save.
+
+## Preview Generator V2 Root Handle
+- Workspace launch now logs:
+  - repo display label
+  - repo root path string
+  - repo FileSystemDirectoryHandle presence
+  - verified handle root name
+  - handle resolution for `games/<game>/assets/images`
+- Missing folder failures log:
+  - requested relative folder
+  - handle root name
+  - display repoRoot string
+  - session key used
+- Preview Generator V2 now requires handle read-back verification before logging `OK WRITE`.
+- When absolute path strings and handle-relative paths differ, both are logged and the mismatch is flagged.
+
+## Guardrails
+- No hidden fallback paths were added.
+- No direct cross-tool communication was added.
+- No sample JSON was modified.
+- No roadmap content was modified.
+
+## Skipped
+- Full samples smoke test was skipped by request. The changed behavior is covered by Workspace V2 targeted and full Playwright validation.