Continue rollback of unstable Workspace V2 changes while preserving safe UI cleanup only - PR_26128_003-continue-yesterday-rollback

Author: DavidQ

docs/dev/reports/continued_rollback_review.md

@@ -0,0 +1,24 @@
+# PR_26128_003 Continued Rollback Review
+
+## Scope
+- Continued the Workspace V2 / Preview Generator rollback after `PR_26127_019`.
+- Removed the Preview Generator V2 workspace direct-write path that used absolute `repoPath` hydration and `/__workspace-manager-v2/write-preview`.
+- Removed Workspace Manager V2 UI gating and status text that treated manifest `repoPath` as required for Preview Generator launches.
+- Removed the Playwright repo server's private preview-write endpoint and write capture maps from workspace V2 validation.
+
+## Preserved
+- `tools/session-inspector/**` is present as actual tool/runtime files and was left unchanged.
+- Workspace Manager V2 and Preview Generator V2 still launch from the Workspace Manager V2 flow through sessionStorage workspace context.
+- Accordion behavior checks remain covered by `tests/playwright/tools/WorkspaceManagerV2.spec.mjs`.
+- Schema files, sample JSON, and roadmap content were not modified.
+
+## Validation
+- `npm run test:workspace-v2` -> PASS, 10 tests.
+- Targeted Workspace Manager V2 launch validation -> PASS.
+- Targeted Preview Generator V2 launch validation -> PASS.
+- Targeted Session Inspector launch validation -> PASS.
+- Verified the private workspace preview write endpoint now returns 404 in the targeted launch validation.
+- Verified Git changed files include actual runtime/test changes, not report-only changes.
+
+## Skipped
+- Full samples smoke test was skipped by request. This rollback changes Workspace V2 / Preview Generator launch and write plumbing only; the required targeted launch checks and workspace V2 suite cover the affected surface.

docs/dev/reports/rollback_preserved_items.md

@@ -1,12 +1,13 @@
-# PR_26128_001 Rollback Preserved Items
+# PR_26128_003 Rollback Preserved Items
 
 ## Preserved Baseline
-- Preserved the committed Workspace Manager V2 accordion behavior in `tools/workspace-manager-v2/js/controls/AccordionSection.js`.
-- Preserved committed Workspace Manager V2 layout and non-runtime UI consistency updates in `tools/workspace-manager-v2/index.html` and `tools/workspace-manager-v2/styles/workspaceManagerV2.css`.
-- Preserved the committed Preview Generator V2 baseline where Workspace Manager launches hydrate from session context and tools-mode repo picking remains local to Preview Generator V2.
-- Preserved existing schema files exactly; no `tools/schemas/**` files were changed by this rollback.
-- Preserved sample JSON exactly; no `games/**`, `samples/**`, or sample manifest JSON files were changed by this rollback.
-- Preserved roadmap content exactly; no roadmap files were changed by this rollback.
+- Preserved Workspace Manager V2 accordion behavior; existing accordion validation remains in `tests/playwright/tools/WorkspaceManagerV2.spec.mjs`.
+- Preserved rename/move cleanup and cosmetic/layout-only UI consistency work outside the unstable direct-write path.
+- Preserved Workspace Manager V2 sessionStorage launch context for first-class tools.
+- Preserved Preview Generator V2 tools-mode repo picking as local Preview Generator behavior.
+- Preserved existing schema files exactly; no `tools/schemas/**` files were changed.
+- Preserved sample JSON exactly; no `games/**`, `samples/**`, or sample manifest JSON files were changed.
+- Preserved roadmap content exactly; no roadmap files were changed.
 
 ## Session Inspector Note
-- `tools/session-inspector/**` is not present in this checkout after rollback, and no files under that path were available to preserve or modify.
+- `tools/session-inspector/**` is present as actual tool/runtime files and was preserved unchanged in this rollback.

docs/dev/reports/rollback_removed_items.md

@@ -1,14 +1,15 @@
-# PR_26128_001 Rollback Removed Items
+# PR_26128_003 Rollback Removed Items
 
 ## Removed Runtime Rewrites
-- Removed the uncommitted Workspace Manager V2 repo scan/select rewrite that added `selectRepoButton`, `activeRepoSummary`, `selectRepoRoot`, repo handle persistence, and `/__repo/games` coupling.
-- Removed the uncommitted Preview Generator V2 node write mode rewrite that added `/__preview-generator-v2/write-preview`, `/__repo/status`, persisted repo handle restore, and node endpoint write selection.
-- Removed the uncommitted shared `tools/common/RepoHandleStore.js` coupling and `tools/preview-generator-v2/PreviewGeneratorV2RepoHandleStore.js` wrapper.
-- Removed the uncommitted `scripts/workspace-v2-dev-server.mjs` dev server and the related `package.json` `dev-tools` / `dev:workspace-v2` script additions.
-- Removed the uncommitted storage debug page replacement under `tests/index.html`, `tests/storage-debug.css`, and `tests/storage-debug.js`.
-- Removed the uncommitted Workspace V2 test rewrites that depended on node-backed repo selection, storage debug persistence, and persisted browser directory handles.
+- Removed Preview Generator V2 workspace absolute `repoPath` hydration used for direct preview writes.
+- Removed Preview Generator V2 `/__workspace-manager-v2/write-preview` fetch calls and `X-Workspace-Preview-*` headers.
+- Removed Preview Generator V2 direct-write validation, absolute path resolution, direct-write logging, and direct-write fallback handling.
+- Removed Workspace Manager V2 summary copy that asked users to select a repo before direct preview writes.
+- Removed Workspace Manager V2 preview tile `repoPathReady` gating and the `Select Repo` preview tile status.
+- Removed the Playwright repo server's private preview-write endpoint and preview write capture maps.
 
 ## Restored Baseline Behavior
-- Workspace Manager V2 now uses the committed static game list and sessionStorage-based workspace context flow.
-- Preview Generator V2 workspace launch uses the committed session-context repoPath hydration path and no longer depends on the removed node dev-tools server.
-- Preview Generator V2 tools-mode repo picking remains scoped to Preview Generator V2 and is not shared through IndexedDB or Workspace Manager V2 auto-wiring.
+- Workspace Manager V2 launches Preview Generator V2 with display-only workspace context.
+- Preview Generator V2 workspace launches hydrate the selected game, asset folder, preview target, and preview image without writing files.
+- Preview Generator V2 preview writes require the normal Preview Generator repo folder selection path.
+- Workspace Manager V2 no longer exposes runtime coupling for Preview Generator V2 writes.

tests/helpers/playwrightRepoServer.mjs

@@ -23,62 +23,17 @@ function isInsideRepoRoot(absolutePath) {
 }
 
 export async function startRepoServer() {
-  const previewWrites = new Map();
-  const previewAbsoluteWrites = new Map();
   const server = http.createServer(async (request, response) => {
     try {
       const requestUrl = new URL(request.url || "/", "http://127.0.0.1");
       const decodedPath = decodeURIComponent(requestUrl.pathname);
-      if (request.method === "PUT" && decodedPath === "/__workspace-manager-v2/write-preview") {
-        const absoluteWritePath = String(request.headers["x-workspace-preview-absolute-path"] || "");
-        const relativeWritePath = String(request.headers["x-workspace-preview-relative-path"] || "");
-        const resolvedWritePath = path.resolve(absoluteWritePath);
-        const repoRelativePath = relativeWritePath
-          ? relativeWritePath.replaceAll("\\", "/").replace(/^\/+/, "")
-          : path.relative(repoRoot, resolvedWritePath).replaceAll("\\", "/");
-        if (!absoluteWritePath || !isInsideRepoRoot(resolvedWritePath)) {
-          response.statusCode = 403;
-          response.end("Preview write path must be inside the repo root.");
-          return;
-        }
-        if (!repoRelativePath || repoRelativePath.startsWith("..") || path.isAbsolute(repoRelativePath)) {
-          response.statusCode = 400;
-          response.end("Preview write relative path is invalid.");
-          return;
-        }
-        const bodyChunks = [];
-        for await (const chunk of request) {
-          bodyChunks.push(chunk);
-        }
-        const body = Buffer.concat(bodyChunks).toString("utf8");
-        previewWrites.set(repoRelativePath, body);
-        previewAbsoluteWrites.set(resolvedWritePath, body);
-        response.statusCode = 200;
-        response.setHeader("Content-Type", "text/plain; charset=utf-8");
-        response.end("OK");
-        return;
-      }
       const normalizedPath = path.normalize(decodedPath).replace(/^(\.\.[/\\])+/, "");
       const absolutePath = path.resolve(repoRoot, `.${normalizedPath}`);
       if (!isInsideRepoRoot(absolutePath)) {
         response.statusCode = 403;
         response.end("Forbidden");
         return;
       }
-      if (request.method === "PUT") {
-        const bodyChunks = [];
-        for await (const chunk of request) {
-          bodyChunks.push(chunk);
-        }
-        const repoRelativePath = normalizedPath
-          .replaceAll("\\", "/")
-          .replace(/^\/+/, "");
-        previewWrites.set(repoRelativePath, Buffer.concat(bodyChunks).toString("utf8"));
-        response.statusCode = 200;
-        response.setHeader("Content-Type", "text/plain; charset=utf-8");
-        response.end("OK");
-        return;
-      }
       let targetPath = absolutePath;
       const stat = await fs.stat(targetPath).catch(() => null);
       if (stat && stat.isDirectory()) {
@@ -107,8 +62,6 @@ export async function startRepoServer() {
   return {
     baseUrl: `http://127.0.0.1:${address.port}`,
     repoRoot,
-    previewAbsoluteWrites,
-    previewWrites,
     close: async () => {
       await new Promise((resolve, reject) => {
         const forceClose = setTimeout(() => {