Complete Workspace Manager V2 review cleanup and launch validation - PR_26126_114-workspace-manager-v2-review-cleanup

Author: DavidQ

docs/dev/reports/PR_26126_114_manual_validation_notes.md

@@ -0,0 +1,27 @@
+# PR_26126_114 Manual Validation Notes
+
+## Automated Validation
+- `npm run test:asset-manager-v2` passed.
+- Result: 8 Playwright tests passed.
+- `npm run test:workspace-v2` passed.
+- Result: 19 Playwright tests passed.
+
+## Manual Checks
+1. Open `tools/workspace-manager-v2/index.html`.
+   - Expected: Workspace Manager V2 uses the shared First-Class Tool V2 theme and shows no local color drift.
+   - Expected: selecting a game creates context with active game, active palette, and active assets path.
+2. Launch Asset Manager V2 from Workspace Manager V2.
+   - Expected: Asset Manager V2 opens with `launch=workspace`, `fromTool=workspace-manager-v2`, and a `hostContextId`.
+   - Expected: Asset Manager V2 loads assets and palette from Workspace Manager V2 session context.
+3. Open `tools/asset-manager-v2/index.html`.
+   - Expected: direct launch without session/context hard-fails to the launch guard overlay.
+4. Open `tools/asset-manager-v2/index.html?workspace=prod`.
+   - Expected: direct production URL launch hard-fails to the launch guard overlay.
+5. Open `tools/asset-manager-v2/index.html?workspace=UAT`.
+   - Expected: temporary UAT-only launch remains available for isolated testing.
+
+## Out Of Scope
+- Full samples smoke test was skipped because this PR is scoped to Workspace Manager V2 review cleanup and targeted Playwright coverage.
+- Deprecated `tools/workspace-v2/` was not modified.
+- Sample JSON was not modified.
+

docs/dev/reports/PR_26126_114_workspace_manager_v2_review_notes.md

@@ -0,0 +1,27 @@
+# PR_26126_114 Workspace Manager V2 Review Notes
+
+## Review Scope
+- Reviewed Workspace Manager V2 session/context ownership for active game, active palette, and active assets path.
+- Reviewed Asset Manager V2 production launch acceptance through Workspace Manager V2 session/context only.
+- Reviewed direct launch and `?workspace=prod` guard coverage.
+- Reviewed temporary `?workspace=UAT` retention for isolated UAT testing.
+- Reviewed Workspace Manager V2 theme contract and Playwright ownership under `tests/playwright/tools`.
+
+## Cleanup
+- Removed redundant `activePaletteSwatches` state from `WorkspaceManagerV2App`.
+- Asset Manager launch gating now checks the active Workspace Manager V2 context palette directly.
+- Removed obsolete `queryGameId` and `gameRootFromGameId` helpers from `WorkspaceBridge`.
+- Removed the manifest-as-context fallback from `WorkspaceBridge.workspaceManifestFromContext`.
+- Production workspace launch now stays tied to the explicit Workspace Manager V2 session payload.
+
+## Verification
+- Workspace Manager V2 writes session context with `gameId`, `gameRoot`, `assetsPath`, `activePalette`, and `workspaceManifest`.
+- Asset Manager V2 requires `launch=workspace`, `fromTool=workspace-manager-v2`, `hostContextId`, and valid session context.
+- Direct Asset Manager V2 launch without session context hard-fails to the overlay.
+- `?workspace=prod` hard-fails to the overlay.
+- `?workspace=UAT` remains temporary-only and isolated.
+- No changed files under deprecated `tools/workspace-v2/`.
+- No sample JSON files were modified.
+- Workspace Manager V2 CSS still resolves through Template V2 theme tokens without local color drift.
+- Asset Manager V2, Preview Generator V2, and Workspace Manager V2 Playwright specs remain under `tests/playwright/tools`.
+

tools/asset-manager-v2/js/services/WorkspaceBridge.js

@@ -52,15 +52,6 @@ export class WorkspaceBridge {
     return new URLSearchParams(this.window.location.search).get("hostContextId") || "";
   }
 
-  queryGameId() {
-    return new URLSearchParams(this.window.location.search).get("gameId") || "";
-  }
-
-  gameRootFromGameId(gameId) {
-    const normalizedGameId = String(gameId || "").trim().replace(/[\\/]+/g, "-");
-    return normalizedGameId ? `games/${normalizedGameId}/` : "";
-  }
-
   validateWorkspaceManagerContext(context) {
     if (!isPlainObject(context)) {
       return { ok: false, message: "Workspace Manager V2 session context is invalid." };
@@ -125,9 +116,6 @@ export class WorkspaceBridge {
     if (isPlainObject(context.workspaceManifest)) {
       return context.workspaceManifest;
     }
-    if (context.documentKind === "workspace-manifest") {
-      return context;
-    }
     return null;
   }
 

tools/workspace-manager-v2/js/WorkspaceManagerV2App.js

@@ -15,7 +15,6 @@ export class WorkspaceManagerV2App {
     this.summary = summary;
     this.activeContext = null;
     this.activeGame = null;
-    this.activePaletteSwatches = [];
   }
 
   start() {
@@ -38,7 +37,6 @@ export class WorkspaceManagerV2App {
   async selectGame(gameId) {
     this.activeContext = null;
     this.activeGame = null;
-    this.activePaletteSwatches = [];
     this.launchControl.setEnabled(false);
     this.summary.clear();
 
@@ -58,7 +56,6 @@ export class WorkspaceManagerV2App {
 
     this.activeContext = result.context;
     this.activeGame = result.game;
-    this.activePaletteSwatches = result.paletteSwatches;
     this.gameSelector.setSummary(`${result.game.name} context uses ${result.game.gameRoot} and ${result.game.assetsPath}.`);
     this.summary.render({
       context: result.context,
@@ -71,7 +68,7 @@ export class WorkspaceManagerV2App {
   }
 
   launchAssetManager() {
-    if (!this.activeContext || !this.activeGame || !this.activePaletteSwatches.length) {
+    if (!this.activeContext || !this.activeGame || !this.activeContext.activePalette?.swatches?.length) {
       this.statusLog.fail("Launch blocked: active game context and palette are required.");
       return;
     }